Re: Required vs Optional Reviewers

2014-02-04 Thread markdbeyer
To mimic your email practice, about creating review groups containing all 
reviewers and then specifically calling out required reviewers in 
target-people ? 

You could enforce that policy via an external API or an extension. We don't 
use the above policy exactly, but we do have a script that applies our 
policy in order to close reviews.

Hope that helps.

Mark

On Tuesday, February 4, 2014 12:31:01 PM UTC-8, Javins, Walt wrote:

  Has there been any discussion around ‘required’ vs ‘optional’ reviewers 
 on a rrq?

  

 Prior to Review Board, we would use email for CR, and could specify the 
 ‘To:’ vs ‘Cc:’ headers to communicate the importance that a particular 
 individual or group look at a piece of code.  E.g. A lot of time we’ll put 
 new team members on a CR to help them learn the code/development standards 
 by observing, but their yea/nay isn’t strictly necessary. I’ve had several 
 of my consumers ask about implementing similar features, and I was 
 wondering if the RB community has tackled similar issues or requests.

  

 I searched the mailing list archives, and came across many policy 
 enforcement threads which shed a lot of light on the issue, and RB’s 
 somewhat hands-off approach given the complexities of different orgs 
 different CR policies.  Even so, I’m interested to know what other 
 community members have implemented to handle ‘these people must review the 
 code’ whereas ‘these people may be interested’ in the patch.  

  

 Thanks,

 Walt
  

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Access for user 'www-data' has not been enabled by 'p4 protect'

2014-02-04 Thread Karl Nordstrom
I am attempting to post a review from perforce to ReviewBoard. RBTools 
appears to be providing a GNU compatible diff now, which is great (thanks 
for your help so far). The problem is with the upload.

This is what I get

C:\code\knordstrom_passenger\sw\transit\passenger\testrbt post -d
DEBUG:root:Checking for a Subversion repository...
DEBUG:root:Checking for a Git repository...
DEBUG:root:Checking for a Mercurial repository...
DEBUG:root:Checking for a CVS repository...
DEBUG:root:Checking for a Perforce repository...
DEBUG:root:Running: p4 info
DEBUG:root:Running: diff --version
DEBUG:root:repository info: Path: stork.questercorp.local:1666, Base path: 
None, Supports changesets: True
DEBUG:root:Making HTTP GET request to http://reviewboard/api/
DEBUG:root:Making HTTP GET request to http://reviewboard/api/info/
INFO:root:Generating diff for changenum default
DEBUG:root:Running: p4 opened -c default
DEBUG:root:Processing edit of 
//depot/sw/transit/passenger/test/dsptools/filterdesign.py
DEBUG:root:Writing 
//depot/sw/transit/passenger/test/dsptools/filterdesign.py#1 to 
c:\users\knords~1\appdata\local\temp\tmpbuccxx
DEBUG:root:Running: p4 print -o 
c:\users\knords~1\appdata\local\temp\tmpbuccxx -q 
//depot/sw/transit/passenger/test/dsptools/filterdesign.py#1
DEBUG:root:Running: diff -urNp 
c:\users\knords~1\appdata\local\temp\tmpbuccxx 
C:\code\knordstrom_passenger\sw\transit\passenger\test\dsptools\filterdesign.py
DEBUG:root:Command exited with rc 1: ['diff', '-urNp', 
'c:\\users\\knords~1\\appdata\\local\\temp\\tmpbuccxx', 
'C:\\code\\knordstrom_passenger\\sw\\transit\\passenger\\test\\dsptools\\filterdesign.py']
--- c:\users\knords~1\appdata\local\temp\tmpbuccxx  2014-02-04 
12:47:15.189232400 -0800
+++ 
C:\code\knordstrom_passenger\sw\transit\passenger\test\dsptools\filterdesign.py 

2014-01-28 15:53:06.177664000 -0800
@@ -2,6 +2,8 @@ import numpy as np
 from scipy import signal
 import matplotlib.pyplot as pl

+#test
+
 if 0:
 # FIR decimation filter from 48000Hz to 200Hz
 # retain 0-12.5
---
...
...similar output for other files here...
...
---
DEBUG:root:Processing edit of 
//depot/sw/transit/passenger/test/stipa/rwav.py
DEBUG:root:Writing //depot/sw/transit/passenger/test/stipa/rwav.py#2 to 
c:\users\knords~1\appdata\local\temp\tmpbuccxx
DEBUG:root:Running: p4 print -o 
c:\users\knords~1\appdata\local\temp\tmpbuccxx -q 
//depot/sw/transit/passenger/test/stipa/rwav.py#2
DEBUG:root:Running: diff -urNp 
c:\users\knords~1\appdata\local\temp\tmpbuccxx 
C:\code\knordstrom_passenger\sw\transit\passenger\test\stipa\rwav.py
DEBUG:root:Processing edit of 
//depot/sw/transit/passenger/test/stipa/sines.py
DEBUG:root:Writing //depot/sw/transit/passenger/test/stipa/sines.py#2 to 
c:\users\knords~1\appdata\local\temp\tmpbuccxx
DEBUG:root:Running: p4 print -o 
c:\users\knords~1\appdata\local\temp\tmpbuccxx -q 
//depot/sw/transit/passenger/test/stipa/sines.py#2
DEBUG:root:Running: diff -urNp 
c:\users\knords~1\appdata\local\temp\tmpbuccxx 
C:\code\knordstrom_passenger\sw\transit\passenger\test\stipa\sines.py
DEBUG:root:Making HTTP GET request to 
http://reviewboard/api/review-requests/
DEBUG:root:Making HTTP POST request to 
http://reviewboard/api/review-requests/
DEBUG:root:Making HTTP GET request to 
http://reviewboard/api/review-requests/15/diffs/
DEBUG:root:Making HTTP POST request to 
http://reviewboard/api/review-requests/15/diffs/
DEBUG:root:Got API Error 105 (HTTP code 400): One or more fields had errors
DEBUG:root:Error data: {u'fields': {u'path': [u'[P4#run] Errors during 
command execution( p4 files 
//depot/sw/transit/passenger/test/dsptools/filterdesign.py#1 
)\n\n\t[Error]: Access for user \'www-data\' has not been
enabled by \'p4 protect\'.\n\n']}, u'stat': u'fail', u'err': {u'msg': 
u'One or more fields had errors', u'code': 105}}
Traceback (most recent call last):
  File C:\Python27\Scripts\rbt-script.py, line 9, in module
load_entry_point('RBTools==0.5.7', 'console_scripts', 'rbt')()
  File 
C:\Python27\lib\site-packages\rbtools-0.5.7-py2.7.egg\rbtools\commands\main.py,
 
line 127, in main
command.run_from_argv([RB_MAIN] + args)
  File 
C:\Python27\lib\site-packages\rbtools-0.5.7-py2.7.egg\rbtools\commands\__init__.py,
 
line 158, in run_from_argv
exit_code = self.main(*args) or 0
  File 
C:\Python27\lib\site-packages\rbtools-0.5.7-py2.7.egg\rbtools\commands\post.py,
 
line 659, in main
submit_as=self.options.submit_as)
  File 
C:\Python27\lib\site-packages\rbtools-0.5.7-py2.7.egg\rbtools\commands\post.py,
 
line 534, in post_request
raise CommandError('\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff

One or more fields had errors (HTTP 400, API Error 105)

path: [P4#run] Errors during command execution( p4 files 
//depot/sw/transit/passenger/test/dsptools/filterdesign.py#1 )

[Error]: Access for user 'www-data' has not been enabled by 'p4 
protect'.

Your review request still exists, but the diff is not attached.


So, 

Re: Access for user 'www-data' has not been enabled by 'p4 protect'

2014-02-04 Thread David Trowbridge
The problem here isn't with rbtools, but rather with the configuration of
the repository in review board.

-David


On Tue, Feb 4, 2014 at 1:04 PM, Karl Nordstrom northstr...@gmail.comwrote:

 I am attempting to post a review from perforce to ReviewBoard. RBTools
 appears to be providing a GNU compatible diff now, which is great (thanks
 for your help so far). The problem is with the upload.

 This is what I get

 C:\code\knordstrom_passenger\sw\transit\passenger\testrbt post -d
 DEBUG:root:Checking for a Subversion repository...
 DEBUG:root:Checking for a Git repository...
 DEBUG:root:Checking for a Mercurial repository...
 DEBUG:root:Checking for a CVS repository...
 DEBUG:root:Checking for a Perforce repository...
 DEBUG:root:Running: p4 info
 DEBUG:root:Running: diff --version
 DEBUG:root:repository info: Path: stork.questercorp.local:1666, Base path:
 None, Supports changesets: True
 DEBUG:root:Making HTTP GET request to http://reviewboard/api/
 DEBUG:root:Making HTTP GET request to http://reviewboard/api/info/
 INFO:root:Generating diff for changenum default
 DEBUG:root:Running: p4 opened -c default
 DEBUG:root:Processing edit of
 //depot/sw/transit/passenger/test/dsptools/filterdesign.py
 DEBUG:root:Writing
 //depot/sw/transit/passenger/test/dsptools/filterdesign.py#1 to
 c:\users\knords~1\appdata\local\temp\tmpbuccxx
 DEBUG:root:Running: p4 print -o
 c:\users\knords~1\appdata\local\temp\tmpbuccxx -q
 //depot/sw/transit/passenger/test/dsptools/filterdesign.py#1
 DEBUG:root:Running: diff -urNp
 c:\users\knords~1\appdata\local\temp\tmpbuccxx
 C:\code\knordstrom_passenger\sw\transit\passenger\test\dsptools\filterdesign.py
 DEBUG:root:Command exited with rc 1: ['diff', '-urNp',
 'c:\\users\\knords~1\\appdata\\local\\temp\\tmpbuccxx',
 'C:\\code\\knordstrom_passenger\\sw\\transit\\passenger\\test\\dsptools\\filterdesign.py']
 --- c:\users\knords~1\appdata\local\temp\tmpbuccxx  2014-02-04 12:47:
 15.189232400 -0800
 +++
 C:\code\knordstrom_passenger\sw\transit\passenger\test\dsptools\filterdesign.py
 2014-01-28 15:53:06.177664000 -0800
 @@ -2,6 +2,8 @@ import numpy as np
  from scipy import signal
  import matplotlib.pyplot as pl

 +#test
 +
  if 0:
  # FIR decimation filter from 48000Hz to 200Hz
  # retain 0-12.5
 ---
 ...
 ...similar output for other files here...
 ...
 ---
 DEBUG:root:Processing edit of
 //depot/sw/transit/passenger/test/stipa/rwav.py
 DEBUG:root:Writing //depot/sw/transit/passenger/test/stipa/rwav.py#2 to
 c:\users\knords~1\appdata\local\temp\tmpbuccxx
 DEBUG:root:Running: p4 print -o
 c:\users\knords~1\appdata\local\temp\tmpbuccxx -q
 //depot/sw/transit/passenger/test/stipa/rwav.py#2
 DEBUG:root:Running: diff -urNp
 c:\users\knords~1\appdata\local\temp\tmpbuccxx
 C:\code\knordstrom_passenger\sw\transit\passenger\test\stipa\rwav.py
 DEBUG:root:Processing edit of
 //depot/sw/transit/passenger/test/stipa/sines.py
 DEBUG:root:Writing //depot/sw/transit/passenger/test/stipa/sines.py#2 to
 c:\users\knords~1\appdata\local\temp\tmpbuccxx
 DEBUG:root:Running: p4 print -o
 c:\users\knords~1\appdata\local\temp\tmpbuccxx -q
 //depot/sw/transit/passenger/test/stipa/sines.py#2
 DEBUG:root:Running: diff -urNp
 c:\users\knords~1\appdata\local\temp\tmpbuccxx
 C:\code\knordstrom_passenger\sw\transit\passenger\test\stipa\sines.py
 DEBUG:root:Making HTTP GET request to
 http://reviewboard/api/review-requests/
 DEBUG:root:Making HTTP POST request to
 http://reviewboard/api/review-requests/
 DEBUG:root:Making HTTP GET request to
 http://reviewboard/api/review-requests/15/diffs/
 DEBUG:root:Making HTTP POST request to
 http://reviewboard/api/review-requests/15/diffs/
 DEBUG:root:Got API Error 105 (HTTP code 400): One or more fields had errors
 DEBUG:root:Error data: {u'fields': {u'path': [u'[P4#run] Errors during
 command execution( p4 files
 //depot/sw/transit/passenger/test/dsptools/filterdesign.py#1
 )\n\n\t[Error]: Access for user \'www-data\' has not been
 enabled by \'p4 protect\'.\n\n']}, u'stat': u'fail', u'err': {u'msg':
 u'One or more fields had errors', u'code': 105}}
 Traceback (most recent call last):
   File C:\Python27\Scripts\rbt-script.py, line 9, in module
 load_entry_point('RBTools==0.5.7', 'console_scripts', 'rbt')()
   File
 C:\Python27\lib\site-packages\rbtools-0.5.7-py2.7.egg\rbtools\commands\main.py,
 line 127, in main
 command.run_from_argv([RB_MAIN] + args)
   File
 C:\Python27\lib\site-packages\rbtools-0.5.7-py2.7.egg\rbtools\commands\__init__.py,
 line 158, in run_from_argv
 exit_code = self.main(*args) or 0
   File
 C:\Python27\lib\site-packages\rbtools-0.5.7-py2.7.egg\rbtools\commands\post.py,
 line 659, in main
 submit_as=self.options.submit_as)
   File
 C:\Python27\lib\site-packages\rbtools-0.5.7-py2.7.egg\rbtools\commands\post.py,
 line 534, in post_request
 raise CommandError('\n'.join(error_msg))
 rbtools.commands.CommandError: Error uploading diff

 One or more fields had errors (HTTP 400, API Error 105)

 path: [P4#run] Errors during 

Re: Access for user 'www-data' has not been enabled by 'p4 protect'

2014-02-04 Thread Karl Nordstrom
Thanks, that did it. I just had to enter a valid username and password in 
Review Board.

Karl

On Tuesday, 4 February 2014 13:06:32 UTC-8, David Trowbridge wrote:

 The problem here isn't with rbtools, but rather with the configuration of 
 the repository in review board.

 -David



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: The current directory does not contain a checkout... (problem posting from perforce)

2014-02-04 Thread Karl Nordstrom
Thanks for the quick fix! 0.5.7 did it.

Karl

On Monday, 3 February 2014 13:50:03 UTC-8, Karl Nordstrom wrote:

 Okay, looking forward to getting the fix.

 Thanks,
 Karl

 On Monday, 3 February 2014 13:28:17 UTC-8, David Trowbridge wrote:

 Karl,

 It looks like we introduced a regression in 0.5.6 where it only will post 
 from the client root. We'll get this sorted out asap.

 -David


 On Mon, Feb 3, 2014 at 1:17 PM, Karl Nordstrom north...@gmail.comwrote:

 I am attempting to generate a diff using rbt diff from a perforce 
 workspace. I get the same error when I do rbt post.

 (Thank you for helping with the previous problem I was having, it 
 appears to be resolved with RBTools 0.5.6.)

 My p4config is as follows:

 P4PORT=stork:1666
 P4USER=knordstrom
 P4CLIENT=knordstrom_passenger

 The p4config appears to be setup correctly. I can do p4 diff from the 
 commandline and generate a diff without errors. Unfortunately, this diff is 
 not in a format that ReviewBoard understands.

 My .reviewboard rc file is as follows (just one line):

 REVIEWBOARD_URL = http://reviewboard/;

 I have tried the following on the commandline:

 rbt diff -d
 rbt diff -d 25012   (the latest changelist number)
 rbt post -d
 rbt post -d 25012

 In all cases I get the same result:

 DEBUG:root:Checking for a Subversion repository...
 DEBUG:root:Checking for a Git repository...
 DEBUG:root:Checking for a Mercurial repository...
 DEBUG:root:Checking for a CVS repository...
 DEBUG:root:Checking for a Perforce repository...
 DEBUG:root:Running: p4 info
 DEBUG:root:Checking for a Plastic repository...
 DEBUG:root:Checking for a ClearCase repository...
 DEBUG:root:Checking for a Bazaar repository...
 ERROR:root:The current directory does not contain a checkout from a 
 supported source code repository.

 When I do p4 info it provides relevant information. I'm hesitant to 
 post it here as it shows company specific information.

 Is there something that I need to do in the configuration?

 Is this something to do with the way that Perforce works? As far as I 
 can tell, Perforce works on workspaces (a collection of files that are 
 being edited) rather than directories. That said, I would have thought that 
 RBTools could find it via p4 diff, which references p4config. 

 Ideally, I want to post to reviewboard based on changed files rather 
 than an already committed changelist, but right now any solution would be 
 welcome.

 Does anyone have an example of how to configure RBTools to work with 
 Perforce? I have searched all over and have not found any concrete examples.

 Thanks,
 Karl

 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Required vs Optional Reviewers

2014-02-04 Thread Igor Berger
Our convention when sending out a review is: add required individuals 
reviewers to People, and the review group that owns the code to Groups.

This way everybody know who should review the change, and the entire group 
is aware of upcoming changes, which can be used for training.


On Tuesday, February 4, 2014 3:31:01 PM UTC-5, Javins, Walt wrote:

  Has there been any discussion around ‘required’ vs ‘optional’ reviewers 
 on a rrq?

  

 Prior to Review Board, we would use email for CR, and could specify the 
 ‘To:’ vs ‘Cc:’ headers to communicate the importance that a particular 
 individual or group look at a piece of code.  E.g. A lot of time we’ll put 
 new team members on a CR to help them learn the code/development standards 
 by observing, but their yea/nay isn’t strictly necessary. I’ve had several 
 of my consumers ask about implementing similar features, and I was 
 wondering if the RB community has tackled similar issues or requests.

  

 I searched the mailing list archives, and came across many policy 
 enforcement threads which shed a lot of light on the issue, and RB’s 
 somewhat hands-off approach given the complexities of different orgs 
 different CR policies.  Even so, I’m interested to know what other 
 community members have implemented to handle ‘these people must review the 
 code’ whereas ‘these people may be interested’ in the patch.  

  

 Thanks,

 Walt
  

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2442 in reviewboard: Using context menu clipboard commands doesn't trigger change detection in the comment dialog

2014-02-04 Thread reviewboard

Updates:
Status: PendingReview
Owner: trowb...@gmail.com
Labels: -EasyFix

Comment #7 on issue 2442 by trowb...@gmail.com: Using context menu  
clipboard commands doesn't trigger change detection in the comment dialog

http://code.google.com/p/reviewboard/issues/detail?id=2442

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2342 in reviewboard: Mention ~/.post-review-cookies.txt in the post-review page

2014-02-04 Thread reviewboard

Updates:
Status: Fixed

Comment #3 on issue 2342 by trowb...@gmail.com: Mention  
~/.post-review-cookies.txt in the post-review page

http://code.google.com/p/reviewboard/issues/detail?id=2342

Fixed in rbtools master (6072b95). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2916 in reviewboard: Review Board does not respect line endings

2014-02-04 Thread reviewboard


Comment #19 on issue 2916 by inebriec...@gmail.com: Review Board does not  
respect line endings

http://code.google.com/p/reviewboard/issues/detail?id=2916

1.7.14 has this issue as well...

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3218 in reviewboard: rbt can only post from client root when using perforce

2014-02-04 Thread reviewboard


Comment #4 on issue 3218 by quanah.g...@gmail.com: rbt can only post from  
client root when using perforce

http://code.google.com/p/reviewboard/issues/detail?id=3218

I see the announcement for 0.5.7 is out for this fix, but this release does  
not actually show up anywhere?


I.e.,

Not via easy_install
Not on the website http://downloads.reviewboard.org/releases/RBTools/0.5/

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2342 in reviewboard: Mention ~/.post-review-cookies.txt in the post-review page

2014-02-04 Thread reviewboard


Comment #4 on issue 2342 by hekevint...@gmail.com: Mention  
~/.post-review-cookies.txt in the post-review page

http://code.google.com/p/reviewboard/issues/detail?id=2342

Can you provide the link to the changeset?  I grepped the repo and could  
not find the new documentation.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2342 in reviewboard: Mention ~/.post-review-cookies.txt in the post-review page

2014-02-04 Thread reviewboard


Comment #5 on issue 2342 by trowb...@gmail.com: Mention  
~/.post-review-cookies.txt in the post-review page

http://code.google.com/p/reviewboard/issues/detail?id=2342

https://github.com/reviewboard/rbtools/commit/6072b95dd6ba37ffc4bf846d88917f08e13d0549

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3158 in reviewboard: Admin topbar menu hidden under changelist due to z-index

2014-02-04 Thread reviewboard

Updates:
Status: Fixed

Comment #3 on issue 3158 by trowb...@gmail.com: Admin topbar menu hidden  
under changelist due to z-index

http://code.google.com/p/reviewboard/issues/detail?id=3158

This has been fixed for a while.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2442 in reviewboard: Using context menu clipboard commands doesn't trigger change detection in the comment dialog

2014-02-04 Thread reviewboard

Updates:
Status: Fixed

Comment #8 on issue 2442 by trowb...@gmail.com: Using context menu  
clipboard commands doesn't trigger change detection in the comment dialog

http://code.google.com/p/reviewboard/issues/detail?id=2442

Fixed in master (1b05b69). This will ship in 2.0 beta 3.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2649 in reviewboard: HTTPS certificate not accepted. Please ensure that the proper certificate exists in /var/www/reviewboard/data/.subversion/auth for the user that reviewboard is running a

2014-02-04 Thread reviewboard

Updates:
Status: SetupIssue

Comment #10 on issue 2649 by trowb...@gmail.com: HTTPS certificate not  
accepted. Please ensure that the proper certificate exists in  
/var/www/reviewboard/data/.subversion/auth for the user that reviewboard is  
running as.

http://code.google.com/p/reviewboard/issues/detail?id=2649

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 774 in reviewboard: Review tracker for user

2014-02-04 Thread reviewboard


Comment #13 on issue 774 by trowb...@gmail.com: Review tracker for user
http://code.google.com/p/reviewboard/issues/detail?id=774

Issue 2654 has been merged into this issue.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2654 in reviewboard: Set, jump between bookmarks in DiffViewer

2014-02-04 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 774

Comment #3 on issue 2654 by trowb...@gmail.com: Set, jump between bookmarks  
in DiffViewer

http://code.google.com/p/reviewboard/issues/detail?id=2654

Very similar to 774.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3204 in reviewboard: Viewing review groups that you are watching no longer works.

2014-02-04 Thread reviewboard

Updates:
Status: Fixed

Comment #5 on issue 3204 by trowb...@gmail.com: Viewing review groups that  
you are watching no longer works.

http://code.google.com/p/reviewboard/issues/detail?id=3204

Fixed in release-1.7.x (9d6d88e). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2342 in reviewboard: Mention ~/.post-review-cookies.txt in the post-review page

2014-02-04 Thread reviewboard


Comment #6 on issue 2342 by hekevint...@gmail.com: Mention  
~/.post-review-cookies.txt in the post-review page

http://code.google.com/p/reviewboard/issues/detail?id=2342

Oh I hadn't realized the repo had been moved to GitHub.  Thanks.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2342 in reviewboard: Mention ~/.post-review-cookies.txt in the post-review page

2014-02-04 Thread reviewboard


Comment #7 on issue 2342 by chip...@gmail.com: Mention  
~/.post-review-cookies.txt in the post-review page

http://code.google.com/p/reviewboard/issues/detail?id=2342

Many, many, many years ago. You don't want to use anything from that old  
repo.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 2125 in reviewboard: Page elements overlap when review request summary is too long

2014-02-04 Thread reviewboard

Updates:
Status: Fixed

Comment #5 on issue 2125 by trowb...@gmail.com: Page elements overlap when  
review request summary is too long

http://code.google.com/p/reviewboard/issues/detail?id=2125

Fixed in master (f24d424). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.