Re: Pre-Commit Workflow

2014-02-19 Thread Allen
Really good question! I also encounter the same problem. Developers dont want to wait until the previous review passed to work on the next issue. One solution I think is, once a review passed, apply that review`s patch file to a new working copy without touching what you are currently working

Paths in the Patch file

2014-02-19 Thread Allen
After a code review is created, there`s a button for user to download the patch file. The problem I have here is, I tried to apply that patch file to my local working copy, but the paths are wrong! Seems the rbtool changes all the files` path when creating a code review. Here`s a example of

Re: Paths in the Patch file

2014-02-19 Thread Andrew Hills (anhills)
Is it just me, or do those paths look identical? Those are paths relative to the repository root, and doesn't seem to have anything to do with remote servers. On Feb 19, 2014, at 10:40 AM, Allen zhangsan8...@gmail.commailto:zhangsan8...@gmail.com wrote: After a code review is created, there`s

Snapshot/Static View support in RB

2014-02-19 Thread Vivek Gupta
Hi All, We, in our organization, are doing a feasibility study of using Clearcase with ReviewBoard (ver 1.7). We have created repositories using Dynamic view VOBs in CC. We have successfully created review requests using dynamic view on the client PC. Our question here is..Whether

Re: Paths in the Patch file

2014-02-19 Thread Christian Hammond
Agreed. This looks exactly like what I'd expect to see. It's a typical result from running 'svn diff'. Christian On Wednesday, February 19, 2014, Andrew Hills (anhills) anhi...@cisco.com wrote: Is it just me, or do those paths look identical? Those are paths relative to the repository root,

Unicode + ldap login traceback

2014-02-19 Thread Javins, Walt
Hi RB Community, I recently had a individual contributor report that he was unable to login to our instance of reviewboard, and the server was giving a 500 error. When I checked the logs, I saw the following traceback: 2014-01-30 15:02:12,208 - DEBUG - - User un...@company.com is trying to

Re: Pre-Commit Workflow

2014-02-19 Thread David Trowbridge
The typical way that other dvcs users do this is to have local branches for each piece of work, and post from each of those. I don't know enough about bzr's workflow to know if that would be appropriate (though I recall bzr branches being pretty heavyweight). -David On Feb 15, 2014, at 12:51

Re: Paths in the Patch file

2014-02-19 Thread Allen
Yes, that`s the relative path to the Repository in the SVN server. The thing is when I run svn dff, I get these paths: Index: src/ReviewBoardTest.java === --- src/ReviewBoardTest.java(revision 167) +++ src/ReviewBoardTest.java

Re: Paths in the Patch file

2014-02-19 Thread Allen
When I run svn dff, I get these paths: --- src/ReviewBoardTest.java(revision 167) +++ src/ReviewBoardTest.java(working copy) The paths above are my local ones, and I can use these paths do a apply patch. While when I run rbt diff or rbt post, I got those paths, and I can not use those

Re: Paths in the Patch file

2014-02-19 Thread David Trowbridge
That's what patch's -p option is for. If your local path is src/ReviewBoardTest.java, and the diff has /trunk/ReviewBoardTest/src/ReviewBoardTest.java, you can apply the patch using: patch -p3 ReviewBoardTest.java -David On Wed, Feb 19, 2014 at 1:26 PM, Allen zhangsan8...@gmail.com wrote:

Re: Paths in the Patch file

2014-02-19 Thread Allen
Cool, thanks. Another way is to generate a patch file using the SVN and then create a code review with that patch file, then the paths wont mess up. On Wednesday, February 19, 2014 4:32:26 PM UTC-5, David Trowbridge wrote: That's what patch's -p option is for. If your local path is

Re: Unicode + ldap login traceback

2014-02-19 Thread David Trowbridge
Walt, It looks like we need to do some encoding gymnastics because python-ldap doesn't handle unicode strings nicely. Would you mind filing a bug about this? Thanks, -David On Wed, Feb 19, 2014 at 11:30 AM, Javins, Walt walt.jav...@isilon.comwrote: Hi RB Community, I recently had a

RE: Unicode + ldap login traceback

2014-02-19 Thread Javins, Walt
Thanks David! I’ve filed the bug here: http://code.google.com/p/reviewboard/issues/detail?id=3256 Let me know what else I can do to help out! Walt From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of David Trowbridge Sent: Wednesday, February 19, 2014 1:42 PM

Add comments via API

2014-02-19 Thread Karel Novotny
Hi, I am doing an utility, that do an automated pre-review on reviewboard. It takes files/diffs of the review and process them through some code analysis (CheckStyle) and adds comments to the review.I am using RB API for this, but I didn't find any way, how to add a comment via API. Is there

Re: Issue 3045 in reviewboard: when updating new diff on existing reviews on reviewboard server in clearcase source file revision is not LATEST

2014-02-19 Thread reviewboard
Comment #12 on issue 3045 by saar.net...@gmail.com: when updating new diff on existing reviews on reviewboard server in clearcase source file revision is not LATEST http://code.google.com/p/reviewboard/issues/detail?id=3045 This is what I have found: The new diff is on the server, however,

Re: Issue 3253 in reviewboard: post-review without US locale fails

2014-02-19 Thread reviewboard
Comment #6 on issue 3253 by kenny.ma...@gmail.com: post-review without US locale fails http://code.google.com/p/reviewboard/issues/detail?id=3253 Awesome. Thank you! -- You received this message because this project is configured to send all issue notifications to this address. You may

Re: Issue 3254 in reviewboard: reviewboard.accounts.backends.AuthBackend.login_instructions not documented

2014-02-19 Thread reviewboard
Updates: Status: Fixed Comment #1 on issue 3254 by trowb...@gmail.com: reviewboard.accounts.backends.AuthBackend.login_instructions not documented http://code.google.com/p/reviewboard/issues/detail?id=3254 Fixed in master (d2364ff). Thanks! -- You received this message because this

Issue 3256 in reviewboard: unable to log in (http 500) when using ldap auth backend + unicode password

2014-02-19 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3256 by walt.jav...@gmail.com: unable to log in (http 500) when using ldap auth backend + unicode password http://code.google.com/p/reviewboard/issues/detail?id=3256 What version are you running? RB 1.7.21 What's the

Re: Issue 2045 in reviewboard: Show changes to description or testing done fields as a real diff

2014-02-19 Thread reviewboard
Updates: Status: Fixed Comment #3 on issue 2045 by trowb...@gmail.com: Show changes to description or testing done fields as a real diff http://code.google.com/p/reviewboard/issues/detail?id=2045 Fixed in master (a2f9c31). This will ship in 2.0 beta 3. Thanks! -- You received this

Re: Issue 3223 in reviewboard: Adding or replacing screenshots isn't represented in change descriptions.

2014-02-19 Thread reviewboard
Updates: Status: Fixed Comment #2 on issue 3223 by trowb...@gmail.com: Adding or replacing screenshots isn't represented in change descriptions. http://code.google.com/p/reviewboard/issues/detail?id=3223 Fixed in master (634e674). -- You received this message because this project is

Re: Issue 3045 in reviewboard: when updating new diff on existing reviews on reviewboard server in clearcase source file revision is not LATEST

2014-02-19 Thread reviewboard
Comment #14 on issue 3045 by saar.net...@gmail.com: when updating new diff on existing reviews on reviewboard server in clearcase source file revision is not LATEST http://code.google.com/p/reviewboard/issues/detail?id=3045 I have tried what you have suggested. I have created a new review

Re: Issue 3045 in reviewboard: when updating new diff on existing reviews on reviewboard server in clearcase source file revision is not LATEST

2014-02-19 Thread reviewboard
Comment #15 on issue 3045 by trowb...@gmail.com: when updating new diff on existing reviews on reviewboard server in clearcase source file revision is not LATEST http://code.google.com/p/reviewboard/issues/detail?id=3045 Are you logged in to the Review Board UI as builder ? -- You

Re: Issue 1986 in reviewboard: CVS repository(pserver) addition fails

2014-02-19 Thread reviewboard
Comment #14 on issue 1986 by trowb...@gmail.com: CVS repository(pserver) addition fails http://code.google.com/p/reviewboard/issues/detail?id=1986 The change for this fix is not in the 1.7.21 release. It will ship in 2.0 beta 3, which is shipping soon (but that's definitely beta-quality).