Issue 3745 in reviewboard: Unable to set some settings via rb-site manage

2015-01-30 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3745 by chris.re...@york.ac.uk: Unable to set some settings via  
rb-site manage

https://code.google.com/p/reviewboard/issues/detail?id=3745

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
2.0.12


What's the URL of the page containing the problem?
N/A


What steps will reproduce the problem?
1. Install ReviewBoard
2. Use rb-site manage to get or set, for example,  
mail_send_review_close_mail or mail_send_new_user_mail



What is the expected output? What do you see instead?
- mail_send_review_close_mail
  - rb-site manage /var/www/reviewboard get-siteconfig -- --key  
mail_send_review_close_mail

- Expected: false
- Received: CommandError: 'mail_send_review_close_mail' is not a valid  
settings key [and an exit status of 1]
  - rb-site manage /var/www/reviewboard set-siteconfig -- --key  
mail_send_review_close_mail --value 1

- Expected: Setting 'mail_send_review_close_mail' to true
- Received: CommandError: 'mail_send_review_close_mail' is not a valid  
settings key [and an exit status of 1]

- mail_send_new_user_mail
  - rb-site manage /var/www/reviewboard get-siteconfig -- --key  
mail_send_new_user_mail

- Expected: false
- Received: CommandError: 'mail_send_new_user_mail' is not a valid  
settings key [and an exit status of 1]
  - rb-site manage /var/www/reviewboard set-siteconfig -- --key  
mail_send_new_user_mail --value 1

- Expected: Setting 'mail_send_new_user_mail' to true
- Received: CommandError: 'mail_send_new_user_mail' is not a valid  
settings key [and an exit status of 1]



What operating system are you using? What browser?
Ubuntu 14.04, browser N/A


Please provide any additional information below.
Once these settings have been saved in the web admin interface it becomes  
possible to manage these via rb-site manage (subject to the problems  
described in issue #3743). Another setting that is affected by this is  
auth_enable_registration. These issues make it difficult to manage  
configuration of reviewboard programmatically, such as when using a  
configuration management tool like Puppet.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3487 in reviewboard: Authentication error when connecting to svn without public access

2015-01-30 Thread reviewboard


Comment #5 on issue 3487 by chris.re...@york.ac.uk: Authentication error  
when connecting to svn without public access

https://code.google.com/p/reviewboard/issues/detail?id=3487

Confirmed broken in 2.0.6 as well (with a less detailed error message in  
the interface).


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3487 in reviewboard: Authentication error when connecting to svn without public access

2015-01-30 Thread reviewboard


Comment #6 on issue 3487 by chris.re...@york.ac.uk: Authentication error  
when connecting to svn without public access

https://code.google.com/p/reviewboard/issues/detail?id=3487

Confirmed broken in 2.0.5 as well... if you're using subvertpy.

At this point, seeing that another user had it working with 2.0.5, as did a  
colleague of mine, it became clear that this wasn't solely dependent upon  
the version of ReviewBoard.



I can confirm that this does appear to be fixed in 2.0.5 and 2.0.12... if  
you are using PySVN.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3744 in reviewboard: Unicode in the Ship It' comments isn't viewable in the review page

2015-01-30 Thread reviewboard


Comment #3 on issue 3744 by trowb...@gmail.com: Unicode in the Ship It'  
comments isn't viewable in the review page

https://code.google.com/p/reviewboard/issues/detail?id=3744

Would you mind checking the contents of the reviews table for your review  
and verify that it's stored correctly?


The e-mail might look correct because the e-mail code is operating on the  
same python object as when it was saved. It's only when the data is  
re-loaded from the database that you'd see the problem.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: RBTools post review requests between my working copy and an arbitrary SVN revision

2015-01-30 Thread David Trowbridge
For now, you'll have to make your diff for that by hand and upload it
either using rbt post --diff-filename or the web UI. If you wouldn't mind,
could you file an enhancement request asking for this functionality?

-David

On Tue Jan 27 2015 at 7:22:04 PM Yu-Kai Tseng tanists...@gmail.com wrote:

 Hi,

 The use case is

 Assume I modified code based on SVN revision 100, my code was reviewed and
 was committed to SVN (revision 200)
 After I committed the code, I found there was a better design of my code.
 So, I wrote the code again and wanted to create
 a review based on SVN 100 and my working copy because SVN revision 200 was
 nothing for me now.

 However, I can't find a way to create diffs for it.

 David Trowbridge於 2015年1月28日星期三 UTC+8上午7時41分08秒寫道:

 This is currently only possible if you create the diff yourself and post
 using --diff-file name. Could you explain your use case for digging between
 a non-HEAD revision and your working copy?

 -David

 On Mon, Jan 26, 2015 at 10:04 PM Yu-Kai Tseng tanis...@gmail.com wrote:

 Hi,

 May I create a diff between my working copy and a non-HEAD SVN revision
 using rbtools.
 I searched the document and even read the code but found no solution for
 it.

 I am going to introduce the rbtools to my colleagues and hope I can find
 an answer, even a no, you can't do it,
 Can anyone help me about it?

 Thank you.

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.

 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard...@googlegroups.com.


 For more options, visit https://groups.google.com/d/optout.

  --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


can not upload diff - list index out of range

2015-01-30 Thread Alexander Pivovarov
I'm trying to upload hive patch for review
I'm using hive-git

both web ui and rbt post return - list index out of range

I even tried to upload old hive patches which I successfully uploaded for 
review before - still same error - list index out of range




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Server certificate verification failed: issuer is not trusted

2015-01-30 Thread Sayak Banerjee
I am using reviewboard 2.0.11 over Bitnami stack on a Windows server. When 
I try to add an enterprise GitHub repo which uses SSL, I was getting this 
error:

Unable to connect to a repository at URL 'https://link to repo'
OPTIONS of 'https://link to repo': Server certificate verification 
failed: issuer is not trusted (https://hostname)

The issuer matches the repository hostname. After a bit of fiddling around, 
I found that apache2 was using openssl 1.0.1h and subversion was using 
1.0.1f. Since I was able to do svn list https://repo, I copied over the 
openssl and two DLLs as suggested by an user online to apache2 and I was 
then able to add the new repo. However, when I go to new review request, 
I keep getting this error.

Is there a way I can get around this?

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3729 in reviewboard: Cannot run rbt post in RBTools 0.7.0

2015-01-30 Thread reviewboard


Comment #14 on issue 3729 by michael@activeenergy.ie: Cannot run rbt  
post in RBTools 0.7.0

https://code.google.com/p/reviewboard/issues/detail?id=3729


rbt status -d

RBTools 0.7
Python 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit  
(Intel)]

Running on Windows-7-6.1.7601-SP1
Home = C:\Users\michael.killeen\AppData\Roaming
Current directory = E:\repo_xxx
Checking for a Subversion repository...
Running: svn info --non-interactive
Running: diff --version
repository info: Path: https://cylondc:8443/svn/Firmware, Base path:  
/stm32, Supports changesets: False

Making HTTP GET request to http://review.xxx.lan/api/
Cached response for HTTP GET http://review.xxx.lan/api/ expired and was  
not modified

Making HTTP GET request to http://review.xxx.lan/api/session/
Cached response for HTTP GET http://review.xxx.lan/api/session/ expired  
and was modified
WARNING: You are not authenticated with the Review Board server at  
http://review.xxx.lan, please login.

Username: michael.killeen
Traceback (most recent call last):
  File C:\Program Files  
(x86)\RBTools\bin\..\Python27\Scripts\rbt-script.py, line 8, in module

load_entry_point('RBTools==0.7', 'console_scripts', 'rbt')()
  File C:\Program Files  
(x86)\RBTools\Python27\lib\site-packages\rbtools-0.7-py2.7.egg\rbtools\commands\main.py,  
line

133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File C:\Program Files  
(x86)\RBTools\Python27\lib\site-packages\rbtools-0.7-py2.7.egg\rbtools\commands\__init__.py,  
l

ine 538, in run_from_argv
exit_code = self.main(*args) or 0
  File C:\Program Files  
(x86)\RBTools\Python27\lib\site-packages\rbtools-0.7-py2.7.egg\rbtools\commands\status.py,  
lin

e 41, in main
username = get_username(api_client, api_root, auth_required=True)
  File C:\Program Files  
(x86)\RBTools\Python27\lib\site-packages\rbtools-0.7-py2.7.egg\rbtools\utils\users.py,  
line 51

, in get_username
session = get_authenticated_session(api_client, api_root, auth_required)
  File C:\Program Files  
(x86)\RBTools\Python27\lib\site-packages\rbtools-0.7-py2.7.egg\rbtools\utils\users.py,  
line 30

, in get_authenticated_session
password = getpass.getpass('Password: ')
  File C:\Program Files (x86)\RBTools\Python27\lib\getpass.py, line 95,  
in win_getpass

msvcrt.putch(c)
TypeError: must be char, not unicode

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


RBtools 0.7 - issue posting a review

2015-01-30 Thread Daniel Laird
We have a shared Debian server and we have updated RBtools to 0.7.

When we try to post a review we get the following:

SERVER_NAME rbt post -d NUM
 RBTools 0.7
 Python 2.7.3 (default, Mar 13 2014, 11:03:55) 
[GCC 4.7.2]
 Running on Linux-3.2.0-4-amd64-x86_64-with-debian-7.8
 Home = /v/home/rad/USERNAME
 Current directory = /v/space/SERVER_NAME/USERNAME/wc/memory_corruption
 Checking for a Subversion repository...
 Running: svn info --non-interactive
 Running: diff --version
 repository info: Path: https://SVN_SERVER/svn-restricted/PROJNAME, Base 
path: /branches/users/bob/memory_corruption, Supports changesets: False
 Making HTTP GET request to http://REVIEWBOARD_SERVER/api/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/ cannot be cached
 Making HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/ cannot 
be cached
 Making HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/?max-results=25start=25
 HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/?max-results=25start=25 cannot 
be cached
 Making HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/1/info/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/1/info/ 
cannot be cached
 Making HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/2/info/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/2/info/ 
cannot be cached
 Making HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/3/info/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/3/info/ 
cannot be cached
 Making HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/4/info/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/4/info/ 
cannot be cached
 Making HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/5/info/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/5/info/ 
cannot be cached
 Making HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/6/info/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/6/info/ 
cannot be cached
 Making HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/7/info/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/7/info/ 
cannot be cached
 Making HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/8/info/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/8/info/ 
cannot be cached
 Making HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/9/info/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/9/info/ 
cannot be cached
 Making HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/10/info/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/10/info/ 
cannot be cached
 Making HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/11/info/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/11/info/ 
cannot be cached
 Making HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/12/info/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/12/info/ 
cannot be cached
 Making HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/13/info/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/13/info/ 
cannot be cached
 Making HTTP GET request to 
http://REVIEWBOARD_SERVER/api/repositories/14/info/
 HTTP GET request to http://REVIEWBOARD_SERVER/api/repositories/14/info/ 
cannot be cached
 repository info: Path: https://SVN_SERVER/svn-restricted/PROJNAME, Base 
path: /branches/users/bob/memory_corruption, Supports changesets: False
 Running: svn log -r REVNUM -l 1 --xml
Traceback (most recent call last):
  File /v/home/rad/USERNAME/.local/bin/rbt, line 9, in module
load_entry_point('RBTools==0.7', 'console_scripts', 'rbt')()
  File 
/v/home/rad/USERNAME/.local/lib/python2.7/site-packages/RBTools-0.7-py2.7.egg/rbtools/commands/main.py,
 
line 133, in main
command.run_from_argv([RB_MAIN, command_name] + args)
  File 
/v/home/rad/USERNAME/.local/lib/python2.7/site-packages/RBTools-0.7-py2.7.egg/rbtools/commands/__init__.py,
 
line 538, in run_from_argv
exit_code = self.main(*args) or 0
  File 
/v/home/rad/USERNAME/.local/lib/python2.7/site-packages/RBTools-0.7-py2.7.egg/rbtools/commands/post.py,
 
line 618, in main
self.revisions = get_revisions(self.tool, self.cmd_args)
  File 
/v/home/rad/USERNAME/.local/lib/python2.7/site-packages/RBTools-0.7-py2.7.egg/rbtools/utils/review_request.py,
 
line 73, in get_revisions
revisions = tool.parse_revision_spec(cmd_args)
  File 
/v/home/rad/USERNAME/.local/lib/python2.7/site-packages/RBTools-0.7-py2.7.egg/rbtools/clients/svn.py,
 
line 128, in parse_revision_spec
revision = self._convert_symbolic_revision(revision)
  File 
/v/home/rad/USERNAME/.local/lib/python2.7/site-packages/RBTools-0.7-py2.7.egg/rbtools/clients/svn.py,
 
line 173, in _convert_symbolic_revision
root = 

Re: Issue 3487 in reviewboard: Authentication error when connecting to svn without public access

2015-01-30 Thread reviewboard


Comment #4 on issue 3487 by chris.re...@york.ac.uk: Authentication error  
when connecting to svn without public access

https://code.google.com/p/reviewboard/issues/detail?id=3487

Confirmed broken in 2.0.7 and 2.0.12.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.