Re: Issue 2523 in reviewboard: Allow reviewers to attach files

2015-03-23 Thread reviewboard


Comment #4 on issue 2523 by christia...@googlemail.com: Allow reviewers to  
attach files

https://code.google.com/p/reviewboard/issues/detail?id=2523

I would think that your editor should be improved in such a way that  
reviewers and reviewees are enabled to just paste screenshots into the  
editor window alongside text they are writing. Maybe you even want a image  
editor that allows markups. I am sure there is some open source editor out  
there that provides this functionality.


Thanks. I really like reviewboard.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Question about inter-request dependencies

2015-03-23 Thread Stephen Gallagher
On Wed, 2015-03-18 at 14:33 -0700, Christian Hammond wrote:
 Hi Justin,
 
 We support this, but generally only when you're using something like 
 Git (or Git-SVN). Since Subversion has no native concept of 
 individual uncommitted changes, we're limited in what we can do 
 there.
 
 If you use Git-SVN, you can have a commit with one set of those 
 changes, and another commit with another set, and can then post each 
 commit separately.
 
 Technically, if you can generate two patches (one for the first set 
 and one for the second), then you can use our API to post the second 
 patch for review, specifying the first patch as the parent diff. We 
 don't have any support for doing this in rbt post though. (Though, 
 I'd accept a patch adding a --parent-diff-filename= to do that.)

I don't know if it's accidental, but 'rbt post commit_id' actually 
works for this case. I use it all the time.

If I have three commits in my branch from upstream/master, I can look 
at 'git log' and then do
rbt post commit_1
rbt post commit_2
rbt post commit_3

And they all seem to do the right thing. It's been quite handy :)

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.