Re: blocker: rbt diff missing change lines

2017-05-01 Thread Rick Liu
Thanks Christian! Rick 2017/5/1 下午8:25,"Christian Hammond" 寫道: Hi Rick, Thanks for reporting this, and for the detailed bug report. The problem is that the "---" line looks like a file marker, and it's getting lost during diff normalization (where we work around a

Re: RBTools Ticket #4546: rbt diff is different from svn diff

2017-05-01 Thread Christian Hammond
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4546/ -- New update by totoroliu For Beanbag, Inc. > RBTools > Ticket #4546 Reply:

Re: Default Reviewers not working

2017-05-01 Thread David Trowbridge
Hmm. That looks correct. One possible point of confusion is that the default reviewers are applied when the review request is created or has a new diff uploaded (and published). It won't affect existing review requests that haven't had any changes made to them. -David On Mon, May 1, 2017 at 7:08

Re: blocker: rbt diff missing change lines

2017-05-01 Thread Christian Hammond
Hi Rick, Thanks for reporting this, and for the detailed bug report. The problem is that the "---" line looks like a file marker, and it's getting lost during diff normalization (where we work around a bunch of issues in svn diffs). We'll need to keep some additional state to deal with this.

Re: Default Reviewers not working

2017-05-01 Thread Vikash Singh
Hi David, Here is the snapshot.Please have a look. And thanks again. Regards Vikash On Monday, May 1, 2017 at 11:31:16 PM

blocker: rbt diff missing change lines

2017-05-01 Thread Rick Liu
Hi, I just reported a bug under ReviewBoard bug system: https://hellosplat.com/s/beanbag/tickets/4546/ But I'd like to know if there's a quick work-around for the issue. I have a test file example like below under SVN: ``` -- test line1 -- this line (test1) -- test lin2 -- test line (test2)

Re: RBTools Ticket #4546: rbt diff is different from svn diff

2017-05-01 Thread Rick Liu
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4546/ -- New update by totoroliu For Beanbag, Inc. > RBTools > Ticket #4546 Reply:

Re: update_index always indexes the users class

2017-05-01 Thread Christian Hammond
Actually, rather than the Elasticsearch patch, I'd like you to try a couple patches to the search indexing code. Turns out it was more inefficient than I had thought. Alternatively, I could send you a build. Just need to know the Python version and whether you used easy_install or pip to install

Re: update_index always indexes the users class

2017-05-01 Thread Daniel Kuecker
Thanks for the quick reply Christian! I would like the info on configuring Elasticsearch if you don't mind. --DK On Monday, May 1, 2017 at 3:12:06 PM UTC-5, Christian Hammond wrote: > > Hi Daniel, > > I believe this happens because unlike review requests, we have no way of > determining with

Re: update_index always indexes the users class

2017-05-01 Thread Christian Hammond
Hi Daniel, I believe this happens because unlike review requests, we have no way of determining with the search indexing stuff we use if a user's information is "new" to the index. Basically, we have no "last updated" for the users. I do see an area in the search index for users that isn't as

update_index always indexes the users class

2017-05-01 Thread Daniel Kuecker
I have a fresh 2.5.9 install with a db taken from a backup of another 2.5.9 install (basically a backup of my production instance). On the production instance, I am experiencing 100% cpu usage every time the update_index cron job runs causing my users to complain about responsiveness of the

Re: Default Reviewers not working

2017-05-01 Thread David Trowbridge
Perhaps you could share a screenshot of the default reviewer configuration that's not working? Writing your own script to post changes is going to be a ton of work. On Mon, May 1, 2017 at 10:48 AM Vikash Singh wrote: > Hi David, > > Thanks, I tried that too but no

Re: Default Reviewers not working

2017-05-01 Thread Vikash Singh
Hi David, Thanks, I tried that too but no success at all. Finally i am trying to create script using reviewboard webapi. So that it will do that work. Every thing is working fine except one i.e i am not able to show diff or the changes happen. I have gone through the documentation of