date:20170501

Re: blocker: rbt diff missing change lines

2017-05-01 Thread Rick Liu

Thanks  Christian!

Rick


2017/5/1 下午8:25，"Christian Hammond" 寫道：

Hi Rick,

Thanks for reporting this, and for the detailed bug report.

The problem is that the "---" line looks like a file marker, and it's
getting lost during diff normalization (where we work around a bunch of
issues in svn diffs). We'll need to keep some additional state to deal with
this.

Let me follow up on the bug report with some extra details.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Mon, May 1, 2017 at 5:45 PM, Rick Liu  wrote:

> Hi,
>
> I just reported a bug under ReviewBoard bug system:
> https://hellosplat.com/s/beanbag/tickets/4546/
>
> But I'd like to know if there's a quick work-around for the issue.
>
> I have a test file example like below under SVN:
>
>
> ```
>
> -- test line1
> -- this line (test1)
> -- test lin2
> -- test line (test2)
> ```
>
> And then I remove the LINE#2:
> ```
> -- this line (test1)
> ```
>
> svn diff would show:
> ```
>
> $ svn diff
> Index: test
> ===
> --- test(revision 16006)
> +++ test(working copy)
> @@ -1,4 +1,3 @@
>  -- test line1
> --- this line (test1)
>  -- test lin2
>  -- test line (test2)
>
> ```
>
> But rbt diff is missing the line of change:
> ```
>
> $ rbt diff
> Index: /TestProject/trunk/Test/folder/test
> ===
> --- /TestProject/trunk/Test/folder/test (revision 16006)
> +++ /TestProject/trunk/Test/folder/test (working copy)
> @@ -1,4 +1,3 @@
>  -- test line1
>  -- test lin2
>  -- test line (test2)
>
> ```
>
>
> I suspect it's rbtools parser is mistakenly treat '---' as part of DIFF
> source line.
> I'm currently using rbtools-0.7.9,
> and wondering if there can be a quick patch/fix for this?
>
>
> Thanks,
> Rick
>
>
>
>
>
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
>
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/
powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to a topic in the
Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/
topic/reviewboard/POjfbwnXg-4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools Ticket #4546: rbt diff is different from svn diff

2017-05-01 Thread Christian Hammond

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4546/
--

New update by totoroliu
For Beanbag, Inc. > RBTools > Ticket #4546


Reply:

So the problem has to do with the `handle_renames` function in 
`rbtools/clients/svn.py`. We look for `---` and `+++` lines, but we're not 
keeping state to determine if we're in a diff header or in code.

The fix shouldn't be too bad. Instead of unconditionally skipping `---` and 
`+++` lines, we need to look for `Index: ` lines and then parse out until we're 
into the code, then normalize the lines until we're back in `Index: `.


Status:
- New
+ Confirmed


Milestones:
+ Release-0.8.x


Tags:
- Priority:Medium
+ Priority:High
+ SCM:Subversion

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Default Reviewers not working

2017-05-01 Thread David Trowbridge

Hmm. That looks correct. One possible point of confusion is that the
default reviewers are applied when the review request is created or has a
new diff uploaded (and published). It won't affect existing review requests
that haven't had any changes made to them.

-David
On Mon, May 1, 2017 at 7:08 PM Vikash Singh  wrote:

> Hi David,
>
> Here is the snapshot.Please have a look. And thanks again.
>
>
> 
> Regards
> Vikash
>
>
> On Monday, May 1, 2017 at 11:31:16 PM UTC+5:30, David Trowbridge wrote:
>
>> Perhaps you could share a screenshot of the default reviewer
>> configuration that's not working? Writing your own script to post changes
>> is going to be a ton of work.
>>
> On Mon, May 1, 2017 at 10:48 AM Vikash Singh  wrote:
>>
>>> Hi David,
>>>
>>> Thanks, I tried that too but no success at all. Finally i am trying to
>>> create script using reviewboard webapi. So that it will do that work. Every
>>> thing is working fine except one i.e i am not able to show diff or the
>>> changes happen. I have gone through the documentation of  "
>>> https://www.reviewboard.org/docs/rbtools/dev/api/resource-specific/#diff-list-resource-specific-functionality;
>>>   here i am not able understand "DiffListResource.upload_diff(*diff*,
>>> *parent_diff=None*, *base_dir=None*)". It would be great if you could
>>> tell me how it works with an example.
>>>
>>> Thanks & Regards
>>> Vikash
>>>
>>> On Sunday, April 30, 2017 at 9:53:56 PM UTC+5:30, David Trowbridge wrote:
>>>
 Are you looking to apply the default reviewer for all files in the
 given repository? If so, the regex ".*" (without the quotes) will match
 against all file names.

 -David

>>> On Sun, Apr 30, 2017 at 7:52 AM Vikash Singh 
 wrote:

>>> I really need help here, Review board does not have good documentation
> :(
>
>
> On Friday, April 28, 2017 at 1:24:14 PM UTC+5:30, Vikash Singh wrote:
>>
>> Hi Nicolas,
>>
>> Is there specific regex i need to apply for git as i am using
>> bitbucket and i am facing same issue with default reviewer.
>>
>> On Tuesday, May 27, 2014 at 2:52:04 PM UTC+5:30, Nicolas Comet wrote:
>>>
>>> I hope it will help people having the same problem :
>>>
>>> The only way I got default reviewers (groups or people) working was
>>> by removing the first / character at the beginning of the regexp field.
>>>
>>> If your repository is svn://urltorepo/Repository/ModuleOrProject
>>>
>>> You want to type in the field : *trunk/.**, *branch/.** or *tag/.**
>>>
>>> *Do not add a leading / !*
>>>
>>>
>>>
>>> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google
> Groups "reviewboard" group.
>
 To unsubscribe from this group and stop receiving emails from it, send
> an email to reviewboard...@googlegroups.com.


> For more options, visit https://groups.google.com/d/optout.
>
 --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to

Re: blocker: rbt diff missing change lines

2017-05-01 Thread Christian Hammond

Hi Rick,

Thanks for reporting this, and for the detailed bug report.

The problem is that the "---" line looks like a file marker, and it's
getting lost during diff normalization (where we work around a bunch of
issues in svn diffs). We'll need to keep some additional state to deal with
this.

Let me follow up on the bug report with some extra details.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Mon, May 1, 2017 at 5:45 PM, Rick Liu  wrote:

> Hi,
>
> I just reported a bug under ReviewBoard bug system:
> https://hellosplat.com/s/beanbag/tickets/4546/
>
> But I'd like to know if there's a quick work-around for the issue.
>
> I have a test file example like below under SVN:
>
>
> ```
>
> -- test line1
> -- this line (test1)
> -- test lin2
> -- test line (test2)
> ```
>
> And then I remove the LINE#2:
> ```
> -- this line (test1)
> ```
>
> svn diff would show:
> ```
>
> $ svn diff
> Index: test
> ===
> --- test(revision 16006)
> +++ test(working copy)
> @@ -1,4 +1,3 @@
>  -- test line1
> --- this line (test1)
>  -- test lin2
>  -- test line (test2)
>
> ```
>
> But rbt diff is missing the line of change:
> ```
>
> $ rbt diff
> Index: /TestProject/trunk/Test/folder/test
> ===
> --- /TestProject/trunk/Test/folder/test (revision 16006)
> +++ /TestProject/trunk/Test/folder/test (working copy)
> @@ -1,4 +1,3 @@
>  -- test line1
>  -- test lin2
>  -- test line (test2)
>
> ```
>
>
> I suspect it's rbtools parser is mistakenly treat '---' as part of DIFF
> source line.
> I'm currently using rbtools-0.7.9,
> and wondering if there can be a quick patch/fix for this?
>
>
> Thanks,
> Rick
>
>
>
>
>
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Default Reviewers not working

2017-05-01 Thread Vikash Singh

Hi David,

Here is the snapshot.Please have a look. And thanks again.


Regards
Vikash

On Monday, May 1, 2017 at 11:31:16 PM UTC+5:30, David Trowbridge wrote:
>
> Perhaps you could share a screenshot of the default reviewer configuration 
> that's not working? Writing your own script to post changes is going to be 
> a ton of work.
> On Mon, May 1, 2017 at 10:48 AM Vikash Singh  > wrote:
>
>> Hi David,
>>
>> Thanks, I tried that too but no success at all. Finally i am trying to 
>> create script using reviewboard webapi. So that it will do that work. Every 
>> thing is working fine except one i.e i am not able to show diff or the 
>> changes happen. I have gone through the documentation of  "
>> https://www.reviewboard.org/docs/rbtools/dev/api/resource-specific/#diff-list-resource-specific-functionality;
>>  
>>   here i am not able understand "DiffListResource.upload_diff(*diff*, 
>> *parent_diff=None*, *base_dir=None*)". It would be great if you could 
>> tell me how it works with an example.
>>
>> Thanks & Regards
>> Vikash
>>
>> On Sunday, April 30, 2017 at 9:53:56 PM UTC+5:30, David Trowbridge wrote:
>>
>>> Are you looking to apply the default reviewer for all files in the given 
>>> repository? If so, the regex ".*" (without the quotes) will match against 
>>> all file names.
>>>
>>> -David
>>>
>> On Sun, Apr 30, 2017 at 7:52 AM Vikash Singh  wrote:
>>>
>> I really need help here, Review board does not have good documentation :( 


 On Friday, April 28, 2017 at 1:24:14 PM UTC+5:30, Vikash Singh wrote:
>
> Hi Nicolas,
>
> Is there specific regex i need to apply for git as i am using 
> bitbucket and i am facing same issue with default reviewer.
>
> On Tuesday, May 27, 2014 at 2:52:04 PM UTC+5:30, Nicolas Comet wrote:
>>
>> I hope it will help people having the same problem :
>>
>> The only way I got default reviewers (groups or people) working was 
>> by removing the first / character at the beginning of the regexp field.
>>
>> If your repository is svn://urltorepo/Repository/ModuleOrProject
>>
>> You want to type in the field : *trunk/.**, *branch/.** or *tag/.**
>>
>> *Do not add a leading / !*
>>
>>
>>
>> -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups "reviewboard" group.

>>> To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.
>>>
>>>
 For more options, visit https://groups.google.com/d/optout.

>>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

blocker: rbt diff missing change lines

2017-05-01 Thread Rick Liu

Hi,

I just reported a bug under ReviewBoard bug system:
https://hellosplat.com/s/beanbag/tickets/4546/

But I'd like to know if there's a quick work-around for the issue.

I have a test file example like below under SVN:


```

-- test line1
-- this line (test1)
-- test lin2
-- test line (test2)
```

And then I remove the LINE#2:
```
-- this line (test1)
```

svn diff would show:
```

$ svn diff
Index: test
===
--- test(revision 16006)
+++ test(working copy)
@@ -1,4 +1,3 @@
 -- test line1
--- this line (test1)
 -- test lin2
 -- test line (test2)

```

But rbt diff is missing the line of change:
```

$ rbt diff
Index: /TestProject/trunk/Test/folder/test
===
--- /TestProject/trunk/Test/folder/test (revision 16006)
+++ /TestProject/trunk/Test/folder/test (working copy)
@@ -1,4 +1,3 @@
 -- test line1
 -- test lin2
 -- test line (test2)

```


I suspect it's rbtools parser is mistakenly treat '---' as part of DIFF 
source line.
I'm currently using rbtools-0.7.9,
and wondering if there can be a quick patch/fix for this?


Thanks,
Rick







-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools Ticket #4546: rbt diff is different from svn diff

2017-05-01 Thread Rick Liu

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4546/
--

New update by totoroliu
For Beanbag, Inc. > RBTools > Ticket #4546


Reply:

Upload the test files


Files:
- test
  
- svn.diff
  
- rbt.diff
  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: update_index always indexes the users class

2017-05-01 Thread Christian Hammond

Actually, rather than the Elasticsearch patch, I'd like you to try a couple
patches to the search indexing code. Turns out it was more inefficient than
I had thought. Alternatively, I could send you a build. Just need to know
the Python version and whether you used easy_install or pip to install
Review Board (or some other method).

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Mon, May 1, 2017 at 1:28 PM, Christian Hammond 
wrote:

> Sure thing. I realized though that out of the box, this won't work without
> a patch to Review Board (the proper Elasticsearch support has only been
> thoroughly tested in 3.0). How comfortable do you feel applying patches?
>
> Christian
>
>
> --
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Mon, May 1, 2017 at 1:17 PM, Daniel Kuecker  wrote:
>
>> Thanks for the quick reply Christian!
>>
>> I would like the info on configuring Elasticsearch if you don't mind.
>>
>> --DK
>>
>> On Monday, May 1, 2017 at 3:12:06 PM UTC-5, Christian Hammond wrote:
>>>
>>> Hi Daniel,
>>>
>>> I believe this happens because unlike review requests, we have no way of
>>> determining with the search indexing stuff we use if a user's information
>>> is "new" to the index. Basically, we have no "last updated" for the users.
>>>
>>> I do see an area in the search index for users that isn't as optimal, so
>>> we can probably shave down the number of queries a fair amount, which will
>>> help.
>>>
>>> I assume you're using the default search backend of Whoosh? If so, at
>>> your scale, it might be time to install Elasticsearch. We can give you some
>>> info on how to configure that in settings_local.py (the upcoming Review
>>> Board 3.0 makes this very easy -- just select it as your search backend and
>>> fill in fields). Indexing with Elasticsearch is more efficient for large
>>> amounts of data.
>>>
>>> Christian
>>>
>>> --
>>> Christian Hammond
>>> President/CEO of Beanbag 
>>> Makers of Review Board 
>>>
>>> On Mon, May 1, 2017 at 12:59 PM, Daniel Kuecker 
>>> wrote:
>>>
 I have a fresh 2.5.9 install with a db taken from a backup of another
 2.5.9 install (basically a backup of my production instance).

 On the production instance, I am experiencing 100% cpu usage every time
 the update_index cron job runs causing my users to complain about
 responsiveness of the site.

 On my production system, the cron job shows it is indexing all the
 records in the user table while only the new records in the review requests
 table.

 For debugging, I restored the production db backup to my dev machine
 and set up a 2.5.9 instance pointing to it.  When update_index runs on the
 dev box (given the "-v 3" arg), I get the following warning:

>
> WARNING:py.warnings:/usr/lib/python2.7/site-packages/haystack/indexes.py:167:
> UserWarning: No updated date field found for 'User' - not restricting by
> age.
>   warnings.warn(update_field_msg)
> Indexing 1971 users
>   indexed 1 - 1000 of 1971 (by 16819).
>   indexed 1001 - 1971 of 1971 (by 16819).


 It then proceeds to index the entire user table and only the changed
 review requests just as my production instance does.

 I have run the rebuild_index command on both systems.

 Am I missing something?  I have the cron job set to run ever 1/2 hour
 and am about to have to turn search indexing off to ensure the site is
 responsive.

 --DK



 --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups "reviewboard" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.

>>>
>>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack:

Re: update_index always indexes the users class

2017-05-01 Thread Daniel Kuecker

Thanks for the quick reply Christian!

I would like the info on configuring Elasticsearch if you don't mind.  

--DK

On Monday, May 1, 2017 at 3:12:06 PM UTC-5, Christian Hammond wrote:
>
> Hi Daniel,
>
> I believe this happens because unlike review requests, we have no way of 
> determining with the search indexing stuff we use if a user's information 
> is "new" to the index. Basically, we have no "last updated" for the users.
>
> I do see an area in the search index for users that isn't as optimal, so 
> we can probably shave down the number of queries a fair amount, which will 
> help.
>
> I assume you're using the default search backend of Whoosh? If so, at your 
> scale, it might be time to install Elasticsearch. We can give you some info 
> on how to configure that in settings_local.py (the upcoming Review Board 
> 3.0 makes this very easy -- just select it as your search backend and fill 
> in fields). Indexing with Elasticsearch is more efficient for large amounts 
> of data.
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag 
> Makers of Review Board 
>
> On Mon, May 1, 2017 at 12:59 PM, Daniel Kuecker  > wrote:
>
>> I have a fresh 2.5.9 install with a db taken from a backup of another 
>> 2.5.9 install (basically a backup of my production instance).
>>
>> On the production instance, I am experiencing 100% cpu usage every time 
>> the update_index cron job runs causing my users to complain about 
>> responsiveness of the site.
>>
>> On my production system, the cron job shows it is indexing all the 
>> records in the user table while only the new records in the review requests 
>> table.
>>
>> For debugging, I restored the production db backup to my dev machine and 
>> set up a 2.5.9 instance pointing to it.  When update_index runs on the dev 
>> box (given the "-v 3" arg), I get the following warning: 
>>
>>>
>>> WARNING:py.warnings:/usr/lib/python2.7/site-packages/haystack/indexes.py:167:
>>>  
>>> UserWarning: No updated date field found for 'User' - not restricting by 
>>> age.
>>>   warnings.warn(update_field_msg)
>>> Indexing 1971 users
>>>   indexed 1 - 1000 of 1971 (by 16819).
>>>   indexed 1001 - 1971 of 1971 (by 16819).
>>
>>
>> It then proceeds to index the entire user table and only the changed 
>> review requests just as my production instance does.
>>
>> I have run the rebuild_index command on both systems.
>>
>> Am I missing something?  I have the cron job set to run ever 1/2 hour and 
>> am about to have to turn search indexing off to ensure the site is 
>> responsive.
>>
>> --DK
>>
>>
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: update_index always indexes the users class

2017-05-01 Thread Christian Hammond

Hi Daniel,

I believe this happens because unlike review requests, we have no way of
determining with the search indexing stuff we use if a user's information
is "new" to the index. Basically, we have no "last updated" for the users.

I do see an area in the search index for users that isn't as optimal, so we
can probably shave down the number of queries a fair amount, which will
help.

I assume you're using the default search backend of Whoosh? If so, at your
scale, it might be time to install Elasticsearch. We can give you some info
on how to configure that in settings_local.py (the upcoming Review Board
3.0 makes this very easy -- just select it as your search backend and fill
in fields). Indexing with Elasticsearch is more efficient for large amounts
of data.

Christian

-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

On Mon, May 1, 2017 at 12:59 PM, Daniel Kuecker  wrote:

> I have a fresh 2.5.9 install with a db taken from a backup of another
> 2.5.9 install (basically a backup of my production instance).
>
> On the production instance, I am experiencing 100% cpu usage every time
> the update_index cron job runs causing my users to complain about
> responsiveness of the site.
>
> On my production system, the cron job shows it is indexing all the records
> in the user table while only the new records in the review requests table.
>
> For debugging, I restored the production db backup to my dev machine and
> set up a 2.5.9 instance pointing to it.  When update_index runs on the dev
> box (given the "-v 3" arg), I get the following warning:
>
>>
>> WARNING:py.warnings:/usr/lib/python2.7/site-packages/haystack/indexes.py:167:
>> UserWarning: No updated date field found for 'User' - not restricting by
>> age.
>>   warnings.warn(update_field_msg)
>> Indexing 1971 users
>>   indexed 1 - 1000 of 1971 (by 16819).
>>   indexed 1001 - 1971 of 1971 (by 16819).
>
>
> It then proceeds to index the entire user table and only the changed
> review requests just as my production instance does.
>
> I have run the rebuild_index command on both systems.
>
> Am I missing something?  I have the cron job set to run ever 1/2 hour and
> am about to have to turn search indexing off to ensure the site is
> responsive.
>
> --DK
>
>
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

update_index always indexes the users class

2017-05-01 Thread Daniel Kuecker

I have a fresh 2.5.9 install with a db taken from a backup of another 2.5.9 
install (basically a backup of my production instance).

On the production instance, I am experiencing 100% cpu usage every time the 
update_index cron job runs causing my users to complain about 
responsiveness of the site.

On my production system, the cron job shows it is indexing all the records 
in the user table while only the new records in the review requests table.

For debugging, I restored the production db backup to my dev machine and 
set up a 2.5.9 instance pointing to it.  When update_index runs on the dev 
box (given the "-v 3" arg), I get the following warning: 

>
> WARNING:py.warnings:/usr/lib/python2.7/site-packages/haystack/indexes.py:167: 
> UserWarning: No updated date field found for 'User' - not restricting by 
> age.
>   warnings.warn(update_field_msg)
> Indexing 1971 users
>   indexed 1 - 1000 of 1971 (by 16819).
>   indexed 1001 - 1971 of 1971 (by 16819).


It then proceeds to index the entire user table and only the changed review 
requests just as my production instance does.

I have run the rebuild_index command on both systems.

Am I missing something?  I have the cron job set to run ever 1/2 hour and 
am about to have to turn search indexing off to ensure the site is 
responsive.

--DK



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Default Reviewers not working

2017-05-01 Thread David Trowbridge

Perhaps you could share a screenshot of the default reviewer configuration
that's not working? Writing your own script to post changes is going to be
a ton of work.
On Mon, May 1, 2017 at 10:48 AM Vikash Singh 
wrote:

> Hi David,
>
> Thanks, I tried that too but no success at all. Finally i am trying to
> create script using reviewboard webapi. So that it will do that work. Every
> thing is working fine except one i.e i am not able to show diff or the
> changes happen. I have gone through the documentation of  "
> https://www.reviewboard.org/docs/rbtools/dev/api/resource-specific/#diff-list-resource-specific-functionality;
>   here i am not able understand "DiffListResource.upload_diff(*diff*,
> *parent_diff=None*, *base_dir=None*)". It would be great if you could
> tell me how it works with an example.
>
> Thanks & Regards
> Vikash
>
> On Sunday, April 30, 2017 at 9:53:56 PM UTC+5:30, David Trowbridge wrote:
>
>> Are you looking to apply the default reviewer for all files in the given
>> repository? If so, the regex ".*" (without the quotes) will match against
>> all file names.
>>
>> -David
>>
> On Sun, Apr 30, 2017 at 7:52 AM Vikash Singh  wrote:
>>
> I really need help here, Review board does not have good documentation :(
>>>
>>>
>>> On Friday, April 28, 2017 at 1:24:14 PM UTC+5:30, Vikash Singh wrote:

 Hi Nicolas,

 Is there specific regex i need to apply for git as i am using bitbucket
 and i am facing same issue with default reviewer.

 On Tuesday, May 27, 2014 at 2:52:04 PM UTC+5:30, Nicolas Comet wrote:
>
> I hope it will help people having the same problem :
>
> The only way I got default reviewers (groups or people) working was by
> removing the first / character at the beginning of the regexp field.
>
> If your repository is svn://urltorepo/Repository/ModuleOrProject
>
> You want to type in the field : *trunk/.**, *branch/.** or *tag/.**
>
> *Do not add a leading / !*
>
>
>
> --
>>> Supercharge your Review Board with Power Pack:
>>> https://www.reviewboard.org/powerpack/
>>> Want us to host Review Board for you? Check out RBCommons:
>>> https://rbcommons.com/
>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "reviewboard" group.
>>>
>> To unsubscribe from this group and stop receiving emails from it, send an
>>> email to reviewboard...@googlegroups.com.
>>
>>
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Default Reviewers not working

2017-05-01 Thread Vikash Singh

Hi David,

Thanks, I tried that too but no success at all. Finally i am trying to 
create script using reviewboard webapi. So that it will do that work. Every 
thing is working fine except one i.e i am not able to show diff or the 
changes happen. I have gone through the documentation of 
 
"https://www.reviewboard.org/docs/rbtools/dev/api/resource-specific/#diff-list-resource-specific-functionality;
 
  here i am not able understand "DiffListResource.upload_diff(*diff*, 
*parent_diff=None*, *base_dir=None*)". It would be great if you could tell 
me how it works with an example.

Thanks & Regards
Vikash

On Sunday, April 30, 2017 at 9:53:56 PM UTC+5:30, David Trowbridge wrote:
>
> Are you looking to apply the default reviewer for all files in the given 
> repository? If so, the regex ".*" (without the quotes) will match against 
> all file names.
>
> -David
> On Sun, Apr 30, 2017 at 7:52 AM Vikash Singh  > wrote:
>
>> I really need help here, Review board does not have good documentation :( 
>>
>>
>> On Friday, April 28, 2017 at 1:24:14 PM UTC+5:30, Vikash Singh wrote:
>>>
>>> Hi Nicolas,
>>>
>>> Is there specific regex i need to apply for git as i am using bitbucket 
>>> and i am facing same issue with default reviewer.
>>>
>>> On Tuesday, May 27, 2014 at 2:52:04 PM UTC+5:30, Nicolas Comet wrote:

 I hope it will help people having the same problem :

 The only way I got default reviewers (groups or people) working was by 
 removing the first / character at the beginning of the regexp field.

 If your repository is svn://urltorepo/Repository/ModuleOrProject

 You want to type in the field : *trunk/.**, *branch/.** or *tag/.**

 *Do not add a leading / !*



 -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: blocker: rbt diff missing change lines

Re: RBTools Ticket #4546: rbt diff is different from svn diff

Re: Default Reviewers not working

Re: blocker: rbt diff missing change lines

Re: Default Reviewers not working

blocker: rbt diff missing change lines

Re: RBTools Ticket #4546: rbt diff is different from svn diff

Re: update_index always indexes the users class

Re: update_index always indexes the users class

Re: update_index always indexes the users class

update_index always indexes the users class

Re: Default Reviewers not working

Re: Default Reviewers not working

13 matches

Site Navigation

Mail list logo

Footer information