RE: Upgrading pygments
Thanks, everyone. Unfortunately, the lexer I was looking for wasn't actually included in their 1.2.2 release, so I'll have to wait for 1.3 to come out. From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: Wednesday, January 27, 2010 4:38 PM To: reviewboard@googlegroups.com Subject: Re: Upgrading pygments Hi Mark, It should be possible to simply upgrade Pygments. If it fails, it's easy to revert back to a stable version. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jan 27, 2010 at 5:52 AM, Bickford, Mark mark_bickf...@wrightexpress.com wrote: Hi, We are currently running RB 1.0.5.1. Is it possible to just upgrade Pygments within it, to their 1.2.2 release, or will that break RB? They've added some new language highlighting within it that we'd like to have access to. Thanks, Mark -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com mailto:reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Upgrading pygments
Hi, We are currently running RB 1.0.5.1. Is it possible to just upgrade Pygments within it, to their 1.2.2 release, or will that break RB? They've added some new language highlighting within it that we'd like to have access to. Thanks, Mark -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RE: Love Dont Cost a Thing clip
If so, can the same moderation rule be applied to reviewboard-dev? All I see there is spam. From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Jeff Andros Sent: Monday, January 18, 2010 12:06 PM To: reviewboard@googlegroups.com Subject: Re: Love Dont Cost a Thing clip I thought these were moderated now? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
RE: Submitting patches, subversion post-review support for already committed revisions
I've run into this recently, not with post-review so much as with the IDEA plugin (http://code.google.com/p/idea-reviewboard/). We're using RB 1.0.5.1 and a 1.6 revision of Subversion. In our case, we substantially reorganized our Subversion tree, and then I branched the code twice more. So the svn log of a particular file looks like this: (Assume HEAD = r155) 151 Created feature branch from project branch 150 Created project branch from trunk 149 Moved folder as part of reorg (this was large, going from a /top-level/project/trunk|tags|branches structure to /new-top-level/trunk|tags|branches/projects ) 140 File edited to fix defect. In this scenario, the last time the file was actually changed was r140; everything since then is a copy from a prior location. If we run post-review, the diff is created and lists r155, or at least the HEAD rev at the last time the file was updated in the working copy, as the current revision, and RB accepts it with no problem. If we run the IDEA plugin (which we changed to give us a copy of the diff), it lists Revision 140, the last revision when the file was edited. The IDEA plugin then gives us a popup with the error message, Error from server: The file was not found in the repository., which I assume comes back from ReviewBoard. We tried to manually attach the diff generated by the plugin to a review request using the RB web interface, and RB apparently rejected it; it said Uploading file, and then came back to the upload screen without either adding the diff to the request, or giving us an error message. If we changed the revision number in the exact same diff to 155, the upload worked properly. So, we have a couple questions to ask: 1. Why, apparently, is ReviewBoard not resolving the earlier revision of the file properly? 2. Why is the IDEA plugin giving the older revision number, and do we have a way to make it give the current one? I realize this question is beyond the official scope of this group, and I'm not even sure if the plugin's author is subscribed here. Thanks very much for any help anyone can give me. - Mark From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: Wednesday, December 09, 2009 7:32 PM To: reviewboard@googlegroups.com Subject: Re: Submitting patches, subversion post-review support for already committed revisions It seems that this broke at some point. I've been meaning to look into it but haven't really had the time lately. I believe it's due to us being a little more smart now with SVN diffs and going through trying to grab info on the affected files. We need to handle the moves/renames properly. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Dec 9, 2009 at 2:01 PM, Lyndon Washington hoshp...@crazy-code.com wrote: Hi, Was there a resolution to the svn problem that was outlined, because I get a similar problem after I performed a commit that included some moved and deleted source files. When i try and create a review request with post-review I get the following error: Failed to execute command: ['svn', 'info', 'runtime/tests/src/com/notification/impl/TestNotificationMessageFactory. java'] ['runtime/tests/src/com/notification/impl/TestNotificationMessageFactory .java: (Not a versioned resource)\n', '\n', 'svn: A problem occurred; see other errors for details\n'] Cheers, -Lyndon- Lyndon Washington On Thu, Dec 3, 2009 at 11:42 AM, Jason Felice jason.m.fel...@gmail.com wrote: On Thu, Dec 3, 2009 at 1:54 AM, Christian Hammond chip...@chipx86.com wrote: Hi Jason, A standard diff -u doesn't contain the revision information needed, and a git diff by default uses short SHA1s, which we can't use to fetch the files. You will need to use either post-review (recommended) or git diff --full-index. OK, that worked. post-review with Subversion should support renames and posting diffs of existing commits. What versions of Review Board and of post-review are you using? I tried what I got from easy_install -U RBTools, when that wouldn't work, I tried git HEAD. My ReviewBoard install reports 1.0.5.1... weird because I thought I installed the alpha because I need SVN https support, and I have successfully used SVN https repositories. Can you show me exactly what happens with post-review in the two cases (renames and existing commits)? You can run post-review with --debug for more information, which would help to diagnose an issue. C:\workspace\xpay-corepost-review --debug --revision-range 4665:4666 svn info repository info: Path: https://dtvsource/svn/xpay, Base path: /trunk/xpay-core-1.2, Supports changesets: False svn propget reviewboard:url C:\workspace\xpay-core svn diff --diff-cmd=diff -r 4665:4666 svn info src/dev/testapp/emulator/nio/TaskResolver.java
RE: Eclipse plugin: basic usage?
I do have an additional question from one of our developers regarding the use of this plugin, that I would appreciate some feedback on when Markus is able to provide it. Also, my original question regarding creating a review request and uploading the diff from within Eclipse remains open. Quoting our developer: I got this thing installed, configured and can see the review requests happily in my task list in Eclipse. I can even open the review requests in Eclipse. But one thing is missing: I should be able to Activate the review request so that it downloads the diff, applies it and I can view it in the Editor. But this is not working at all. -- I should be able to right-click and Activate any of the reviews, which should (by my understanding...) bring down the diff, apply it and load the affected files in the editor. From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: Monday, November 16, 2009 3:15 PM To: reviewboard@googlegroups.com Subject: Re: Eclipse plugin: basic usage? You can find it here: http://github.com/mknittig/ereviewboard It's a Summer of Code project by Markus Knittig, who can explain more about how to use it. There's no VS plugin in the works. We only have so many hours in a day. If someone wants to work on one, do let us know. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Nov 16, 2009 at 12:01 PM, Pv p...@swooby.com wrote: Where is this Eclipse and/or IDEA plugin? I searched the reviewboard and rbtools git repo and didn't see anything. I do see the review though: http://reviews.reviewboard.org/r/967/ But browsing git I can't find that path. Is there a VS plugin took? [or in the works?] Pv On Nov 16, 8:23 am, Bickford, Mark mark_bickf...@wrightexpress.com wrote: Hi, We're just starting to implement ReviewBoard, and I have some questions about the Eclipse plugin. I'll be upfront in saying that I have very little experience with Eclipse (preferring to use IDEA), but some of our developers use Eclipse and I need to be able to support them. I am able to bring up the Reviewboard view in Mylyn, see outstanding reviews and create a new task; that, in turn, creates an empty review request in RB. So far, so good. Now, my questions are this: 1. When I create a new task, I am offered a dialog in which I can choose a Subversion repository and enter a revision number. Is including a revision number the way to upload a diff through the plugin, and if so, is it the only way? 2. Does the plugin have the ability to create a diff from the changed files in the currently-open project, and automatically post it when I create the task (i.e., a pre-commit workflow)? I've had good luck so far with the IDEA plugin someone created, which exposes most of the post-commit.exe functionality and also ties in well with the IDEA VCS API. I am just wondering if the Eclipse plugin has the same abilities. Thanks, Mark H. Bickford To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com mailto:reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Eclipse plugin: basic usage?
Hi, We're just starting to implement ReviewBoard, and I have some questions about the Eclipse plugin. I'll be upfront in saying that I have very little experience with Eclipse (preferring to use IDEA), but some of our developers use Eclipse and I need to be able to support them. I am able to bring up the Reviewboard view in Mylyn, see outstanding reviews and create a new task; that, in turn, creates an empty review request in RB. So far, so good. Now, my questions are this: 1. When I create a new task, I am offered a dialog in which I can choose a Subversion repository and enter a revision number. Is including a revision number the way to upload a diff through the plugin, and if so, is it the only way? 2. Does the plugin have the ability to create a diff from the changed files in the currently-open project, and automatically post it when I create the task (i.e., a pre-commit workflow)? I've had good luck so far with the IDEA plugin someone created, which exposes most of the post-commit.exe functionality and also ties in well with the IDEA VCS API. I am just wondering if the Eclipse plugin has the same abilities. Thanks, Mark H. Bickford --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
RE: Eclipse plugin: basic usage?
The IDEA plugin is in source form at http://idea-reviewboard.googlecode.com ; I checked out the source and built it in IDEA. The Eclipse plugin was a Google Summer of Code project sponsored by ReviewBoard. I am not sure how to get the source code, but there is an Eclipse download site at http://www.knittig.de/ereviewboard/update/ . -Original Message- From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Pv Sent: Monday, November 16, 2009 3:02 PM To: reviewboard Subject: Re: Eclipse plugin: basic usage? Where is this Eclipse and/or IDEA plugin? I searched the reviewboard and rbtools git repo and didn't see anything. I do see the review though: http://reviews.reviewboard.org/r/967/ But browsing git I can't find that path. Is there a VS plugin took? [or in the works?] Pv On Nov 16, 8:23 am, Bickford, Mark mark_bickf...@wrightexpress.com wrote: Hi, We're just starting to implement ReviewBoard, and I have some questions about the Eclipse plugin. I'll be upfront in saying that I have very little experience with Eclipse (preferring to use IDEA), but some of our developers use Eclipse and I need to be able to support them. I am able to bring up the Reviewboard view in Mylyn, see outstanding reviews and create a new task; that, in turn, creates an empty review request in RB. So far, so good. Now, my questions are this: 1. When I create a new task, I am offered a dialog in which I can choose a Subversion repository and enter a revision number. Is including a revision number the way to upload a diff through the plugin, and if so, is it the only way? 2. Does the plugin have the ability to create a diff from the changed files in the currently-open project, and automatically post it when I create the task (i.e., a pre-commit workflow)? I've had good luck so far with the IDEA plugin someone created, which exposes most of the post-commit.exe functionality and also ties in well with the IDEA VCS API. I am just wondering if the Eclipse plugin has the same abilities. Thanks, Mark H. Bickford To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
