ReviewBoard 3.0.3 email sender

[akarasik]

Hi,

We migrated Reviewboard from 2.0.11 to 3.0.3.
We have a git hook ,which didn't changed, that posts reviews using RBTools 
by running:
rbt post -p --repository-type git --server http://rb.local.com --repository 
ob-test *--username rb-automation-user* --password  
rb-automation-pass --tracking-branch git/master *--submit-as myusername* 
--guess-summary --guess-description --target-people myusername  --branch 
refs/heads/master 96ad0db93f07a32f8e53911bdbeed99a8ea67a36

Before the migration - we were getting review emails, where the emails 
senders were the users pushed the commit (the --submit-as parameter).
After the migration the sender of all mails is the one which authenticates 
to RB, in the --username parameter (rb-automation-user).

Can we somehow make the email sender to be the --submit-as user?

Thanks!

-- 
The above terms reflect a potential business arrangement, are provided solely 
as a basis for further discussion, and are not intended to be and do not 
constitute a legally binding obligation. No legally binding obligations will 
be created, implied, or inferred until an agreement in final form is executed 
in writing by all parties involved.

This email and any attachments hereto may be confidential or privileged. 
 If you received this communication by mistake, please don't forward it to 
anyone else, please erase all copies and attachments, and please let me 
know that it has gone to the wrong person. Thanks.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: There was an error displaying this diff

[akarasik]

Hi,
That sounds interesting.
Are there any version requirements for RBTools or Reviewboard?

On Monday, January 8, 2018 at 9:16:28 PM UTC+2, David Trowbridge wrote:
>
> Bitbucket Server (nee Stash) isn't yet supported by Review Board. We're 
> actively working on adding support in Power Pack. If you'd like to help us 
> test it out, I can get you a beta build.
>
> -David
>
> On Mon, Jan 8, 2018 at 8:29 AM  wrote:
>
>> Hello,
>>
>> I'm trying to post review from our hosted Bitbucket, to hosted 
>> Reviewboard using the RBTools.
>> The Reviewboard version is 2.0.11
>> The RBTools version is 0.7.2
>> It seems to have some issue with the diff of the files but I can't figure 
>> out what it is.
>> Is there any place I can check the reason of the failure?
>>
>> I configured a new repository in reviewboard as a custom git repository 
>> with a matching raw url mask.
>>
>> I use the following command to send the review:
>>
>> */usr/local/bin/rbt post -d -p --repository-type git --server 
>> http://rb.server.com  --repository my-test-repo 
>> --username post-commit-user --password  post-commit-user --tracking-branch 
>> origin/master --submit-as myuser --guess-summary --guess-description 
>> --branch master c19f372a155993747a9206f0c8fe0085d02acb2b*
>>
>> And I'm getting a msg that the review was posted.
>> The STDERR is:
>> * RBTools 0.7.2*
>> *>>> Python 2.7.6 (default, Oct 26 2016, 20:30:19)*
>> *[GCC 4.8.4]*
>> *>>> Running on Linux-3.13.0-112-generic-x86_64-with-Ubuntu-14.04-trusty*
>> *>>> Home = /my_home*
>> *>>> Current directory = /my_home/shared/data/repositories/902*
>> *>>> Checking for a Git repository...*
>> *>>> Running: git rev-parse --git-dir*
>> *>>> Running: git config core.bare*
>> *>>> Running: git symbolic-ref -q HEAD*
>> *>>> Running: git config --get branch.master.merge*
>> *>>> Command exited with rc 1: ['git', 'config', '--get', 
>> u'branch.master.merge']*
>> *---*
>> *>>> Running: git config --get branch.master.remote*
>> *>>> Command exited with rc 1: ['git', 'config', '--get', 
>> u'branch.master.remote']*
>> *---*
>> *>>> Running: git config --get remote.origin.url*
>> *>>> Command exited with rc 1: ['git', 'config', '--get', 
>> 'remote.origin.url']*
>> *---*
>> *>>> Running: git config --get remote.origin.url*
>> *>>> Command exited with rc 1: ['git', 'config', '--get', 
>> 'remote.origin.url']*
>> *---*
>> *>>> repository info: Path: /my_home/shared/data/repositories/902, Base 
>> path: , Supports changesets: False*
>> *>>> Making HTTP GET request to http://rb.server.com/api/ 
>> *
>> *>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b*
>> *>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b^*
>> *>>> Running: git merge-base 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7 
>> master*
>> *>>> Running: git rev-parse --git-dir*
>> *>>> Running: git -c core.quotepath=false -c diff.noprefix=false diff 
>> --no-color --full-index --ignore-submodules -M --no-ext-diff 
>> 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7..c19f372a155993747a9206f0c8fe0085d02acb2b*
>> *>>> Running: git log --reverse --pretty=format:%s%n%n%b 
>> ^8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7 
>> c19f372a155993747a9206f0c8fe0085d02acb2b*
>> *>>> Making HTTP GET request to 
>> http://rb.server.com/api/review-requests/?only-links=create= 
>> *
>> *>>> Making HTTP POST request to http://rb 
>> . server.com/api/review-requests/ 
>> *
>> *>>> Making HTTP GET request to http://rb 
>> . server.com/api/review-requests/304341/diffs/?only-fields= 
>> *
>> *>>> Making HTTP POST request to http://rb 
>> . server.com/api/review-requests/304341/diffs/ 
>> *
>> *>>> Making HTTP GET request to http://rb 
>> . 
>> server.com/api/review-requests/304341/draft/?only-fields=commit_id 
>> *
>> *>>> Making HTTP PUT request to http://rb 
>> . server.com/api/review-requests/304341/draft/ 
>> *
>>
>> The diff in the review showing the following:
>> *The patch to 'testfile.sh' didn't apply cleanly. The temporary files 
>> have been left in '/tmp/reviewboard.Pj6_Hj' for debugging purposes.*
>> *`patch` returned: *
>> *This may be a bug in the software, a temporary outage, or an issue with 
>> the format of your diff.*
>>
>> And the tmp folder contains following files:
>>
>> *testfile.sh.diff*
>> *diff --git a/testfile.sh b/testfile.sh*
>> *index 
>> 083e35784e55e496abb30dffeed7ab11e3d21747..6e7fbe249ce5d2fc350a2a0085f5c11dfaea34df
>>  
>> 100644*
>> *--- a/testfile.sh*
>> *+++ b/testfile.sh*
>> *@@ -1,4 +1,3 @@*
>> * #!/bin/bash*
>>
>> * echo "test"*
>> 

There was an error displaying this diff

[akarasik]

Hello,

I'm trying to post review from our hosted Bitbucket, to hosted Reviewboard 
using the RBTools.
The Reviewboard version is 2.0.11
The RBTools version is 0.7.2
It seems to have some issue with the diff of the files but I can't figure 
out what it is.
Is there any place I can check the reason of the failure?

I configured a new repository in reviewboard as a custom git repository 
with a matching raw url mask.

I use the following command to send the review:

*/usr/local/bin/rbt post -d -p --repository-type git --server 
http://rb.server.com --repository my-test-repo --username post-commit-user 
--password  post-commit-user --tracking-branch origin/master --submit-as 
myuser --guess-summary --guess-description --branch master 
c19f372a155993747a9206f0c8fe0085d02acb2b*

And I'm getting a msg that the review was posted.
The STDERR is:
* RBTools 0.7.2*
*>>> Python 2.7.6 (default, Oct 26 2016, 20:30:19)*
*[GCC 4.8.4]*
*>>> Running on Linux-3.13.0-112-generic-x86_64-with-Ubuntu-14.04-trusty*
*>>> Home = /my_home*
*>>> Current directory = /my_home/shared/data/repositories/902*
*>>> Checking for a Git repository...*
*>>> Running: git rev-parse --git-dir*
*>>> Running: git config core.bare*
*>>> Running: git symbolic-ref -q HEAD*
*>>> Running: git config --get branch.master.merge*
*>>> Command exited with rc 1: ['git', 'config', '--get', 
u'branch.master.merge']*
*---*
*>>> Running: git config --get branch.master.remote*
*>>> Command exited with rc 1: ['git', 'config', '--get', 
u'branch.master.remote']*
*---*
*>>> Running: git config --get remote.origin.url*
*>>> Command exited with rc 1: ['git', 'config', '--get', 
'remote.origin.url']*
*---*
*>>> Running: git config --get remote.origin.url*
*>>> Command exited with rc 1: ['git', 'config', '--get', 
'remote.origin.url']*
*---*
*>>> repository info: Path: /my_home/shared/data/repositories/902, Base 
path: , Supports changesets: False*
*>>> Making HTTP GET request to http://rb.server.com/api/*
*>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b*
*>>> Running: git rev-parse c19f372a155993747a9206f0c8fe0085d02acb2b^*
*>>> Running: git merge-base 8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7 
master*
*>>> Running: git rev-parse --git-dir*
*>>> Running: git -c core.quotepath=false -c diff.noprefix=false diff 
--no-color --full-index --ignore-submodules -M --no-ext-diff 
8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7..c19f372a155993747a9206f0c8fe0085d02acb2b*
*>>> Running: git log --reverse --pretty=format:%s%n%n%b 
^8f67a5dd89a4e88838617bc9cfb87cce08aa2bb7 
c19f372a155993747a9206f0c8fe0085d02acb2b*
*>>> Making HTTP GET request to 
http://rb.server.com/api/review-requests/?only-links=create=*
*>>> Making HTTP POST request to http://rb. server.com/api/review-requests/*
*>>> Making HTTP GET request to 
http://rb. server.com/api/review-requests/304341/diffs/?only-fields=*
*>>> Making HTTP POST request to 
http://rb. server.com/api/review-requests/304341/diffs/*
*>>> Making HTTP GET request to 
http://rb. server.com/api/review-requests/304341/draft/?only-fields=commit_id*
*>>> Making HTTP PUT request to 
http://rb. server.com/api/review-requests/304341/draft/*

The diff in the review showing the following:
*The patch to 'testfile.sh' didn't apply cleanly. The temporary files have 
been left in '/tmp/reviewboard.Pj6_Hj' for debugging purposes.*
*`patch` returned: *
*This may be a bug in the software, a temporary outage, or an issue with 
the format of your diff.*

And the tmp folder contains following files:

*testfile.sh.diff*
*diff --git a/testfile.sh b/testfile.sh*
*index 
083e35784e55e496abb30dffeed7ab11e3d21747..6e7fbe249ce5d2fc350a2a0085f5c11dfaea34df
 
100644*
*--- a/testfile.sh*
*+++ b/testfile.sh*
*@@ -1,4 +1,3 @@*
* #!/bin/bash*

* echo "test"*
*-echo "another test"*

*tmplt0vvX*
*#!/bin/bash*

*echo "test"*

*tmplt0vvX-new* - empty file

*tmplt0vvX-new.rej*
*--- testfile.sh*
*+++ testfile.sh*
*@@ -1,4 +1,3 @@*
* #!/bin/bash*

* echo "test"*
*-echo "another test"*



-- 
The above terms reflect a potential business arrangement, are provided solely 
as a basis for further discussion, and are not intended to be and do not 
constitute a legally binding obligation. No legally binding obligations will 
be created, implied, or inferred until an agreement in final form is executed 
in writing by all parties involved.

This email and any attachments hereto may be confidential or privileged. 
 If you received this communication by mistake, please don't forward it to 
anyone else, please erase all copies and attachments, and please let me 
know that it has gone to the wrong person. Thanks.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group