Old rbtools - Updating reviews from git overrides fields, ignoring newlines

[Yair Yogev]

We use an old version or rbtools, but a new version of reviewboard.
It would be great to know if these issues are something we might get rid of 
by updating the rbtools.

1. When doing post-review (yes, we still use that) of a git commit, the 
description that appear in reviewboard will be just one long line, ignoring 
the newlines entered during commit.
2. When updating the same review using "post-review COMMIT_HASH -r 
 REVIEW_NUM" it will override the current values of the review (description 
& summary), unlike the behavior in perforce where only the diff is updated.


I think that our rbtools are as old as 0.5.2 (!). Were the issues above 
known in that version?  is it fixed today?

I'm describing our current rbtools with hesitation since I'm not completely 
sure if it went though any customizations. I'm assuming not, but both David 
and Christian might know better although they probably last seen it in 2013 
:)


Thanks!

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Old rbtools - Updating reviews from git overrides fields, ignoring newlines

[Yair Yogev]

Thanks for the info David!

On Sunday, October 4, 2015 at 6:18:11 PM UTC+3, David Trowbridge wrote:
>
> post-review at VMware does have some significant modifications (which we 
> don't have much knowledge of), especially for git. Neither of those issues 
> sound familiar to me. You can definitely try 'rbt post' / 'ruby post -g' 
> using a modern rbtools and see if it works for you.
>
> -David
> On Sun, Oct 4, 2015 at 8:06 AM Yair Yogev  
> wrote:
>
>> We use an old version or rbtools, but a new version of reviewboard.
>> It would be great to know if these issues are something we might get rid 
>> of by updating the rbtools.
>>
>> 1. When doing post-review (yes, we still use that) of a git commit, the 
>> description that appear in reviewboard will be just one long line, ignoring 
>> the newlines entered during commit.
>> 2. When updating the same review using "post-review COMMIT_HASH -r 
>>  REVIEW_NUM" it will override the current values of the review (description 
>> & summary), unlike the behavior in perforce where only the diff is updated.
>>
>>
>> I think that our rbtools are as old as 0.5.2 (!). Were the issues above 
>> known in that version?  is it fixed today?
>>
>> I'm describing our current rbtools with hesitation since I'm not 
>> completely sure if it went though any customizations. I'm assuming not, but 
>> both David and Christian might know better although they probably last seen 
>> it in 2013 :)
>>
>>
>> Thanks!
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
> -- 
> -David 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Old rbtools - Updating reviews from git overrides fields, ignoring newlines

[David Trowbridge]

post-review at VMware does have some significant modifications (which we
don't have much knowledge of), especially for git. Neither of those issues
sound familiar to me. You can definitely try 'rbt post' / 'ruby post -g'
using a modern rbtools and see if it works for you.

-David
On Sun, Oct 4, 2015 at 8:06 AM Yair Yogev  wrote:

> We use an old version or rbtools, but a new version of reviewboard.
> It would be great to know if these issues are something we might get rid
> of by updating the rbtools.
>
> 1. When doing post-review (yes, we still use that) of a git commit, the
> description that appear in reviewboard will be just one long line, ignoring
> the newlines entered during commit.
> 2. When updating the same review using "post-review COMMIT_HASH -r
>  REVIEW_NUM" it will override the current values of the review (description
> & summary), unlike the behavior in perforce where only the diff is updated.
>
>
> I think that our rbtools are as old as 0.5.2 (!). Were the issues above
> known in that version?  is it fixed today?
>
> I'm describing our current rbtools with hesitation since I'm not
> completely sure if it went though any customizations. I'm assuming not, but
> both David and Christian might know better although they probably last seen
> it in 2013 :)
>
>
> Thanks!
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 
-David

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.