Re: post-review and perforce
I'm definitely a Python noob, but don't mind digging around in the code. I'm not familiar with python distributions and eggs, I assume I can just unzip the RBTools egg and then rezip it? I'll give it a shot when I have a free moment tomorrow and get back to you. Thanks again! tony On Sep 16, 10:43 pm, Christian Hammond chip...@chipx86.com wrote: Interesting. That's definitely the problem. post-review expects the version information to be entirely numeric. I don't know what your Python comfort level is, but if you edited rbtools/rbtools/postreview.py and found the line that includes Server version: , and modified it to look like: m = re.search(r'^Server version: [^ ]*/([0-9]+)\.([0-9]+)(\.PATCH)?/[0-9]+ .*$', It may be work. That's just off the top of my head. But give it a try and if it works, we can include it. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Sep 16, 2010 at 7:41 PM, Tony tony.cassan...@gmail.com wrote: Christian, Thanks for the quick response. I figured as much for the root thing. Realized after I sent the email that p4 wasn't on my path as root, so that explains it anyway... In terms of the p4 info the server version line is present: Server version: P4D/LINUX26AMD64/2005.2.PATCH/100601 (2006/05/26) The whole thing looks like this (with the personal details removed): User name: tony Client name: tony_mac Client host: mybox.local Client root: /folder/source Current directory: /folder/source Client address: 10.100.101.21:53141 Server address: perforcesrv1.mydomain.com:1666 Server root: /perforce_depot/ Server date: 2010/09/16 19:35:27 -0700 PDT Server version: P4D/LINUX26AMD64/2005.2.PATCH/100601 (2006/05/26) Server license: MyCompany Inc 17 users (support expired 2007/05/16) Thanks again! tony On Sep 16, 6:40 pm, Christian Hammond chip...@chipx86.com wrote: Hi Tony, We discourage running as root, so that wouldn't be it. It's likely that it's failing to parse the server version info. Can you type `p4 info` and show me the Server version: line, if it exists? If it doesn't, that's useful to know too, and I'd like to know if there's an equivalent line on there. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Sep 16, 2010 at 6:20 PM, Tony tony.cassan...@gmail.com wrote: Hey everyone, I'm trying to get ReviewBoard set up. Installing the server was no problem, however I've been having issues with post-review and perforce. I have two problems, the first is clearly a permission problem, but I can't seem to find where the python files live to change them. I'm not super familiar with Python so excuse my ignorance. I'm on OS X and running an older (server 2005.2) version of perforce. The first error is: post-review -d svn info git rev-parse --git-dir hg root p4 info Traceback (most recent call last): File /usr/local/bin/post-review, line 8, in module load_entry_point('RBTools==0.2', 'console_scripts', 'post-review') () File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 2809, in main File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 2759, in determine_client File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 1409, in get_repository_info AttributeError: 'NoneType' object has no attribute 'group' When running as root this changes to the following: sudo post-review -d svn info git rev-parse --git-dir hg root p4 info The current directory does not contain a checkout from a supported source code repository. The p4 command line tool is on my path and runs without issue alone. Any and all pointers are appreciated. Or if there's a better place for me to ask this, please let me know. I've tried digging through the docs and didn't see anything that might solve the issues. Clearly running the tool as root isn't ideal, but isn't a dealbreaker either. Thanks in advance! tony -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/
Re: post-review and perforce
Hmmm, so changing the regex allows post-review to detect perforce and begin uploading. However, I ran into a second problem with the way post-review is creating the repository url. I ended up just removing the whole try block from get_repository_info in the PerforceClient since it was picking up the correct URL for me without doing any of that. Might that create other problems down the line? After this, I'm able to upload, however, reviewboard reports that the diff is empty. I run with --output-diffs and it definitely isn't empty. I've copied the last portion of the debug output below. The server log reports that it begins parsing the diff and its size is 838 as shown in the post-review debug log below. Any thoughts on why this might be? Thanks again for all the help! Uploading diff, size: 838 HTTP POSTing to http://buildsrv1.domain.com/reviews/api/json/reviewrequests/9/diff/new/: {} Got API Error 105 (HTTP code 200): One or more fields had errors Error data: {u'fields': {u'path': [u'[Errno 2] No such file or directory']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 105}} tony On Sep 17, 12:49 am, Jan Koprowski jan.koprow...@gmail.com wrote: Better option is use tool which allow You edit files inside zip. Under Linux Midnight Command should do it. On Fri, Sep 17, 2010 at 9:20 AM, Tony tony.cassan...@gmail.com wrote: I'm definitely a Python noob, but don't mind digging around in the code. I'm not familiar with python distributions and eggs, I assume I can just unzip the RBTools egg and then rezip it? I'll give it a shot when I have a free moment tomorrow and get back to you. Thanks again! tony On Sep 16, 10:43 pm, Christian Hammond chip...@chipx86.com wrote: Interesting. That's definitely the problem. post-review expects the version information to be entirely numeric. I don't know what your Python comfort level is, but if you edited rbtools/rbtools/postreview.py and found the line that includes Server version: , and modified it to look like: m = re.search(r'^Server version: [^ ]*/([0-9]+)\.([0-9]+)(\.PATCH)?/[0-9]+ .*$', It may be work. That's just off the top of my head. But give it a try and if it works, we can include it. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Sep 16, 2010 at 7:41 PM, Tony tony.cassan...@gmail.com wrote: Christian, Thanks for the quick response. I figured as much for the root thing. Realized after I sent the email that p4 wasn't on my path as root, so that explains it anyway... In terms of the p4 info the server version line is present: Server version: P4D/LINUX26AMD64/2005.2.PATCH/100601 (2006/05/26) The whole thing looks like this (with the personal details removed): User name: tony Client name: tony_mac Client host: mybox.local Client root: /folder/source Current directory: /folder/source Client address: 10.100.101.21:53141 Server address: perforcesrv1.mydomain.com:1666 Server root: /perforce_depot/ Server date: 2010/09/16 19:35:27 -0700 PDT Server version: P4D/LINUX26AMD64/2005.2.PATCH/100601 (2006/05/26) Server license: MyCompany Inc 17 users (support expired 2007/05/16) Thanks again! tony On Sep 16, 6:40 pm, Christian Hammond chip...@chipx86.com wrote: Hi Tony, We discourage running as root, so that wouldn't be it. It's likely that it's failing to parse the server version info. Can you type `p4 info` and show me the Server version: line, if it exists? If it doesn't, that's useful to know too, and I'd like to know if there's an equivalent line on there. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Sep 16, 2010 at 6:20 PM, Tony tony.cassan...@gmail.com wrote: Hey everyone, I'm trying to get ReviewBoard set up. Installing the server was no problem, however I've been having issues with post-review and perforce. I have two problems, the first is clearly a permission problem, but I can't seem to find where the python files live to change them. I'm not super familiar with Python so excuse my ignorance. I'm on OS X and running an older (server 2005.2) version of perforce. The first error is: post-review -d svn info git rev-parse --git-dir hg root p4 info Traceback (most recent call last): File /usr/local/bin/post-review, line 8, in module load_entry_point('RBTools==0.2', 'console_scripts', 'post-review') () File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 2809, in main File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 2759, in determine_client File build/bdist.linux-x86_64/egg/rbtools/postreview.py,
Re: post-review and perforce
Ahhh, crap, I'm an idiot. Forgot to put p4 on the path of my apache user. Everything seems to be chill now. One final question: What is the recommended way for distributing my local copy of the post-review tool to the others on my team? I checked out the code from git (release-0.2) as well. Is there any need to fork and upload back? Seems like you already added the regex change to master. Thanks again for all the help guys! tony On Sep 17, 12:19 pm, Tony tony.cassan...@gmail.com wrote: Hmmm, so changing the regex allows post-review to detect perforce and begin uploading. However, I ran into a second problem with the way post-review is creating the repository url. I ended up just removing the whole try block from get_repository_info in the PerforceClient since it was picking up the correct URL for me without doing any of that. Might that create other problems down the line? After this, I'm able to upload, however, reviewboard reports that the diff is empty. I run with --output-diffs and it definitely isn't empty. I've copied the last portion of the debug output below. The server log reports that it begins parsing the diff and its size is 838 as shown in the post-review debug log below. Any thoughts on why this might be? Thanks again for all the help! Uploading diff, size: 838 HTTP POSTing tohttp://buildsrv1.domain.com/reviews/api/json/reviewrequests/9/diff/new/:{} Got API Error 105 (HTTP code 200): One or more fields had errors Error data: {u'fields': {u'path': [u'[Errno 2] No such file or directory']}, u'stat': u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 105}} tony On Sep 17, 12:49 am, Jan Koprowski jan.koprow...@gmail.com wrote: Better option is use tool which allow You edit files inside zip. Under Linux Midnight Command should do it. On Fri, Sep 17, 2010 at 9:20 AM, Tony tony.cassan...@gmail.com wrote: I'm definitely a Python noob, but don't mind digging around in the code. I'm not familiar with python distributions and eggs, I assume I can just unzip the RBTools egg and then rezip it? I'll give it a shot when I have a free moment tomorrow and get back to you. Thanks again! tony On Sep 16, 10:43 pm, Christian Hammond chip...@chipx86.com wrote: Interesting. That's definitely the problem. post-review expects the version information to be entirely numeric. I don't know what your Python comfort level is, but if you edited rbtools/rbtools/postreview.py and found the line that includes Server version: , and modified it to look like: m = re.search(r'^Server version: [^ ]*/([0-9]+)\.([0-9]+)(\.PATCH)?/[0-9]+ .*$', It may be work. That's just off the top of my head. But give it a try and if it works, we can include it. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Sep 16, 2010 at 7:41 PM, Tony tony.cassan...@gmail.com wrote: Christian, Thanks for the quick response. I figured as much for the root thing. Realized after I sent the email that p4 wasn't on my path as root, so that explains it anyway... In terms of the p4 info the server version line is present: Server version: P4D/LINUX26AMD64/2005.2.PATCH/100601 (2006/05/26) The whole thing looks like this (with the personal details removed): User name: tony Client name: tony_mac Client host: mybox.local Client root: /folder/source Current directory: /folder/source Client address: 10.100.101.21:53141 Server address: perforcesrv1.mydomain.com:1666 Server root: /perforce_depot/ Server date: 2010/09/16 19:35:27 -0700 PDT Server version: P4D/LINUX26AMD64/2005.2.PATCH/100601 (2006/05/26) Server license: MyCompany Inc 17 users (support expired 2007/05/16) Thanks again! tony On Sep 16, 6:40 pm, Christian Hammond chip...@chipx86.com wrote: Hi Tony, We discourage running as root, so that wouldn't be it. It's likely that it's failing to parse the server version info. Can you type `p4 info` and show me the Server version: line, if it exists? If it doesn't, that's useful to know too, and I'd like to know if there's an equivalent line on there. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Sep 16, 2010 at 6:20 PM, Tony tony.cassan...@gmail.com wrote: Hey everyone, I'm trying to get ReviewBoard set up. Installing the server was no problem, however I've been having issues with post-review and perforce. I have two problems, the first is clearly a permission problem, but I can't seem to find where the python files live to change them. I'm not super familiar with Python so excuse my ignorance. I'm on OS X
Re: post-review and perforce
Hi Tony, We discourage running as root, so that wouldn't be it. It's likely that it's failing to parse the server version info. Can you type `p4 info` and show me the Server version: line, if it exists? If it doesn't, that's useful to know too, and I'd like to know if there's an equivalent line on there. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Sep 16, 2010 at 6:20 PM, Tony tony.cassan...@gmail.com wrote: Hey everyone, I'm trying to get ReviewBoard set up. Installing the server was no problem, however I've been having issues with post-review and perforce. I have two problems, the first is clearly a permission problem, but I can't seem to find where the python files live to change them. I'm not super familiar with Python so excuse my ignorance. I'm on OS X and running an older (server 2005.2) version of perforce. The first error is: post-review -d svn info git rev-parse --git-dir hg root p4 info Traceback (most recent call last): File /usr/local/bin/post-review, line 8, in module load_entry_point('RBTools==0.2', 'console_scripts', 'post-review') () File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 2809, in main File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 2759, in determine_client File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 1409, in get_repository_info AttributeError: 'NoneType' object has no attribute 'group' When running as root this changes to the following: sudo post-review -d svn info git rev-parse --git-dir hg root p4 info The current directory does not contain a checkout from a supported source code repository. The p4 command line tool is on my path and runs without issue alone. Any and all pointers are appreciated. Or if there's a better place for me to ask this, please let me know. I've tried digging through the docs and didn't see anything that might solve the issues. Clearly running the tool as root isn't ideal, but isn't a dealbreaker either. Thanks in advance! tony -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review and perforce
Christian, Thanks for the quick response. I figured as much for the root thing. Realized after I sent the email that p4 wasn't on my path as root, so that explains it anyway... In terms of the p4 info the server version line is present: Server version: P4D/LINUX26AMD64/2005.2.PATCH/100601 (2006/05/26) The whole thing looks like this (with the personal details removed): User name: tony Client name: tony_mac Client host: mybox.local Client root: /folder/source Current directory: /folder/source Client address: 10.100.101.21:53141 Server address: perforcesrv1.mydomain.com:1666 Server root: /perforce_depot/ Server date: 2010/09/16 19:35:27 -0700 PDT Server version: P4D/LINUX26AMD64/2005.2.PATCH/100601 (2006/05/26) Server license: MyCompany Inc 17 users (support expired 2007/05/16) Thanks again! tony On Sep 16, 6:40 pm, Christian Hammond chip...@chipx86.com wrote: Hi Tony, We discourage running as root, so that wouldn't be it. It's likely that it's failing to parse the server version info. Can you type `p4 info` and show me the Server version: line, if it exists? If it doesn't, that's useful to know too, and I'd like to know if there's an equivalent line on there. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Sep 16, 2010 at 6:20 PM, Tony tony.cassan...@gmail.com wrote: Hey everyone, I'm trying to get ReviewBoard set up. Installing the server was no problem, however I've been having issues with post-review and perforce. I have two problems, the first is clearly a permission problem, but I can't seem to find where the python files live to change them. I'm not super familiar with Python so excuse my ignorance. I'm on OS X and running an older (server 2005.2) version of perforce. The first error is: post-review -d svn info git rev-parse --git-dir hg root p4 info Traceback (most recent call last): File /usr/local/bin/post-review, line 8, in module load_entry_point('RBTools==0.2', 'console_scripts', 'post-review') () File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 2809, in main File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 2759, in determine_client File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 1409, in get_repository_info AttributeError: 'NoneType' object has no attribute 'group' When running as root this changes to the following: sudo post-review -d svn info git rev-parse --git-dir hg root p4 info The current directory does not contain a checkout from a supported source code repository. The p4 command line tool is on my path and runs without issue alone. Any and all pointers are appreciated. Or if there's a better place for me to ask this, please let me know. I've tried digging through the docs and didn't see anything that might solve the issues. Clearly running the tool as root isn't ideal, but isn't a dealbreaker either. Thanks in advance! tony -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review and perforce
Interesting. That's definitely the problem. post-review expects the version information to be entirely numeric. I don't know what your Python comfort level is, but if you edited rbtools/rbtools/postreview.py and found the line that includes Server version: , and modified it to look like: m = re.search(r'^Server version: [^ ]*/([0-9]+)\.([0-9]+)(\.PATCH)?/[0-9]+ .*$', It may be work. That's just off the top of my head. But give it a try and if it works, we can include it. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Sep 16, 2010 at 7:41 PM, Tony tony.cassan...@gmail.com wrote: Christian, Thanks for the quick response. I figured as much for the root thing. Realized after I sent the email that p4 wasn't on my path as root, so that explains it anyway... In terms of the p4 info the server version line is present: Server version: P4D/LINUX26AMD64/2005.2.PATCH/100601 (2006/05/26) The whole thing looks like this (with the personal details removed): User name: tony Client name: tony_mac Client host: mybox.local Client root: /folder/source Current directory: /folder/source Client address: 10.100.101.21:53141 Server address: perforcesrv1.mydomain.com:1666 Server root: /perforce_depot/ Server date: 2010/09/16 19:35:27 -0700 PDT Server version: P4D/LINUX26AMD64/2005.2.PATCH/100601 (2006/05/26) Server license: MyCompany Inc 17 users (support expired 2007/05/16) Thanks again! tony On Sep 16, 6:40 pm, Christian Hammond chip...@chipx86.com wrote: Hi Tony, We discourage running as root, so that wouldn't be it. It's likely that it's failing to parse the server version info. Can you type `p4 info` and show me the Server version: line, if it exists? If it doesn't, that's useful to know too, and I'd like to know if there's an equivalent line on there. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Sep 16, 2010 at 6:20 PM, Tony tony.cassan...@gmail.com wrote: Hey everyone, I'm trying to get ReviewBoard set up. Installing the server was no problem, however I've been having issues with post-review and perforce. I have two problems, the first is clearly a permission problem, but I can't seem to find where the python files live to change them. I'm not super familiar with Python so excuse my ignorance. I'm on OS X and running an older (server 2005.2) version of perforce. The first error is: post-review -d svn info git rev-parse --git-dir hg root p4 info Traceback (most recent call last): File /usr/local/bin/post-review, line 8, in module load_entry_point('RBTools==0.2', 'console_scripts', 'post-review') () File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 2809, in main File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 2759, in determine_client File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 1409, in get_repository_info AttributeError: 'NoneType' object has no attribute 'group' When running as root this changes to the following: sudo post-review -d svn info git rev-parse --git-dir hg root p4 info The current directory does not contain a checkout from a supported source code repository. The p4 command line tool is on my path and runs without issue alone. Any and all pointers are appreciated. Or if there's a better place for me to ask this, please let me know. I've tried digging through the docs and didn't see anything that might solve the issues. Clearly running the tool as root isn't ideal, but isn't a dealbreaker either. Thanks in advance! tony -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/
RE: post-review with perforce
If you run p4 counters do you see the path to your RB server (in http://server/reviewboard/ format) in the repository_path counter? (If you have an older version of perforce the counter might have a different syntax, but it should still be visible) Dana Lacoste -Original Message- From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of rquit Sent: Tuesday, August 03, 2010 1:21 PM To: reviewboard Subject: post-review with perforce I believe I am all set up and now ready to create my first review. However, this is what happens: $ post-review 36875 --debug svn info p4 info repository info: Path: PATH, Base path: None, Supports changesets: True Generating diff for changenum 36875 p4 describe -s 36875 Processing edit of depot file Writing depot file#30 to /tmp/tmpOlKSIt p4 print -o /tmp/tmpOlKSIt -q depot file#30 diff -urNp /tmp/tmpOlKSIt local file Looking for 'server /' cookie in /root/.post-review-cookies.txt Loaded valid cookie -- no login required Attempting to create review request on PATH for 36875 HTTP POSTing to server/api/json/reviewrequests/new/: {'repository_path': 'PATH', 'changenum': '36875'} Got HTTP error: 500: What is wrong?? PLS HELP! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review with perforce
I do not have p4 counter set, but I did specify the exact path in my .reviewboardrc file. On Aug 3, 1:30 pm, Dana Lacoste dlaco...@aperio.com wrote: If you run p4 counters do you see the path to your RB server (inhttp://server/reviewboard/format) in the repository_path counter? (If you have an older version of perforce the counter might have a different syntax, but it should still be visible) Dana Lacoste -Original Message- From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of rquit Sent: Tuesday, August 03, 2010 1:21 PM To: reviewboard Subject: post-review with perforce I believe I am all set up and now ready to create my first review. However, this is what happens: $ post-review 36875 --debug svn info p4 info repository info: Path: PATH, Base path: None, Supports changesets: True Generating diff for changenum 36875 p4 describe -s 36875 Processing edit of depot file Writing depot file#30 to /tmp/tmpOlKSIt p4 print -o /tmp/tmpOlKSIt -q depot file#30 diff -urNp /tmp/tmpOlKSIt local file Looking for 'server /' cookie in /root/.post-review-cookies.txt Loaded valid cookie -- no login required Attempting to create review request on PATH for 36875 HTTP POSTing to server/api/json/reviewrequests/new/: {'repository_path': 'PATH', 'changenum': '36875'} Got HTTP error: 500: What is wrong?? PLS HELP! -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review in perforce
Repository info 'Path: salmon.hb-studios.local:1999, Base path: None, Supports changesets: True' Generating diff for changenum 79737 p4 describe -s 79737 Processing edit of //NBA/Branches/Release/packages/bball/live/nba/nba-main/prints.cpp Writing //NBA/Branches/Release/packages/bball/live/nba/nba-main/prints.cpp#4 to c:\users\sam1\appdata\local\temp\tmpl7xafj p4 print -q //NBA/Branches/Release/packages/bball/live/nba/nba-main/prints.cpp#4 p4 where //NBA/Branches/Release/packages/bball/live/nba/nba-main/prints.cpp diff -urNp c:\users\sam1\appdata\local\temp\tmpl7xafj c:\OldPc\NBA\NBA\Branches\Release\packages\bball\live\nba\nba-main\prints.cpp Unable to parse diff header: operable program or batch file On Sep 21, 9:37 pm, Christian Hammond [EMAIL PROTECTED] wrote: Looks like it had some issue running diff. Please run with --debug and paste the results. Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Sun, Sep 21, 2008 at 5:26 PM, saman sannandeji [EMAIL PROTECTED]wrote: this is all i get, unless you want me to run it in debug from perfforce, im not sure if that do able but i'll give it a try. On Sun, Sep 21, 2008 at 6:44 PM, Christian Hammond [EMAIL PROTECTED]wrote: Can you show me the full backtrace? Christian -- Christian Hammond - [EMAIL PROTECTED] VMware, Inc. On Fri, Sep 19, 2008 at 11:16 AM, 13Strider [EMAIL PROTECTED]wrote: I Fixed it thanks But now i get this Error Unable to parse diff header: operable program or batch file On Sep 19, 2:58 pm, 13Strider [EMAIL PROTECTED] wrote: I Guess i have to wait till i get a responce from Christan ? On Sep 19, 2:08 pm, 13Strider [EMAIL PROTECTED] wrote: This is Exactly what i got and I get the Error On Sep 19, 1:59 pm, Joshua Slominski [EMAIL PROTECTED] wrote: That is what you need. On Fri, Sep 19, 2008 at 12:57 PM, 13Strider [EMAIL PROTECTED]wrote: I have made the changes, this is what i have. # set the P4 enviroment: if options.p4_client: os.environ['P4CLIENT'] = options.p4_client if options.p4_port: os.environ['P4PORT'] = options.p4_port if isinstance(tool,PerforceClient): parser.add_option(--p4-client, dest=p4_client, default=None, help=the Perforce client name that the review is in) parser.add_option(--p4-port, dest=p4_port, default=None, help=the Perforce servers IP address that the review is on)- Hide quoted text - - Show quoted text -- Hide quoted text - - Show quoted text -- Hide quoted text - - Show quoted text - -- Sam Sannandeji Software Engineer HB Studios Multimedia Ltd. Halifax, NS, Canada 902-406-4600- Hide quoted text - - Show quoted text - --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---