Re: Djblets missing requires constraint on markdown?

2018-02-14 Thread Christian Hammond
Hi Eric,

Markdown isn't a hard dependency of Djblets, but it is a hard dependency of
Review Board. Djblets has some useful functionality for Markdown, but it
shouldn't even be imported if it's not being explicitly used by a calling
application (though it's possible that it's needed during the packaging
process).

Christian

On Wed, Feb 14, 2018 at 2:58 PM, 'Eric Johnson' via Review Board Community <
reviewboard@googlegroups.com> wrote:

> I'm working on packaging ReviewBoard for Gentoo, so that I can deploy an
> update.
>
> I noticed that the Djblets-1.0.3 release does not state a requirement on
> markdown. I'm not a Python expert, so I don't know if there's a good reason
> for its absence, or just an oversight?
>
> In any case, if it does need the dependency, then it should be on version
> 2.6.9 or later, as 2.6.8 has a bug that affects ReviewBoard.
>
> Thanks!
>
> Eric.
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Christian Hammond
President/CEO of Beanbag 
Makers of Review Board 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Djblets missing requires constraint on markdown?

2018-02-14 Thread 'Eric Johnson' via Review Board Community
I'm working on packaging ReviewBoard for Gentoo, so that I can deploy an
update.

I noticed that the Djblets-1.0.3 release does not state a requirement on
markdown. I'm not a Python expert, so I don't know if there's a good reason
for its absence, or just an oversight?

In any case, if it does need the dependency, then it should be on version
2.6.9 or later, as 2.6.8 has a bug that affects ReviewBoard.

Thanks!

Eric.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.