Re: GitHub private repo with RB

[Igor Kryltsov]

Google fucked up all attached images. Sorry. All was attached properly.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: GitHub private repo with RB

[Christian Hammond]

Hi Igor,

I don't know what you'd need the WebHook for. Sounds like you're set up to
use Review Board with GitHub.

We don't work with pull requests, if that's what you're asking. We don't
have support on our side, and even if we want to add them, there's a
challenge in figuring out how username association would work between the
two, and challenges with workflows in general.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Fri, Feb 1, 2013 at 4:47 AM, Igor Kryltsov krylt...@gmail.com wrote:

 1. Repo is set in RB
 2. SSH key is set in RB and visible in GitHub

 Question is what needs to be done in GitHub repo. Is is a matter of adding
 a web hook pointing to my RB URL?

 Thank you
 Igor

  --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/groups/opt_out.




-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: GitHub private repo with RB

[Igor Kryltsov]

Hi Christian,

We already use RB with SVN for a few years. It is in post commit mode. So 
there is SVN hook which tells RB about commit, RB pulls it and creates 
reviews.
On pictures attached, I think, I configured RB to be able to pull but what 
will tell RB about GitHub commit if not a web hook set in GitHub? My 
questions is what needs to nbe done to set it up.
 
We don't work with pull requests, if that's what you're asking

Is scenario I describe is what you call 'pull requests'? In this case what 
scenario IS supported by RB for GitHub?

Thank you

Igor

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.