Re: Not quite understanding the diff validation

2016-04-15 Thread Christian Hammond
Hi Galen, When generating the diff, are you always generating relative to a commit that's already been pushed upstream, or are you generating relative to a commit that might not be upstream? If the latter, you'll need to send two diffs across: A parent diff (from a pushed commit to the base commit

Not quite understanding the diff validation

2016-04-11 Thread Galen Elfert
Hi, In order to incorporate Reviewboard into a slightly unorthodox Mercurial-based workflow, I created a script that generates a diff by identifying changeset ranges and files using keywords, and then uses this diff to post a new review request. It's been working pretty well so far, but lately