Re: Using Perforce and Pre-Reviews
A better name for post-review is post-a-review. As long as you move the files you wish to review out of the default changelist you can use post-review. On Tue, Oct 7, 2008 at 5:41 AM, Marcos [EMAIL PROTECTED] wrote: Greetings. I installed reviewboard, and it seems to work ok using post-review, the only issue with is is that (as the name says) post-review is to make reviews already submitted, on what I want to do is use it on not committed changes. I use perforce, and that is why I am using post-review (as I heard p4 diff is broken, even I think that strange, specially using the -du flag). So does any one has a wrapper to p4 that allows the us of review-board with not submitted changes? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Using Perforce and Pre-Reviews
Now I get this error: Unable to parse diff header: : Invalid argument This is the debug output J:\post-review.py -n --debug --diff-only 56843 Repository info 'Path: perforce.server.com:1666, Base path: None, Supports changesets: True' Generating diff for changenum 56843 p4 describe -s 56843 Processing edit of //project/branches/my_branch/client/GUI/StartWindow.cpp Writing //project/branches/my_branch/client/GUI/StartWindow.cpp#1 to c:\docume~1\marcosp\locals~1\temp\tmpvzainx p4 print -q //project/branches/my_branch/client/GUI/StartWindow.cpp#1 p4 where //project/branches/my_branch/client/GUI/StartWindow.cpp diff -urNp c:\docume~1\marcosp\locals~1\temp\tmpvzainx C:/CODE\branches\my_branch\client\GUI\StartWindow.cpp On Oct 7, 4:21 pm, Marcos [EMAIL PROTECTED] wrote: Cool, those are great news. Thanks for the reply. On Oct 7, 3:25 pm, Joshua Slominski [EMAIL PROTECTED] wrote: A better name for post-review is post-a-review. As long as you move the files you wish to review out of the default changelist you can use post-review. On Tue, Oct 7, 2008 at 5:41 AM, Marcos [EMAIL PROTECTED] wrote: Greetings. I installed reviewboard, and it seems to work ok using post-review, the only issue with is is that (as the name says) post-review is to make reviews already submitted, on what I want to do is use it on not committed changes. I use perforce, and that is why I am using post-review (as I heard p4 diff is broken, even I think that strange, specially using the -du flag). So does any one has a wrapper to p4 that allows the us of review-board with not submitted changes? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Using Perforce and Pre-Reviews
I think the issue might be on this line: diff -urNp c:\docume~1\marcosp\locals~1\temp\tmpvzainx C:/CODE\branches\my_branch\client\GUI\StartWindow.cpp Slash and backslash together, does not sound right. Any ideas? On Oct 7, 4:42 pm, Marcos [EMAIL PROTECTED] wrote: Now I get this error: Unable to parse diff header: : Invalid argument This is the debug output J:\post-review.py -n --debug --diff-only 56843 Repository info 'Path: perforce.server.com:1666, Base path: None, Supports changesets: True' Generating diff for changenum 56843 p4 describe -s 56843 Processing edit of //project/branches/my_branch/client/GUI/StartWindow.cpp Writing //project/branches/my_branch/client/GUI/StartWindow.cpp#1 to c:\docume~1\marcosp\locals~1\temp\tmpvzainx p4 print -q //project/branches/my_branch/client/GUI/StartWindow.cpp#1 p4 where //project/branches/my_branch/client/GUI/StartWindow.cpp diff -urNp c:\docume~1\marcosp\locals~1\temp\tmpvzainx C:/CODE\branches\my_branch\client\GUI\StartWindow.cpp On Oct 7, 4:21 pm, Marcos [EMAIL PROTECTED] wrote: Cool, those are great news. Thanks for the reply. On Oct 7, 3:25 pm, Joshua Slominski [EMAIL PROTECTED] wrote: A better name for post-review is post-a-review. As long as you move the files you wish to review out of the default changelist you can use post-review. On Tue, Oct 7, 2008 at 5:41 AM, Marcos [EMAIL PROTECTED] wrote: Greetings. I installed reviewboard, and it seems to work ok using post-review, the only issue with is is that (as the name says) post-review is to make reviews already submitted, on what I want to do is use it on not committed changes. I use perforce, and that is why I am using post-review (as I heard p4 diff is broken, even I think that strange, specially using the -du flag). So does any one has a wrapper to p4 that allows the us of review-board with not submitted changes? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Using Perforce and Pre-Reviews
Greetings. I installed reviewboard, and it seems to work ok using post-review, the only issue with is is that (as the name says) post-review is to make reviews already submitted, on what I want to do is use it on not committed changes. I use perforce, and that is why I am using post-review (as I heard p4 diff is broken, even I think that strange, specially using the -du flag). So does any one has a wrapper to p4 that allows the us of review-board with not submitted changes? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
