Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3866 by kamaldee...@gmail.com: mxml source file patches fail to
get applied
https://code.google.com/p/reviewboard/issues/detail?id=3866
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or
Comment #8 on issue 3866 by chip...@gmail.com: mxml source file patches
fail to get applied
https://code.google.com/p/reviewboard/issues/detail?id=3866
It's a bit more complex than that. We don't just shell out to diff. Rather,
we use that as a base, and generate a more thorough diff that
Comment #2 on issue 3866 by kamaldee...@gmail.com: mxml source file patches
fail to get applied
https://code.google.com/p/reviewboard/issues/detail?id=3866
This code is protected under license, but I can share the initial few lines
if it helps. If not, I can just create a new mxml
Comment #4 on issue 3866 by kamaldee...@gmail.com: mxml source file patches
fail to get applied
https://code.google.com/p/reviewboard/issues/detail?id=3866
Nope, fails.
$ patch -p2 ZoroDebugPlayer.mxml ~/zdp.diff
patching file ZoroDebugPlayer.mxml
patch: malformed patch at line 5:
Comment #7 on issue 3866 by kamaldee...@gmail.com: mxml source file patches
fail to get applied
https://code.google.com/p/reviewboard/issues/detail?id=3866
I am using a post-review script built on top of RBTools. I looked in the
source and the way diff is done is using the unix diff
Comment #6 on issue 3866 by trowb...@gmail.com: mxml source file patches
fail to get applied
https://code.google.com/p/reviewboard/issues/detail?id=3866
You created your diff via `p4 diff`? Could you try with `rbt diff`?
--
You received this message because this project is configured to
Updates:
Status: NeedInfo
Comment #1 on issue 3866 by trowb...@gmail.com: mxml source file patches
fail to get applied
https://code.google.com/p/reviewboard/issues/detail?id=3866
It would be very helpful to see the patch file in question, not just the
source file.
--
You received
Comment #3 on issue 3866 by trowb...@gmail.com: mxml source file patches
fail to get applied
https://code.google.com/p/reviewboard/issues/detail?id=3866
Hrmph, ok. I really don't know why `patch` would say that it's malformed.
If you try applying that patch manually (by executing the patch
Comment #5 on issue 3866 by kamaldee...@gmail.com: mxml source file patches
fail to get applied
https://code.google.com/p/reviewboard/issues/detail?id=3866
The generated diff file does not look correct. I use perforce. The edited
lines are not in the patch at all.
Maybe this is a p4 diff
