Re: Issue 2150 in reviewboard: Data changes lost when creating New Review Request
Comment #2 on issue 2150 by dlalibe...@google.com: Data changes lost when creating New Review Request http://code.google.com/p/reviewboard/issues/detail?id=2150 Losing data is different from not publishing it. Both are related to not finishing what you are doing when leaving a page, but losing data is far worse because you can't recover it, whereas unpublished data is not lost, and can be published later. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2152 in reviewboard: 1.6RC1 issues with Internet Explorer
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2152 by marc.san...@gmail.com: 1.6RC1 issues with Internet Explorer http://code.google.com/p/reviewboard/issues/detail?id=2152 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.6RC1 What's the URL of the page containing the problem? reviewboard/r/863/ What steps will reproduce the problem? 1. Clicking on Review or Ship It! What is the expected output? What do you see instead? Should work but doesn't. It actually does nothing in IE What operating system are you using? What browser? Windows 7 Internet Explorer V9.0.8112.16421 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2153 in reviewboard: Anchors does not work in Chrome
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2153 by marc.san...@gmail.com: Anchors does not work in Chrome http://code.google.com/p/reviewboard/issues/detail?id=2153 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.6RC1 What's the URL of the page containing the problem? /r/863/diff/#index_header What steps will reproduce the problem? 1. Clicking on a link to a file or a diff in a file What is the expected output? What do you see instead? Should move to the appropriate location. Instead, it moves the page up! This only happens in Chrome and works well in other browsers tested (IE & Firefox). What operating system are you using? What browser? Windows 7 Chrome 12.0.742.100 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2154 in reviewboard: Published comments include every edited version instead of the latest one.
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2154 by daigle.a...@gmail.com: Published comments include every edited version instead of the latest one. http://code.google.com/p/reviewboard/issues/detail?id=2154 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.6RC1 What steps will reproduce the problem? 1. Send a review 2. Receive some comments from the reviewer 3. Comment back the reviewer by editing your comments multiple times 4. Publish the comments What is the expected output? What do you see instead? The expected output should be the final version of the comment, however the current behavior is to publish every version of the edited message. What operating system are you using? What browser? Reviewboard is hosted on Debian. Client is on Windows 7 using Opera 11.50 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2152 in reviewboard: 1.6RC1 issues with Internet Explorer
Updates: Status: NeedInfo Comment #1 on issue 2152 by chip...@gmail.com: 1.6RC1 issues with Internet Explorer http://code.google.com/p/reviewboard/issues/detail?id=2152 Can you provide the JavaScript error logs your browser is reporting? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1993 in reviewboard: Drag and Drop Not Working for Chrome or Safari on Mac (but works on Firefox 4)
Updates: Status: Started Owner: chip...@gmail.com Labels: -Priority-Medium Priority-High Milestone-Release1.6 Component-Screenshots Comment #1 on issue 1993 by chip...@gmail.com: Drag and Drop Not Working for Chrome or Safari on Mac (but works on Firefox 4) http://code.google.com/p/reviewboard/issues/detail?id=1993 I have a fix pending. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2154 in reviewboard: Published comments include every edited version instead of the latest one.
Updates: Status: NeedInfo Comment #1 on issue 2154 by chip...@gmail.com: Published comments include every edited version instead of the latest one. http://code.google.com/p/reviewboard/issues/detail?id=2154 Where are you editing the comments? Are these comments on the diff viewer? In the Review dialog? Replies to comments on a review? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2154 in reviewboard: Published comments include every edited version instead of the latest one.
Comment #2 on issue 2154 by daigle.a...@gmail.com: Published comments include every edited version instead of the latest one. http://code.google.com/p/reviewboard/issues/detail?id=2154 I've edited the comments in the review dialog. Thoses comments were replies to comment previously made by the reviewer. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2154 in reviewboard: Published comments include every edited version instead of the latest one.
Comment #3 on issue 2154 by daigle.a...@gmail.com: Published comments include every edited version instead of the latest one. http://code.google.com/p/reviewboard/issues/detail?id=2154 I've edited the comments in the "view review" page (the home page of a review). Thoses comments were replies to comments previously made by the reviewer. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2152 in reviewboard: 1.6RC1 issues with Internet Explorer
Comment #2 on issue 2152 by marc.san...@gmail.com: 1.6RC1 issues with Internet Explorer http://code.google.com/p/reviewboard/issues/detail?id=2152 SCRIPT1028: Expected identifier, string or number datastore.js?1309182118, line 1025 character 13 SCRIPT5009: 'RB' is undefined reviews.js?1309182118, line 9 character 1 SCRIPT438: Object doesn't support property or method 'commentSection' 862, line 502 character 7 -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2155 in reviewboard: post-review fails to upload diff if non-ascii characters are used in diff
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 2155 by jerb...@gmail.com: post-review fails to upload diff if
non-ascii characters are used in diff
http://code.google.com/p/reviewboard/issues/detail?id=2155
What version are you running?
RBTools v0.3.2
What steps will reproduce the problem?
1. use post-review to upload the attached patch for a review (note it works
in the browser)
Also, I'm aware that this seems to be a problem in Python 2.7's urllib.py
(perhaps an Ubuntu only problem, I don't know).
What is the expected output? What do you see instead?
Expected: Patch gets uploaded without a problem using post-review. Actual:
See stack trace below.
What operating system are you using? What browser?
I'm on Ubuntu 11.04, Firefox (totally unrelated for this problem)
Here is an example stack trace:
HTTP POSTing to
http://review.markusproject.org/api/review-requests/1048/diffs/: {}
Traceback (most recent call last):
File "/usr/local/bin/post-review", line 9, in
load_entry_point('RBTools==0.3.2', 'console_scripts', 'post-review')()
File "/usr/local/lib/python2.7/dist-packages/RBTools-0.3.2-py2.7.egg/rbtools/postreview.py",
line 3794, in main
submit_as=options.submit_as)
File "/usr/local/lib/python2.7/dist-packages/RBTools-0.3.2-py2.7.egg/rbtools/postreview.py",
line 3460, in tempt_fate
parent_diff_content)
File "/usr/local/lib/python2.7/dist-packages/RBTools-0.3.2-py2.7.egg/rbtools/postreview.py",
line 769, in upload_diff
fields, files)
File "/usr/local/lib/python2.7/dist-packages/RBTools-0.3.2-py2.7.egg/rbtools/postreview.py",
line 982, in api_post
return self.process_json(self.http_post(path, fields, files))
File "/usr/local/lib/python2.7/dist-packages/RBTools-0.3.2-py2.7.egg/rbtools/postreview.py",
line 903, in http_post
data = urllib2.urlopen(r).read()
File "/usr/lib/python2.7/urllib2.py", line 126, in urlopen
return _opener.open(url, data, timeout)
File "/usr/lib/python2.7/urllib2.py", line 391, in open
response = self._open(req, data)
File "/usr/lib/python2.7/urllib2.py", line 409, in _open
'_open', req)
File "/usr/lib/python2.7/urllib2.py", line 369, in _call_chain
result = func(*args)
File "/usr/lib/python2.7/urllib2.py", line 1185, in http_open
return self.do_open(httplib.HTTPConnection, req)
File "/usr/lib/python2.7/urllib2.py", line 1154, in do_open
h.request(req.get_method(), req.get_selector(), req.data, headers)
File "/usr/lib/python2.7/httplib.py", line 955, in request
self._send_request(method, url, body, headers)
File "/usr/lib/python2.7/httplib.py", line 989, in _send_request
self.endheaders(body)
File "/usr/lib/python2.7/httplib.py", line 951, in endheaders
self._send_output(message_body)
File "/usr/lib/python2.7/httplib.py", line 809, in _send_output
msg += message_body
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 14060:
ordinal not in range(128)
Not sure if that will be helpful:
$ locale
LANG=en_CA.UTF-8
LANGUAGE=en_CA:en
LC_CTYPE="en_CA.UTF-8"
LC_NUMERIC="en_CA.UTF-8"
LC_TIME="en_CA.UTF-8"
LC_COLLATE="en_CA.UTF-8"
LC_MONETARY="en_CA.UTF-8"
LC_MESSAGES="en_CA.UTF-8"
LC_PAPER="en_CA.UTF-8"
LC_NAME="en_CA.UTF-8"
LC_ADDRESS="en_CA.UTF-8"
LC_TELEPHONE="en_CA.UTF-8"
LC_MEASUREMENT="en_CA.UTF-8"
LC_IDENTIFICATION="en_CA.UTF-8"
LC_ALL=
Attachments:
sub_tabs.diff 15.8 KB
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1359 in reviewboard: Diff fails for text file with non-ascii characters
Comment #9 on issue 1359 by jerb...@gmail.com: Diff fails for text file with non-ascii characters http://code.google.com/p/reviewboard/issues/detail?id=1359 I'm pretty sure issue #2155 is a duplicate of this. The attachment attached there might be useful, though. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2155 in reviewboard: post-review fails to upload diff if non-ascii characters are used in diff
Comment #1 on issue 2155 by jerb...@gmail.com: post-review fails to upload diff if non-ascii characters are used in diff http://code.google.com/p/reviewboard/issues/detail?id=2155 BTW. I'm using --diff-filename. Here is the script we use (which in turn uses post-review): https://github.com/MarkUsProject/Markus/blob/master/lib/tools/post-markus-review -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2149 in reviewboard: Upgrade from 1.5.5 to 1.6RC1 breaks the review count
Updates: Labels: Milestone-Release1.6 Comment #1 on issue 2149 by trowb...@gmail.com: Upgrade from 1.5.5 to 1.6RC1 breaks the review count http://code.google.com/p/reviewboard/issues/detail?id=2149 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2139 in reviewboard: keyboard shortcuts do not work in Chrome
Updates: Status: Duplicate Mergedinto: 2110 Comment #1 on issue 2139 by trowb...@gmail.com: keyboard shortcuts do not work in Chrome http://code.google.com/p/reviewboard/issues/detail?id=2139 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2110 in reviewboard: Period/comma keys do not move the scrollbar in Chrome 12
Comment #4 on issue 2110 by trowb...@gmail.com: Period/comma keys do not move the scrollbar in Chrome 12 http://code.google.com/p/reviewboard/issues/detail?id=2110 Issue 2139 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2110 in reviewboard: Period/comma keys do not move the scrollbar in Chrome 12
Comment #5 on issue 2110 by trowb...@gmail.com: Period/comma keys do not move the scrollbar in Chrome 12 http://code.google.com/p/reviewboard/issues/detail?id=2110 Issue 2153 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2153 in reviewboard: Anchors does not work in Chrome
Updates: Status: Duplicate Mergedinto: 2110 Comment #1 on issue 2153 by trowb...@gmail.com: Anchors does not work in Chrome http://code.google.com/p/reviewboard/issues/detail?id=2153 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1993 in reviewboard: Drag and Drop Not Working for Chrome or Safari on Mac (but works on Firefox 4)
Updates: Status: Fixed Comment #2 on issue 1993 by chip...@gmail.com: Drag and Drop Not Working for Chrome or Safari on Mac (but works on Firefox 4) http://code.google.com/p/reviewboard/issues/detail?id=1993 Fixed on master (r6c36056) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2156 in reviewboard: Resolving issues modifies the review timestamp
Status: Accepted Owner: trowb...@gmail.com Labels: Type-Defect Priority-Medium Milestone-Release1.6 Component-Reviews New issue 2156 by trowb...@gmail.com: Resolving issues modifies the review timestamp http://code.google.com/p/reviewboard/issues/detail?id=2156 When a user changes the state of an issue, it also changes the timestamp of the related review. This messes up the display of our reviews list as things re-order themselves. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2096 in reviewboard: escape key deletes text in description and testing fields
Updates: Status: Confirmed Owner: chip...@gmail.com Labels: -Priority-Medium Priority-High Milestone-Release1.6 Usability Comment #2 on issue 2096 by chip...@gmail.com: escape key deletes text in description and testing fields http://code.google.com/p/reviewboard/issues/detail?id=2096 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2152 in reviewboard: 1.6RC1 issues with Internet Explorer
Updates: Status: Fixed Owner: chip...@gmail.com Labels: -Priority-Medium Priority-Critical Browser Comment #3 on issue 2152 by chip...@gmail.com: 1.6RC1 issues with Internet Explorer http://code.google.com/p/reviewboard/issues/detail?id=2152 Fixed on master (9d18a43) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
