Issue 2581 in reviewboard: diff can be viewed but cannot be downloaded (500)
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2581 by ppheath...@gmail.com: diff can be viewed but cannot be downloaded (500) http://code.google.com/p/reviewboard/issues/detail?id=2581 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.6.5 What's the URL of the page containing the problem? /r/{x}/diff/raw/ What steps will reproduce the problem? 1.upload some svn patch that contains Chinese(encoded) comments 2.try to download it, get 500, though view diff works What is the expected output? What do you see instead? What operating system are you using? What browser? Server: ubuntu Client: windows-Chrome Please provide any additional information below. logging of the error: 2012-04-26 13:58:01,933 - ERROR - Exception thrown for user admin at http://xxx/r/{x}/diff/raw/ 'ascii' codec can't encode characters in position 29-35: ordinal not in range(128), HTTP response headers must be in US-ASCII format Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/Django-1.3.1-py2.7.egg/django/core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.5-py2.7.egg/reviewboard/accounts/decorators.py, line 21, in _check return view_func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.5-py2.7.egg/reviewboard/reviews/views.py, line 776, in raw_diff resp['Content-Disposition'] = 'inline; filename=%s' % filename File /usr/local/lib/python2.7/dist-packages/Django-1.3.1-py2.7.egg/django/http/__init__.py, line 533, in __setitem__ header, value = self._convert_to_ascii(header, value) File /usr/local/lib/python2.7/dist-packages/Django-1.3.1-py2.7.egg/django/http/__init__.py, line 522, in _convert_to_ascii value = value.encode('us-ascii') UnicodeEncodeError: 'ascii' codec can't encode characters in position 29-35: ordinal not in range(128), HTTP response headers must be in US-ASCII format 2012-04-26 13:58:01,933 - ERROR - Internal Server Error: /r/{x}/diff/raw/ Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/Django-1.3.1-py2.7.egg/django/core/handlers/base.py, line 111, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.5-py2.7.egg/reviewboard/accounts/decorators.py, line 21, in _check return view_func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6.5-py2.7.egg/reviewboard/reviews/views.py, line 776, in raw_diff resp['Content-Disposition'] = 'inline; filename=%s' % filename File /usr/local/lib/python2.7/dist-packages/Django-1.3.1-py2.7.egg/django/http/__init__.py, line 533, in __setitem__ header, value = self._convert_to_ascii(header, value) File /usr/local/lib/python2.7/dist-packages/Django-1.3.1-py2.7.egg/django/http/__init__.py, line 522, in _convert_to_ascii value = value.encode('us-ascii') UnicodeEncodeError: 'ascii' codec can't encode characters in position 29-35: ordinal not in range(128), HTTP response headers must be in US-ASCII format -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2582 in reviewboard: Does not accept patch from Eclipse with refactoring
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2582 by jace...@gmail.com: Does not accept patch from Eclipse with refactoring http://code.google.com/p/reviewboard/issues/detail?id=2582 * NOTE: Do not post confidential information in this bug report. * * If you need immediate support, please contact* * reviewbo...@googlegroups.com * What version are you running? 1.6.6. What's the URL of the page containing the problem? N/A What steps will reproduce the problem? 1. Create a Java project in Eclipse 2. Create a Java class in a package 3. Commit to SVN 4. Refactor that class and move it to a different package, e.g. newpackage 5. create a patch 6. attempt to import into Reviewboard What is the expected output? What do you see instead? Get error like The file 'newpackage.ClassName.java' (r4579) could not be found in the repository Every time you refactor a class in Eclipse by moving it to a different location reviewboard refuses to accept the patch file. What operating system are you using? What browser? Linux, all browsers. Please provide any additional information below. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2578 in reviewboard: Wrong content type header value for multipart/form-data when using gadgets.io.proxiedMultipartFormPost
Updates: Status: Invalid Comment #3 on issue 2578 by trowb...@gmail.com: Wrong content type header value for multipart/form-data when using gadgets.io.proxiedMultipartFormPost http://code.google.com/p/reviewboard/issues/detail?id=2578 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1487 in reviewboard: svn file copy diff fails to upload
Comment #5 on issue 1487 by trowb...@gmail.com: svn file copy diff fails to upload http://code.google.com/p/reviewboard/issues/detail?id=1487 Issue 2582 has been merged into this issue. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2582 in reviewboard: Does not accept patch from Eclipse with refactoring
Updates: Status: Duplicate Mergedinto: 1487 Comment #1 on issue 2582 by trowb...@gmail.com: Does not accept patch from Eclipse with refactoring http://code.google.com/p/reviewboard/issues/detail?id=2582 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.