Re: Issue 3716 in reviewboard: Diff crashing with non-utf8 characters
Updates: Status: Fixed Comment #3 on issue 3716 by trowb...@gmail.com: Diff crashing with non-utf8 characters https://code.google.com/p/reviewboard/issues/detail?id=3716 Fixed in release-2.0.x (ad8ccf1). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3601 in reviewboard: Diffs disappearing and replaced with This is an empty file.
Comment #11 on issue 3601 by ondr...@salsitasoft.com: Diffs disappearing and replaced with This is an empty file. https://code.google.com/p/reviewboard/issues/detail?id=3601 For us it was any time viewing the diff. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3601 in reviewboard: Diffs disappearing and replaced with This is an empty file.
Comment #10 on issue 3601 by chip...@gmail.com: Diffs disappearing and replaced with This is an empty file. https://code.google.com/p/reviewboard/issues/detail?id=3601 Also, did this happen just when viewing interdiffs only, or any time viewing the diff? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3601 in reviewboard: Diffs disappearing and replaced with This is an empty file.
Comment #13 on issue 3601 by chip...@gmail.com: Diffs disappearing and replaced with This is an empty file. https://code.google.com/p/reviewboard/issues/detail?id=3601 I ask about the interdiff, because the only case where the conditions match up to cause the bug I'm seeing in the code is when viewing interdiffs. Do you still have access to review requests with this problem? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3601 in reviewboard: Diffs disappearing and replaced with This is an empty file.
Comment #15 on issue 3601 by chip...@gmail.com: Diffs disappearing and replaced with This is an empty file. https://code.google.com/p/reviewboard/issues/detail?id=3601 That meets the criteria for how to reproduce the bug. The only missing step is that, from what I can tell, it should only be possible to hit this for interdiffs. Or, alternatively, for files that only contained leading or trailing whitespace changes. Any chance that that was a common factor? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3717 in reviewboard: Get e-mail notifications for my own activity - still getting emails with my ShipIt
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3717 by lukasz.c...@gmail.com: Get e-mail notifications for my own activity - still getting emails with my ShipIt https://code.google.com/p/reviewboard/issues/detail?id=3717 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? 2.0.12 What's the URL of the page containing the problem? internal What steps will reproduce the problem? 1. Uncheck Get e-mail notifications for my own activity in Settings 2. ShipIt a review 3. Email with my ShipIt is sent even though the setting is unchecked What is the expected output? What do you see instead? Email with my own activity should not be sent. What operating system are you using? What browser? Linux RH5, Firefox 34.0.5 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3601 in reviewboard: Diffs disappearing and replaced with This is an empty file.
Comment #16 on issue 3601 by ondr...@salsitasoft.com: Diffs disappearing and replaced with This is an empty file. https://code.google.com/p/reviewboard/issues/detail?id=3601 I unfortunately don't manage to find any broken RR. The repo that had these issues was deleted and I don't remember encountering this recently (now using RB 2.0.11). And anyway, I always used rbt -r to update the RR, to fix the broken file. That was usually after some time when the commit was already pushed and stuff. Don't remember seeing the problem appear again after fixing the RR with rbt -r... -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3601 in reviewboard: Diffs disappearing and replaced with This is an empty file.
Comment #12 on issue 3601 by chip...@gmail.com: Diffs disappearing and replaced with This is an empty file. https://code.google.com/p/reviewboard/issues/detail?id=3601 What about the file? Was it added in a prior commit somewhere between origin/master and HEAD? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3601 in reviewboard: Diffs disappearing and replaced with This is an empty file.
Comment #14 on issue 3601 by ondr...@salsitasoft.com: Diffs disappearing and replaced with This is an empty file. https://code.google.com/p/reviewboard/issues/detail?id=3601 I would have to go through the RRs and try to find one. Anyway, we use a CLI utility wrapping rbt to post RRs. Most of the time it is used in the following way: 1) Create a local feature branch on top of branch develop. That branch can be pushed as well, not sure if that is important. 2) Code, code, code, commit, commit, commit. 3) Call the CLI utility, which in turn calls `rbt post HASH` for every commit that is on the feature branch but not on develop. When this is called, the new commits are usually not pushed yet (not sure how important that is). As I said, the feature branch might be tracking a remote branch or not. Let me know if you need more info. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3601 in reviewboard: Diffs disappearing and replaced with This is an empty file.
Updates: Status: Confirmed Comment #17 on issue 3601 by chip...@gmail.com: Diffs disappearing and replaced with This is an empty file. https://code.google.com/p/reviewboard/issues/detail?id=3601 Okay. I appreciate the info! Based on my tests, I'm fairly confident i've now tracked down the causes of this bug. The good news is that files were never deleted or made empty, they just had some bad calculated state that could occur after the first viewing in certain cases. We'll have a fix in for 2.0.13. I'd appreciate people trying to patch after it's up for review. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3601 in reviewboard: Diffs disappearing and replaced with This is an empty file.
Comment #18 on issue 3601 by chip...@gmail.com: Diffs disappearing and replaced with This is an empty file. https://code.google.com/p/reviewboard/issues/detail?id=3601 To further clarify, the empty state would happen in the following cases: 1) Showing interdiffs between two diffs containing a newly added file, when the interdiff should only show replaced lines. 2) Same as #1, but when the diff from a commit that was based on a parent commit that was newly introduced in the branch and not yet pushed upstream (due to a separate issue where the source revision was replaced with the marker for new file). 3) Same as #2, but with files that haven't actually changed between those revisions. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3718 in reviewboard: RBT setup-repo assumes http protocol given
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3718 by vincent@gmail.com: RBT setup-repo assumes http protocol given https://code.google.com/p/reviewboard/issues/detail?id=3718 What version are you running? rbt 0.7 What's the URL of the page containing the problem? N/A What steps will reproduce the problem? 1. Have an instance of ReviewBoard running (local machine, or online) 2. Set up a repository on ReviewBoard through the admin panel for use. 3. In the local copy of the repo, run `rbt setup-repo` 4. When prompt for server, enter the ip, or url without the http protocol What is the expected output? What do you see instead? Expected should be able to able to reach the server, with some protocol assumed if its missing. Currently, it shows an error. E.g.: ERROR: Could not reach the Review Board server at 0.0.0.0:8080 What operating system are you using? What browser? Xubuntu 14.04 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3715 in reviewboard: markdown_utils.py line 241, in iter_markdown_lines i += 1 TypeError: unsupported operand type(s) for +=: 'instance' and 'int'
Updates: Status: Fixed Comment #5 on issue 3715 by trowb...@gmail.com: markdown_utils.py line 241, in iter_markdown_lines i += 1 TypeError: unsupported operand type(s) for +=: 'instance' and 'int' https://code.google.com/p/reviewboard/issues/detail?id=3715 Fixed in release-2.0.x (4f11579). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3601 in reviewboard: Diffs disappearing and replaced with This is an empty file.
Updates: Status: Fixed Comment #19 on issue 3601 by chip...@gmail.com: Diffs disappearing and replaced with This is an empty file. https://code.google.com/p/reviewboard/issues/detail?id=3601 Fixed in release-2.0.x (6d2a0b8). This will go into Review Board 2.0.13. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
