Issue 3866 in reviewboard: mxml source file patches fail to get applied

Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3866 by kamaldee...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or

Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied

Comment #8 on issue 3866 by chip...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 It's a bit more complex than that. We don't just shell out to diff. Rather, we use that as a base, and generate a more thorough diff that

Re: Issue 1395 in reviewboard: Exporting review comments

Comment #11 on issue 1395 by rohithra...@gmail.com: Exporting review comments https://code.google.com/p/reviewboard/issues/detail?id=1395 It's been 5+ years now. using Reviewboard. Thanks a lot to the developers. Unfortunately, there was no response to: liannela...@gmail.com's question. I

Re: Issue 1395 in reviewboard: Exporting review comments

Comment #10 on issue 1395 by namrata@gmail.com: Exporting review comments https://code.google.com/p/reviewboard/issues/detail?id=1395 We need this feature too. It will be really useful extension. -- You received this message because this project is configured to send all issue

Re: Issue 3814 in reviewboard: AttributeError: 'Namespace' object has no attribute 'revision_range'

Updates: Status: PendingReview Owner: trowb...@gmail.com Labels: Component-RBTools Comment #2 on issue 3814 by trowb...@gmail.com: AttributeError: 'Namespace' object has no attribute 'revision_range' https://code.google.com/p/reviewboard/issues/detail?id=3814 (No

Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied

Comment #2 on issue 3866 by kamaldee...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 This code is protected under license, but I can share the initial few lines if it helps. If not, I can just create a new mxml

Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied

Comment #4 on issue 3866 by kamaldee...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 Nope, fails. $ patch -p2 ZoroDebugPlayer.mxml ~/zdp.diff patching file ZoroDebugPlayer.mxml patch: malformed patch at line 5:

Re: Issue 3863 in reviewboard: Web API should provide an id field for a review request's every depends_on entry

Comment #2 on issue 3863 by csipak.a...@ardinsys.eu: Web API should provide an id field for a review request's every depends_on entry https://code.google.com/p/reviewboard/issues/detail?id=3863 Thanks for the tip, but that would still mean a big payload and a lot of processing on the

Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied

Comment #7 on issue 3866 by kamaldee...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 I am using a post-review script built on top of RBTools. I looked in the source and the way diff is done is using the unix diff

Re: Issue 3858 in reviewboard: rbt post --username does not always authenticate properly

Updates: Status: Fixed Comment #1 on issue 3858 by bar...@beanbaginc.com: rbt post --username does not always authenticate properly https://code.google.com/p/reviewboard/issues/detail?id=3858 The fix for this issue has landed on the release-0.7.x and master branches as commit

Re: Issue 3857 in reviewboard: Problem with displaying java diffs of maven projects in clearcase

Updates: Status: NeedInfo Comment #2 on issue 3857 by trowb...@gmail.com: Problem with displaying java diffs of maven projects in clearcase https://code.google.com/p/reviewboard/issues/detail?id=3857 Is there a reason why you discarded the above-mentioned review request? -- You

Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied

Comment #6 on issue 3866 by trowb...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 You created your diff via `p4 diff`? Could you try with `rbt diff`? -- You received this message because this project is configured to

Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied

Updates: Status: NeedInfo Comment #1 on issue 3866 by trowb...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 It would be very helpful to see the patch file in question, not just the source file. -- You received

Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied

Comment #3 on issue 3866 by trowb...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 Hrmph, ok. I really don't know why `patch` would say that it's malformed. If you try applying that patch manually (by executing the patch

Re: Issue 3866 in reviewboard: mxml source file patches fail to get applied

Comment #5 on issue 3866 by kamaldee...@gmail.com: mxml source file patches fail to get applied https://code.google.com/p/reviewboard/issues/detail?id=3866 The generated diff file does not look correct. I use perforce. The edited lines are not in the patch at all. Maybe this is a p4 diff