Issue 624 in reviewboard: Can't add inline comments from diff view discussion tab

2008-10-06 Thread codesite-noreply

Issue 624: Can't add inline comments from diff view discussion tab
http://code.google.com/p/reviewboard/issues/detail?id=624

Comment #2 by chipx86:
My UI rewrite makes it a little more clear how to respond to a comment,  
which should
in a way satisfy this bug.

Essentially, existing comments will have Reply links, which will let you  
reply to
that comment. It's more clear that a new comment is in fact a new comment  
and not a
reply.


Issue attribute updates:
Status: Started
Owner: chipx86

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 495 in reviewboard: I want a To Me column in the Incoming reviews page

2008-10-06 Thread codesite-noreply

Issue 495: I want a To Me column in the Incoming reviews page
http://code.google.com/p/reviewboard/issues/detail?id=495

Comment #4 by trowbrds:
(No comment was entered for this change.)


Issue attribute updates:
Status: Confirmed

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 602 in reviewboard: Show the 'basedir' on the review request page

2008-10-06 Thread codesite-noreply

Issue 602: Show the 'basedir' on the review request page
http://code.google.com/p/reviewboard/issues/detail?id=602

Comment #2 by trowbrds:
I don't really think it's a useful piece of information. All it tells you  
is what
directory someone was in when they ran `svn diff` (or equivalent). This  
will usually
be trunk (or project-specific equivalent).

I think it's much better to just coach people into writing useful review
summaries/descriptions.



-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 682 in reviewboard: Cannot login after fresh install under apache http.

2008-10-06 Thread codesite-noreply

Issue 682: Cannot login after fresh install under apache http.
http://code.google.com/p/reviewboard/issues/detail?id=682

New issue report by [EMAIL PROTECTED]:
I tried the latest svn version and followed the wiki Getting Started
steps to install all necessary stuff. I setup reviewboard to work under
apache httpd. But I cannot login. I get the message cookies must be
enabled. My brwoser has cookies enabled and the following cookie is set
rbsessionid. Following the installation guide installed django version
1.1.0 alpha on my system.



Issue attributes:
Status: New
Owner: 
Labels: Type-Defect Priority-Medium

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 297 in reviewboard: Show selected diff chunk in a better way

2008-10-06 Thread codesite-noreply

Issue 297: Show selected diff chunk in a better way
http://code.google.com/p/reviewboard/issues/detail?id=297

Comment #5 by chipx86:
Got this working in my UI rewrite.


Issue attribute updates:
Status: Started
Owner: chipx86

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 401 in reviewboard: Comments should be inserted into diff below lines being discussed, instead of in dialog box

2008-10-06 Thread codesite-noreply

Issue 401: Comments should be inserted into diff below lines being  
discussed, instead of in dialog box
http://code.google.com/p/reviewboard/issues/detail?id=401

Comment #3 by chipx86:
Making the UIs configurable makes it a pain to maintain, document and  
support.

After careful consideration, I've decided not to go the inline route, as  
there's a
number of problems associated with it:

1) If you're reviewing a large number of lines, you have no way of seeing  
both the
text entry and the diff lines at the same time.

2) There's no good way of indicating which lines the comment is associated  
with. The
comment flags do a better job of this, and will do an even better job once  
they show
line ranges (soon).

3) People don't always want to just see the comments appear. We'd need a  
good way of
letting users show/hide all these, and that's even more unclear. Where do  
you go for
this? Top of the page? Have a floating window somewhere? It just seems to  
me that
it'll get in the way at times.

4) It'll appear even more like you're supposed to reply to comments by  
attaching a
new comment to a line. This is a problem we have today, where people try to  
use the
diff viewer to reply to reviews, which produces unexpected results. We  
don't want to
encourage this further.


What I am doing is revising the comment dialog to be smaller, appear below  
the
comment range at a better default position, and to make it a lot more clear  
how to
reply to existing comments and how to create new comments.

I'm hijacking this bug for the new design and will be closing when the  
change goes in.


Issue attribute updates:
Status: Started
Owner: chipx86
Labels: Milestone-Release1.0

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---



Issue 555 in reviewboard: multiple-line selection in a diff doesn't work when selecting upwards

2008-10-06 Thread codesite-noreply

Issue 555: multiple-line selection in a diff doesn't work when selecting  
upwards
http://code.google.com/p/reviewboard/issues/detail?id=555

Comment #3 by chipx86:
(No comment was entered for this change.)


Issue attribute updates:
Labels: Milestone-Release1.0 Usability Component-DiffViewer

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---