Issue 783 in reviewboard: Could a preference be added to disable animation?
Comment #4 on issue 783 by jamesdlin: Could a preference be added to disable animation? http://code.google.com/p/reviewboard/issues/detail?id=783 Okay, the fades over RDP aren't horrible, but it'd still be nice to disable them. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 719 in reviewboard: Ldap auth not working with AD
Comment #6 on issue 719 by bblough: Ldap auth not working with AD http://code.google.com/p/reviewboard/issues/detail?id=719 /poser/poster/ oops. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 719 in reviewboard: Ldap auth not working with AD
Comment #5 on issue 719 by bblough: Ldap auth not working with AD http://code.google.com/p/reviewboard/issues/detail?id=719 I'm not the original poser, but this patch fixes the issue in my environment. Thanks! -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 853 in reviewboard: RFE: Review status per-user
Comment #1 on issue 853 by jefflamb: RFE: Review status per-user http://code.google.com/p/reviewboard/issues/detail?id=853 Related to or duplicate of issue 396. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 396 in reviewboard: Whose 'court' the review in currently in?
Comment #8 on issue 396 by jefflamb: Whose 'court' the review in currently in? http://code.google.com/p/reviewboard/issues/detail?id=396 Yes, I am. It helps, but comes short. For example, look at this situation. I see a new update to a review, and it's a huge rewrite that's going to take some serious time to look over. I can't get to it right now, so I put it aside for later. (Maybe a "mark as unread" ability is needed to restore the new updates icon?) Now, do this once or twice and I can't trust the new updates icon anymore. I don't know the real status of anything. So I have to go through the entire list of reviews, which inevitably entails re-reading a lot of comments just to make sure I'm not inadvertently being lazy. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 396 in reviewboard: Whose 'court' the review in currently in?
Comment #9 on issue 396 by chipx86: Whose 'court' the review in currently in? http://code.google.com/p/reviewboard/issues/detail?id=396 Yeah. I definitely agree with you. I just wanted to make sure you weren't at least randomly reloading pages without knowing if anything changed or not :) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 853 in reviewboard: RFE: Review status per-user
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 853 by kbinco: RFE: Review status per-user http://code.google.com/p/reviewboard/issues/detail?id=853 As a developer, I would like to quickly determine who has looked at my code and filed comments against it at the top of the review so that I can see at a glance who has given me a ship-it on my code versus those who have not given me a ship-it (but commented on the code). Ex: * My Dashboard * New Review Request ... Summary: Command Line Prompt utility class Submitted Updated 2 days, 7 hours ago Submitter: Kevin BeReviewers Branch: trunk Groups: Core Bugs: People: Change Number: NoneRepository: Beatport Status: Ship-It John D... : [ ] _Latest_Comments_ Mary J... : [X] ... -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 852 in reviewboard: Add a non-diff source code view
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 852 by jefflamb: Add a non-diff source code view http://code.google.com/p/reviewboard/issues/detail?id=852 Sometimes a file is changed so much that the old revision just doesn't help any more. It'd be nice to just have the ability to look at the new file and make comments on it instead of having the antiquated file always hanging around on the left inserting huge chunks of blank lines in the file you're interested in. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 851 in reviewboard: RFE: Commit-It
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 851 by kbinco: RFE: Commit-It http://code.google.com/p/reviewboard/issues/detail?id=851 User story: As a reviewer, I need to be able to set different kinds of status on a review - Ship-it and commit-it in our case so that we can track two different levels of authorization - one from peers, one from QA. Commit-it is when a patch is deemed ready for commit to source control but has not been QA reviewed. Ship-it would mean that QA has reviewed the code and deems it ready for production release. The labels were chosen by others in my company. Personally, I prefer review?/+/- and approve?/+/- just like with Bugzilla. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 396 in reviewboard: Whose 'court' the review in currently in?
Comment #7 on issue 396 by chipx86: Whose 'court' the review in currently in? http://code.google.com/p/reviewboard/issues/detail?id=396 Thanks for the 2 cents Jeff :) I just wanted to address one thing real quick. You mentioned that you spend a lot of time looking at review requests to see if anything changed. Are you using the "New Updates" column to at least only open review requests that have had changes made? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 396 in reviewboard: Whose 'court' the review in currently in?
Comment #6 on issue 396 by jefflamb: Whose 'court' the review in currently in? http://code.google.com/p/reviewboard/issues/detail?id=396 Just throwing in my 2 cents for when someone gets around to implementing this, as this is one of the main annoyances I have with reviewboard. I spend a lot of time re-opening reviews to see what's happened. I think what people want is a "My next requested action" column. Calling it status would still work, but tailored to the next action would be best. The above comments address the issue for outgoing reviews. For incoming reviews, however, it'd be nice to see how the logged-in reviewer last addressed the review. Incoming statuses: "Review needed" "Draft review saved" "Review submitted, awaiting new diff" "Review submitted, marked as Ship It" Outgoing statuses: "Awaiting reviews" "Modifications requested, approved by N of N reviewers" "Approved by N of N reviewers" "Ready to submit" -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 838 in reviewboard: It's impossible to type certain letters (e.g. 'a' and 'A') into Summary and Description fields when diffviewer is active
Comment #6 on issue 838 by chipx86: It's impossible to type certain letters (e.g. 'a' and 'A') into Summary and Description fields when diffviewer is active http://code.google.com/p/reviewboard/issues/detail?id=838 Issue 850 has been merged into this issue. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 850 in reviewboard: Viewing the diff during a diff upload opens the comment box but activates keyboard navigation
Updates: Status: Duplicate Mergedinto: 838 Comment #2 on issue 850 by chipx86: Viewing the diff during a diff upload opens the comment box but activates keyboard navigation http://code.google.com/p/reviewboard/issues/detail?id=850 Yeah, you'll want to upgrade to 1.0 alpha 2. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 850 in reviewboard: Viewing the diff during a diff upload opens the comment box but activates keyboard navigation
Comment #1 on issue 850 by ch...@orr.me.uk: Viewing the diff during a diff upload opens the comment box but activates keyboard navigation http://code.google.com/p/reviewboard/issues/detail?id=850 This was fixed yesterday in issue 838. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 850 in reviewboard: Viewing the diff during a diff upload opens the comment box but activates keyboard navigation
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 850 by cwainb: Viewing the diff during a diff upload opens the comment box but activates keyboard navigation http://code.google.com/p/reviewboard/issues/detail?id=850 *NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? reviewboardUrl/r/reviewNumber/diff/#indexheader What steps will reproduce the problem? 1. upload a new diff to an existing review using post-review 2. click on View Diff 3. Type a comment including the letter n or a in the Review Request Change Description box What is the expected output? What do you see instead? I expect to see the comment in the box, but instead the page jumps to the next diff What operating system are you using? What browser? Windows XP Firefox Please provide any additional information below. Reviewboard 1.0alpha2.dev_20090203 This occurs if nothing was typed into the comment box before clicking view diff, if something was typed but Ok was not clicked, and if something was typed and Ok was clicked. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 772 in reviewboard: Lines of all whitespace should be ignored when creating diffs
Comment #2 on issue 772 by kyle.getz: Lines of all whitespace should be ignored when creating diffs http://code.google.com/p/reviewboard/issues/detail?id=772 Sure, that's fine. If you wanted to add a bit more concreteness to the rule, it could go something like: Lines containing all whitespace are OK, as long as the line is not indented further than the line above. If the line is indented further than the line above, then those extra spaces are marked in red. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 676 in reviewboard: post-review fails when uploading diff
Updates: Status: NeedInfo Comment #1 on issue 676 by chipx86: post-review fails when uploading diff http://code.google.com/p/reviewboard/issues/detail?id=676 Sorry, I know this is a bit old, but do you still have a good repro case for this and can give an example of the newline issue? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 665 in reviewboard: Link to diff between revisions is broken
Updates: Status: Fixed Comment #2 on issue 665 by chipx86: Link to diff between revisions is broken http://code.google.com/p/reviewboard/issues/detail?id=665 This should be fixed now. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
