Issue 1652 in reviewboard: Set permissions to view review requests

2010-05-17 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 1652 by vera1171: Set permissions to view review requests
http://code.google.com/p/reviewboard/issues/detail?id=1652

*NOTE: If you have a patch, please submit it to
http://reviews.reviewboard.org/


What version are you running?
1.0.8

What's the URL of the page this enhancement relates to, if any?
dashboard

Describe the enhancement and the motivation for it.
Now,we can visit all review requests and all the changed code through the
tabAll review requests.This is not security for the code.Sometimes, we
just want to specify persons who have the permission to view specified
request.

What operating system are you using? What browser?
Windows XP SP2.FireFox.

Please provide any additional information below.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1653 in reviewboard: post-review polls all svn repositories

2010-05-17 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 1653 by AaronJSherman: post-review polls all svn repositories
http://code.google.com/p/reviewboard/issues/detail?id=1653

What version are you running? tested on several versions, latest was
RBTools 0.2 against reviewboard 1.0.8.


What's the URL of the page containing the problem? N/A


What steps will reproduce the problem?
1. Add an svn repo to reviewboard
2. Add a second svn repo to reviewboard
3. Check out the second repo
4. Make a change
5. Set .reviewboardrc if needed
6. post-review

If you watch the logs while you do this, you will see that the first
repository is polled before contacting the second. I understand that svn
info doesn't always give you the same URL as the one that was inserted
into reviewboard's configuration (e.g. if someone checked out locally or
via a different protocol). However, when the two do match, polling each
repository exposes the user to failure modes that have nothing to do with
the repository that they are trying to use.

I would think that the correct solution is to try to match the svn info URL
against the list of repositories without polling them, and then to poll the
repositories if more information is needed to make the match.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 994 in reviewboard: Description text for the Base Diff Path: field

2010-05-17 Thread reviewboard


Comment #3 on issue 994 by chipx86: Description text for the Base Diff  
Path: field

http://code.google.com/p/reviewboard/issues/detail?id=994

It's definitely confusing. I wish we didn't have to ask users for it but we  
do. This is why we recommend

post-review.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1589 in reviewboard: Review board doesn't display diffs which contain deleted files properly for Mercurial

2010-05-17 Thread reviewboard

Updates:
Status: Fixed

Comment #2 on issue 1589 by chipx86: Review board doesn't display diffs  
which contain deleted files properly for Mercurial

http://code.google.com/p/reviewboard/issues/detail?id=1589

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.