Issue 2482 in reviewboard: error message refers user to non-existent URL

2012-02-10 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 2482 by dlanz...@gmail.com: error message refers user to  
non-existent URL

http://code.google.com/p/reviewboard/issues/detail?id=2482

* NOTE: Do not post confidential information in this bug report. *
*   If you need immediate support, please contact*
*   reviewbo...@googlegroups.com *

What version are you running?

1.5


What's the URL of the page containing the problem?
none


What steps will reproduce the problem?
1.attempt to use post-review in our system
2.error creating review request - repository path is not known
3.error states for information on adding repositories, please read  
http://www.reviewboard.org/docs/manual/dev/admin/management/repositories/
(we have solved the problem leading to the error - the problem is the error  
message is misleading)


What is the expected output? What do you see instead?
That url is 404.

What operating system are you using? What browser?
SLES 12
Firefox

Please provide any additional information below.

Note also that a search from the front page (www.reviewboard.org) for
repositories in the documentation produces no results.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2473 in reviewboard: post-review fails on a specific file with error 207

2012-02-10 Thread reviewboard


Comment #3 on issue 2473 by kyle.g...@gmail.com: post-review fails on a  
specific file with error 207

http://code.google.com/p/reviewboard/issues/detail?id=2473


svn info
repository info: Path: svn://svn/mgmt-fwk, Base path: /trunk, Supports  
changesets: False

svn diff --diff-cmd=diff framework/src/bin/web2/python/JSONContent.py
svn info framework/src/bin/web2/python/JSONContent.py
svn info framework/src/bin/web2/python/JSONContent.py
svn info framework/src/bin/web2/python/JSONContent.py
svn info framework/src/bin/web2/python/JSONContent.py
Looking for 'review.lab.nbttech.com /' cookie in  
/u/kgetz/.post-review-cookies.txt

Loaded valid cookie -- no login required
Attempting to create review request for None
HTTP GETting /api/json/repositories/
HTTP GETting /api/json/repositories/1/info/
HTTP GETting /api/json/repositories/2/info/
repository info: Path: svn://svn/mgmt, Base path: /trunk, Supports  
changesets: False
HTTP POSTing to  
https://review.lab.nbttech.com/api/json/reviewrequests/new/:  
{'repository_path': u'svn://svn/mgmt'}

Review request created
Uploading diff, size: 465
HTTP POSTing to  
https://review.lab.nbttech.com/api/json/reviewrequests/47036/diff/new/:  
{'basedir': '/trunk'}

Error uploading diff: The file was not found in the repository (207)
{u'stat': u'fail', u'file':  
u'/trunk/framework/src/bin/web2/python/JSONContent.py', u'err':  
{u'msg': u'The file was not found in the repository', u'code': 207},  
u'revision': u'94755'}

Your review request still exists, but the diff is not attached.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2426 in reviewboard: ReviewRequest.changeset_is_pending() is unreliable

2012-02-10 Thread reviewboard

Updates:
Status: Fixed

Comment #2 on issue 2426 by trowb...@gmail.com:  
ReviewRequest.changeset_is_pending() is unreliable

http://code.google.com/p/reviewboard/issues/detail?id=2426

Fixed in master (cefd1ea). Thanks!

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2482 in reviewboard: error message refers user to non-existent URL

2012-02-10 Thread reviewboard

Updates:
Status: Fixed

Comment #1 on issue 2482 by trowb...@gmail.com: error message refers user  
to non-existent URL

http://code.google.com/p/reviewboard/issues/detail?id=2482

Fixed in master (6d524dd). Thanks!

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2473 in reviewboard: post-review fails on a specific file with error 207

2012-02-10 Thread reviewboard


Comment #4 on issue 2473 by kyle.g...@gmail.com: post-review fails on a  
specific file with error 207

http://code.google.com/p/reviewboard/issues/detail?id=2473

Ah, I see a problem in the debug output that would explain this.  This  
particular file is in the 'mgmt-fwk' repository, as you can see in the  
second line:


repository info: Path: svn://svn/mgmt-fwk, Base path: /trunk, Supports  
changesets: False


However, later on, post-review thinks that the file is in the 'mgmt'  
repository, which is wrong:


repository info: Path: svn://svn/mgmt, Base path: /trunk, Supports  
changesets: False
HTTP POSTing to  
https://review.lab.nbttech.com/api/json/reviewrequests/new/:  
{'repository_path': u'svn://svn/mgmt'}


This would explain some other behavior I've seen too: when I submit code  
reviews for files in the 'mgmt-fwk' repository, Review Board says the  
repository is 'mgmt'.  What could cause this misidentification?


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 2483 in reviewboard: Minor tweak to review request email notification template to include repository name along with review group

2012-02-10 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 2483 by gaz...@gmail.com: Minor tweak to review request email  
notification template to include repository name along with review group

http://code.google.com/p/reviewboard/issues/detail?id=2483

Version:  1.6.3
OS: RHEL 5.7
Browser:  Chrome, Firefox  (not relevant in this case)


I patched the  
reviewboard/templates/notifications/review_request_email.{html,txt} files  
in our deployment to include the related repository name, such as in the  
following line:


  divReview request for {% reviewer_list review_request %}  
({{review_request.repository.name}})./div


This is useful for anyone who ever shares review groups across multiple  
repositories.  In our case, we have several dozen related small repos that  
all share a single review group, and we found it often difficult to  
differentiate one from another in the review request emails.  We would  
previously need to actually view the review request in order to find the  
repository name.  I realize that creating/managing distinctly named review  
groups for every repository would avoid needing to add this info to the  
notification, but we have found it simpler to maintain a smaller number of  
review groups.


I found a rejected enhancement request for more formal template  
customization support.  So, I simply modified the template files directly  
and thought I'd submit this suggestion for the minor tweak so that I won't  
need to patch after each upgrade (and also because I suspect this might be  
generally useful).


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2478 in reviewboard: Web Service API 2.0 doesn't allow creating Review Group?

2012-02-10 Thread reviewboard


Comment #4 on issue 2478 by eyuw...@gmail.com: Web Service API 2.0 doesn't  
allow creating Review Group?

http://code.google.com/p/reviewboard/issues/detail?id=2478

Hi,

I read through the release notes on 'API Changes' for 1.6.2 and 1.6.3. I  
didn't see any mention of adding support 'POST' method?? I then checked out  
the bleeding edge version, it looks like only support for 'DELETE' is added  
between version 1.6.1 and the bleeding edge, which is also stated in the  
release notes for 1.6.2


From webapi/resources.py in version 1.6.1:
class ReviewGroupResource: allowed_methods = ('GET',)

From webapi/resources.py in bleeding edge version:
class ReviewGroupResource: allowed_methods = ('GET', 'DELETE')

Am I looking at wrong class?




--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.