Re: Issue 1395 in reviewboard: Exporting review comments

2014-04-30 Thread reviewboard


Comment #9 on issue 1395 by magnus.h...@gmail.com: Exporting review comments
http://code.google.com/p/reviewboard/issues/detail?id=1395

Bumping this feature. Would be very useful for certification assessments in  
order to provide evidence that code reviews really have been performed  
without providing access to the repository.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 1950 in reviewboard: Exporting reviews to external file

2014-04-30 Thread reviewboard


Comment #3 on issue 1950 by magnus.h...@gmail.com: Exporting reviews to  
external file

http://code.google.com/p/reviewboard/issues/detail?id=1950

Bumping this feature.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3320 in reviewboard: rbt with --include for multiple directories/files doesn't seem to work

2014-04-30 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3320 by tph...@gmail.com: rbt with --include for multiple  
directories/files doesn't seem to work

http://code.google.com/p/reviewboard/issues/detail?id=3320

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
rejected.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!
This is for with SVN repo. post-review used to allow multiple directories  
with

$ post-review dir1 [dir2]

Not working with rbt:
$ rbt --include dir1 --include dir2

The problem seem to be indentation problem on  
line diff_cmd.extend(files). Un-indent seems to fixed it.



What version are you running?
RB 1.7.16, rbt 0.6

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. rbt --debug --include dir1 --include dir2


What is the expected output? What do you see instead?

Running: svn diff --diff-cmd=diff --notice-ancestry -r BASE

rbtools.commands.CommandError: There don't seem to be any diffs!


What operating system are you using? What browser?
Centos 6.4


Please provide any additional information below.

Patch:
--- rbtools/clients/svn.py  2014-04-07 15:21:06.0 -0700
+++ rbtools/clients/svn.py-modified 2014-04-30 13:54:24.0 -0700
@@ -255,7 +255,7 @@
 # Working copy--do a normal range diff
 diff_cmd.extend(['-r', '%s:%s' % (base, tip)])

-diff_cmd.extend(files)
+diff_cmd.extend(files)

 if self.history_scheduled_with_commit(changelist):
 svn_show_copies_as_adds = getattr(



--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3320 in reviewboard: rbt with --include for multiple directories/files doesn't seem to work

2014-04-30 Thread reviewboard

Updates:
Status: Fixed

Comment #1 on issue 3320 by trowb...@gmail.com: rbt with --include for  
multiple directories/files doesn't seem to work

http://code.google.com/p/reviewboard/issues/detail?id=3320

This is already fixed in git (1cb1c32) and will ship with 0.6.1.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.