Re: Issue 3312 in reviewboard: Diffs without embedded commit IDs can not be used
Comment #2 on issue 3312 by george.m...@gmail.com: Diffs without embedded commit IDs can not be used http://code.google.com/p/reviewboard/issues/detail?id=3312 Unfortunately I'm not using RBTools, I talk directly to Web API. I've looked into how this is handled by RBTools and I couldn't find anything - just some bits for handling empty files, but that doesn't seem relevant. I've also checked this bug against the latest master (9469487cff4e6e1353080581f808cd0f43a39a0d) and it's still there. Maybe I misunderstood how base_commit_id should work, so I've posted the question on mailing list (pending moderation). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3401 in reviewboard: Repository listing shows commits not belonging to the chosen branch
Comment #4 on issue 3401 by pmonteag...@benunets.com: Repository listing shows commits not belonging to the chosen branch http://code.google.com/p/reviewboard/issues/detail?id=3401 We're using pysvn. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3410 in reviewboard: perforce post-submit review fails using rbt post when the submitted change set contains branch actions
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3410 by puremour...@gmail.com: perforce post-submit review fails
using rbt post when the submitted change set contains branch actions
http://code.google.com/p/reviewboard/issues/detail?id=3410
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.
What version are you running?
RBTools-0.6-py2.6.egg
What's the URL of the page containing the problem?
n/a
What steps will reproduce the problem?
1. using perforce, add a new file (p4 add myfile; p4 submit) (change #1)
2. branch the file, p4 integ myfile myfile2 (or whatever); p4 submit
(change #2)
3. rbt post 2
What is the expected output? What do you see instead?
Expected: A review is created and the diff submitted.
Observed: CRITICAL: Unsupported action type branch for myfile2
What operating system are you using? What browser?
submitting from RHEL Linux 5.5; browser - any.
Please provide any additional information below.
This appears to be due to the following in clients/perforce.py (around line
644, in method _compute_range_changes:
if action not in ('edit', 'integrate', 'add', 'delete',
'move/add', 'move/delete'):
raise Exception('Unsupported action type %s for %s' %
(action, depot_file))
if action == 'integrate':
action = 'edit'
elif action == 'branch':
action = 'add'
Locally we have resolved the issue (successfully submitting the review)
with the following naive change, replacing the above with:
if action == 'integrate':
action = 'edit'
elif action == 'branch':
action = 'add'
if action not in ('edit', 'add', 'delete',
'move/add', 'move/delete'):
raise Exception('Unsupported action type %s for %s' %
(action, depot_file))
complete output of example:
$ tools/tempecho data a_file_please_ignore
$ tools/tempp4 add a_file_please_ignore
//depot/snip/a_file_please_ignore#1 - opened for add
$ tools/tempp4 submit a_file_please_ignore
Change 1205953 created with 1 open file(s).
Submitting change 1205953.
Locking 1 files ...
Change 1205953 submitted.
$ tools/tempp4 integ a_file_please_ignore a_file_please_ignore.2
//depot/snip/a_file_please_ignore.2#1 - branch/sync from
//depot/snip/a_file_please_ignore#1
$ tools/tempp4 submit a_file_please_ignore.2
Change 1205956 created with 1 open file(s).
Submitting change 1205956.
Locking 1 files ...
branch //depot/snip/a_file_please_ignore.2#1
Change 1205956 submitted.
$ tools/temprbt post 1205956
ERROR: Could not load SCM Client svn: No module named etree
ERROR: Could not load SCM Client git: No module named etree
ERROR: Could not load SCM Client mercurial: No module named uuid
Generating diff for range of submitted changes: 1205955 to 1205956
CRITICAL: Unsupported action type branch for
//depot/snip/a_file_please_ignore.2
with the naive fix:
$ tools/temprbt post 1205956
ERROR: Could not load SCM Client svn: No module named etree
ERROR: Could not load SCM Client git: No module named etree
ERROR: Could not load SCM Client mercurial: No module named uuid
Generating diff for range of submitted changes: 1205955 to 1205956
Review request #1421 posted.
...
Draft diff
This diff is part of your current draft. Other users will not see this diff
until you publish your draft.
Files Changed:
//depot/snip/a_file_please_ignore.2: 1 change [ new content ]
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Re: Issue 3083 in reviewboard: 500 error on first login due to profile not being created.
Comment #6 on issue 3083 by a...@brookmoor.com: 500 error on first login due to profile not being created. http://code.google.com/p/reviewboard/issues/detail?id=3083 I am seeing this exact same issue with 1.7.25. What version was this fixed in? It would be good to add that info here if possible and a link to the specific commit would be super. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3411 in reviewboard: favicon not shown in diff view
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3411 by matthias...@famsik.de: favicon not shown in diff view http://code.google.com/p/reviewboard/issues/detail?id=3411 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? RB 2.0.1 Watch a review request, e.g. https://reviews.reviewboard.org/r/5964/ , favicon is properly shown. When you now click on View Diff (= https://reviews.reviewboard.org/r/5964/diff/# ), the favicon is suddenly gone/none is displayed. Firefox 29.0.1, linux -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3083 in reviewboard: 500 error on first login due to profile not being created.
Comment #7 on issue 3083 by trowb...@gmail.com: 500 error on first login due to profile not being created. http://code.google.com/p/reviewboard/issues/detail?id=3083 This is fixed in the 2.0 releases. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3411 in reviewboard: favicon not shown in diff view
Updates: Status: Confirmed Comment #1 on issue 3411 by chip...@gmail.com: favicon not shown in diff view http://code.google.com/p/reviewboard/issues/detail?id=3411 Very weird. We have the same HTML linking to the favicon on both pages. I think this happens only when our Backbone routers get involved. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3412 in reviewboard: Group name and description overlap in autocomplete box
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3412 by bruce.c...@gmail.com: Group name and description overlap in autocomplete box http://code.google.com/p/reviewboard/issues/detail?id=3412 What version are you running? 2.0.1 What's the URL of the page containing the problem? https://reviews/r/40745/ What steps will reproduce the problem? 1. Create a review group with a name of more than around 25 characters and an equally long description. 2. Start typing the group name in the Groups field of a review. What is the expected output? What do you see instead? The autocomplete box should be big enough to contain all the text, or truncate the description. Instead, the end of the group name overlaps with the start of the description. What operating system are you using? What browser? Windows 8.1 and Firefox 30. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3413 in reviewboard: Uploading invalid diff to existing review results in Loading... hang
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3413 by bruce.c...@gmail.com: Uploading invalid diff to existing review results in Loading... hang http://code.google.com/p/reviewboard/issues/detail?id=3413 What version are you running? 2.0.1 What's the URL of the page containing the problem? https://reviews/r/1234 What steps will reproduce the problem? 1. Create a new, valid review. 2. Select Update - Update Diff 3. Select a diff which doesn't apply (wrong repository, source revision doesn't exist etc.) What is the expected output? What do you see instead? An error should be displayed. Instead, the 'Loading...' spinner appears and never stops. If an attempt is made to create a *new* review using the diff, the expected error message is displayed. What operating system are you using? What browser? Windows 8.1 and Firefox 30. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3413 in reviewboard: Uploading invalid diff to existing review results in Loading... hang
Comment #1 on issue 3413 by abhishek.mukher.g: Uploading invalid diff to existing review results in Loading... hang http://code.google.com/p/reviewboard/issues/detail?id=3413 We're experiencing similar problems. If you open the network inspector in chrome you can see that the response comes back as a 400 correctly so it's in the javascript -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3401 in reviewboard: Repository listing shows commits not belonging to the chosen branch
Updates: Status: Started Owner: chip...@gmail.com Comment #5 on issue 3401 by chip...@gmail.com: Repository listing shows commits not belonging to the chosen branch http://code.google.com/p/reviewboard/issues/detail?id=3401 (No comment was entered for this change.) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3413 in reviewboard: Uploading invalid diff to existing review results in Loading... hang
Comment #2 on issue 3413 by bruce.c...@gmail.com: Uploading invalid diff to
existing review results in Loading... hang
http://code.google.com/p/reviewboard/issues/detail?id=3413
I wonder if this is at all related to
https://code.google.com/p/reviewboard/issues/detail?id=3338 ('Upload Diff'
allows user to click button without choosing diffs)? I noticed the fix
didn't make it into version 2.0.1.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
