Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 What version are you running? 2.0.7 What's the URL of the page containing the problem? http://server/r/new/ What steps will reproduce the problem? 1.Create a patch file that contains a new file been created with utf-8 encoding that contains a BOM in the file, or contains any modification related with the first line of a file that has BOM 2.Upload the patch to the reviewboard What is the expected output? What do you see instead? Expected: Review can be created Actual: Reviewboard always showing loading but never finish. What operating system are you using? What browser? Win 8.1, tried IE9/Firefox 32.0.2/Chrome 37.0.2062.120 m Please provide any additional information below. If we manually remove the BOM from the patch file a review can be created with no problem. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #1 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Are there any errors in the server's log file? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Updates: Status: NeedInfo Comment #2 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Also, what repository type? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #3 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 repository type is svn I can see an error report Email sent from server: Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/Django-1.6.7-py2.7.egg/django/core/handlers/base.py, line 112, in get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File /usr/local/lib/python2.7/dist-packages/Django-1.6.7-py2.7.egg/django/views/decorators/cache.py, line 52, in _wrapped_view_func response = view_func(request, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Django-1.6.7-py2.7.egg/django/views/decorators/vary.py, line 19, in inner_func response = func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/webapi/resources.py, line 495, in __call__ request, method, view, api_format=api_format, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/webapi/resources.py, line 566, in call_method_view return view(request, *args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/webapi/decorators.py, line 117, in _call return view_func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.7-py2.7.egg/reviewboard/webapi/decorators.py, line 110, in _check return view_func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/webapi/decorators.py, line 117, in _call return view_func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.7-py2.7.egg/reviewboard/webapi/decorators.py, line 33, in _check return view_func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/webapi/decorators.py, line 117, in _call return view_func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/webapi/decorators.py, line 117, in _call return view_func(*args, **kwargs) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/webapi/decorators.py, line 287, in _validate return view_func(*args, **new_kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.7-py2.7.egg/reviewboard/webapi/resources/repository_commits.py, line 86, in get items = repository.get_commits(branch=branch, start=start) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.7-py2.7.egg/reviewboard/scmtools/models.py, line 366, in get_commits cache_period) File /usr/local/lib/python2.7/dist-packages/Djblets-0.8.10-py2.7.egg/djblets/cache/backend.py, line 120, in cache_memoize data = lookup_callable() File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.7-py2.7.egg/reviewboard/scmtools/models.py, line 351, in lambda lambda: self.get_scmtool().get_commits(**commits_kwargs) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.7-py2.7.egg/reviewboard/scmtools/svn/__init__.py, line 195, in get_commits commit['message'])) File /usr/lib/python2.7/UserDict.py, line 23, in __getitem__ raise KeyError(key) KeyError: u'message' -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #4 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Double checked the error in the log is the same as I got from Email, no further message can be seen -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #5 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 OK, that's definitely something we'll get fixed, but I'm not sure it's causing your problem. Can you look in the browser's Network console while uploading the file and check the request/reponses there for errors? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #6 on issue 3579 by simonwa...@gmail.com: patch file contains BOM
can't be uploaded
https://code.google.com/p/reviewboard/issues/detail?id=3579
Looks like a Javscript error:
TypeError: rsp is null
in http://servername/static/rb/js/newReviewRequest.min.4427138a3b1f.js
Code is where it try to parse error code:
switch(rsp.err.code) {
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #7 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Can you look in the network tab of the browser tools to find the response that's creating that error? It's probably a 500. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #8 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Sorry I didn't mention it clear here, I can see no network traffic at all after I click OK, it looks JS crashed before that. I tried using both Firebug and Fiddler. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #10 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 And/or any POSTS to validate-diff/ or diffs/ -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #11 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Sorry no 500 error, there are some others after I chose Repository but all 200 normal request which I also believed is for Post-Commit review as the result is a revision history. Only thing after that is the JS error, nothing else -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #12 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Can you show me the responses to any POSTs (successful or not) to /api/validation/diffs/ or /api/review-requests/XX/diffs/? -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #13 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Sorry in this failed case there is no post to /api/validation/diffs/ or /api/review-requests/XX/diffs/ at all. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Updates: Status: PendingReview Owner: trowb...@gmail.com Comment #14 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 OK, I have a reproduction case. We'll get this fixed for 2.0.8, which should come out today. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Updates: Status: Fixed Comment #15 on issue 3579 by trowb...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Fixed in release-2.0.x (e7e671a). Thanks for all your help! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3579 in reviewboard: patch file contains BOM can't be uploaded
Comment #16 on issue 3579 by simonwa...@gmail.com: patch file contains BOM can't be uploaded https://code.google.com/p/reviewboard/issues/detail?id=3579 Thank you for your quick fix, looking forward to the upgrade. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3580 in reviewboard: IssueOpened checkbox status is not loaded correctly when opening that comment dialog the 1st time after page loading
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3580 by oswi...@gmail.com: IssueOpened checkbox status is not loaded correctly when opening that comment dialog the 1st time after page loading https://code.google.com/p/reviewboard/issues/detail?id=3580 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? 2.1 alpha 0 (dev) What's the URL of the page containing the problem? http://demo.reviewboard.org/r/13/diff/ What steps will reproduce the problem? 1. In the View Diff page, click one line in diff content to open one comment dialog 2. Create one comment WITHOUT issue opened 3. Reload that view diff page 4. Click the flag of that comment we just created, you could see the IssueOpened checkbox is checked in the dialog 5. Close the dialog and reopen it again 6. This time the checked status is OK What is the expected output? What do you see instead? It should be unchecked for such comment What operating system are you using? What browser? winxp,rh6. firefox 32 Please provide any additional information below. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
