Re: Issue 3609 in reviewboard: Error displaying diff, wrapping index char traceback
Comment #2 on issue 3609 by dan.schw...@gmail.com: Error displaying diff, wrapping index char traceback https://code.google.com/p/reviewboard/issues/detail?id=3609 Hi, We've encountered this issue too and I believe I've discovered the root cause (at least in our case). The ingredients are the following: 1. File contains a lot of lines with 0x0c (form feed - many vendor files include this for whatever reason) 2. Diff occurs late in the file (with some experimentation I could quantify this precisely - you'll see why in minute) 3. Diff is whitespace only The root cause are the 0x0c's. The ReviewBoard diff viewer mistakenly counts these as two lines whereas other tools (svn diff, vim, etc) count them as one. As a result when the diff view applies the patch (which it seems to do correctly) it positions the view at the wrong line. The further into the file it is - depending on how many 0x0c's are in the file - the further the view is skewed. In our case the breaking point was somewhere are 18. Meaning that after 18 0x0c's were encountered it was skewed far enough that, if the diff is whitespace only - we see the error in the bug. If the diff is NOT whitespace only there is no error, but the viewer takes you to the wrong line and the changes are not highlighted. I hope this helps. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3609 in reviewboard: Error displaying diff, wrapping index char traceback
Comment #3 on issue 3609 by dan.schw...@gmail.com: Error displaying diff, wrapping index char traceback https://code.google.com/p/reviewboard/issues/detail?id=3609 Hi, We've encountered this issue too and I believe I've discovered the root cause (at least in our case). The ingredients are the following: 1. File contains a lot of lines with 0x0c (form feed - many vendor files include this for whatever reason) 2. Diff occurs late in the file (with some experimentation I could quantify this precisely - you'll see why in minute) 3. Diff is whitespace only The root cause are the 0x0c's. The ReviewBoard diff viewer mistakenly counts these as two lines whereas other tools (svn diff, vim, etc) count them as one. As a result when the diff viewer applies the patch (which it seems to do correctly) it positions the view at the wrong line. The further into the file it is - depending on how many 0x0c's are in the file - the further the view is skewed. In our case the breaking point was somewhere around 18. Meaning that after 18 0x0c's were encountered it was skewed far enough that, if the diff is whitespace only - we see the error in the bug. If the diff is NOT whitespace only there is no error, but the viewer takes you to the wrong line and the changes are not highlighted. I hope this helps. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3609 in reviewboard: Error displaying diff, wrapping index char traceback
Comment #4 on issue 3609 by dan.schw...@gmail.com: Error displaying diff, wrapping index char traceback https://code.google.com/p/reviewboard/issues/detail?id=3609 Hi, We've encountered this issue too and I believe I've discovered the root cause (at least in our case). The ingredients are the following: 1. File contains a lot of lines with 0x0c (form feed - many vendor files include this for whatever reason) 2. Diff occurs late in the file (with some experimentation I could quantify this precisely - you'll see why in minute) 3. Diff is whitespace only The root cause are the 0x0c's. The ReviewBoard diff viewer mistakenly counts these as two lines whereas other tools (svn diff, vim, etc) count them as one. As a result when the diff viewer applies the patch (which it seems to do correctly) it positions the view at the wrong line. The further into the file it is - depending on how many 0x0c's are in the file - the further the view is skewed. In our case the breaking point was somewhere around 18. Meaning that after 18 0x0c's were encountered it was skewed far enough that, if the diff is whitespace only - we see the error in the bug report. If the diff is NOT whitespace only there is no error, but the viewer takes you to the wrong line and the changes are not highlighted. I hope this helps. PS: apologies for multiple add/deletes of this comment - I didn't see a way to edit for typos after I've posted -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3609 in reviewboard: Error displaying diff, wrapping index char traceback
Comment #5 on issue 3609 by dan.schw...@gmail.com: Error displaying diff, wrapping index char traceback https://code.google.com/p/reviewboard/issues/detail?id=3609 To follow-up: it appears the 0x0c (^L) issue has been previously reported in bug #2980. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 2980 in reviewboard: Diff viewer has problems with control characters
Comment #5 on issue 2980 by dan.schw...@gmail.com: Diff viewer has problems with control characters https://code.google.com/p/reviewboard/issues/detail?id=2980 I believe this issue is the root cause of bug 3609. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3683 in reviewboard: Adding P4 repo with path provokes global name 'P4Exception' is not defined
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3683 by craig.em...@citrix.com: Adding P4 repo with path provokes global name 'P4Exception' is not defined https://code.google.com/p/reviewboard/issues/detail?id=3683 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? 2.0.11 What's the URL of the page containing the problem? https://rb.xs.citrite.net/admin/db/scmtools/repository/252/ What steps will reproduce the problem? 1. Add a Perforce repo including a path 2. Save 3. - Red error box global name 'P4Exception' is not defined What is the expected output? What do you see instead? Repo added What operating system are you using? What browser? Debian for the server, Google Chrome in Ubuntu Please provide any additional information below. I could add the repo when it was just an IP address:port no But appending /path made it bork I've got Python 2.6.6 and P4PythonInstaller 0.3 and p4.exe 2014.2/962050 (Linux 2.6 x64) -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
