Re: Issue 3719 in reviewboard: 2.0.12 fails to render tables in Markdown according to the Markdown reference guide
Comment #1 on issue 3719 by ran...@circularreasoning.com: 2.0.12 fails to render tables in Markdown according to the Markdown reference guide https://code.google.com/p/reviewboard/issues/detail?id=3719 I'm seeing this as well in 2.0.13. Server is linux. I'm running Firefox 38.0.5 in Windows 7 64 bit. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3895 in reviewboard: UnicodeDecodeError when posting reviews
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3895 by ali.kam...@visiercorp.com: UnicodeDecodeError when
posting reviews
https://code.google.com/p/reviewboard/issues/detail?id=3895
*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.
What version are you running?
RBTools 0.7.3
What's the URL of the page containing the problem?
http://reviews.internal
What steps will reproduce the problem?
1. Setup a mercurial repository with two committed files: fileA and fileB.
Make sure fileA and fileB have some contents.
2. Remove fileA from the repository
3. Edit fileB and add a unicode copy right symbol:
//
// Copyright © [2010-2015] ...
//
4. Add a new *empty* file to the repository: fileC
4. Run rbt post
What is the expected output? What do you see instead?
I expect a review request to be posted, instead I get this error from rbt:
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 476:
ordinal not in range(128)
What operating system are you using? What browser?
Windows 7, Mercurial 3.4.1
Please provide any additional information below.
When a new empty file is added rbt tries to add a custom string to the diff
so that the review contains the fact that a new empty file has been added:
mercurial.py:
for filename in added_empty_files:
if filename not in exclude_files:
diff += ('diff -r %s -r %s %s\n' ...
The problem is the left hand side (diff) is a unicode string in this case
because of the copyright symbol. Python generates a UnicodeDecodeError if
the right encoding is not set.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
Issue 3896 in reviewboard: rss feed is broken
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3896 by thieu...@hotmail.com: rss feed is broken https://code.google.com/p/reviewboard/issues/detail?id=3896 What version are you running? 2.0.17 What's the URL of the page containing the problem? /admin/ and http://feeds.feedburner.com/ReviewBoardNews What steps will reproduce the problem? 1. Go to news page https://www.reviewboard.org/news/ . Latest news are displayed. 2. Got to admin page or rss feed page. The latest news displayed is Review Board 2.0.13 is released What is the expected output? What do you see instead? The rss feed shoud provide the latest news. What operating system are you using? What browser? Server installed on Ubuntu, tested with Chrome / IE. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3894 in reviewboard: When using mercurial empty files are included in all posted reviews
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3894 by ali.kam...@visiercorp.com: When using mercurial empty files are included in all posted reviews https://code.google.com/p/reviewboard/issues/detail?id=3894 *** READ THIS BEFORE POSTING! *** *** You must complete this form in its entirety, or your bug report will be *** rejected. *** *** If you have a security issue to report, please send it confidentially to *** secur...@reviewboard.org. Posting security-related issues to this bug *** tracker causes us to have to do an emergency release. *** *** For customer support, please post to reviewbo...@googlegroups.com *** *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** This bug tracker is public. Please check that any logs or other information *** that you include has been stripped of confidential information. What version are you running? RBTools 0.7.3 What's the URL of the page containing the problem? http://reviews.internal What steps will reproduce the problem? 1. Create a mercurial repository with three committed files, fileA, fileB, and fileC. fileA and fileB must have some content, fileC must be empty. 2. Remove fileA. Edit contents of fileB. 3. rbt post What is the expected output? What do you see instead? I expected the posted review to only contain fileA and fileB. The posted review contains fileC as well. What operating system are you using? What browser? Windows 7, Mercurial 3.4.1 Please provide any additional information below. The problem is RBT tries to locate newly added empty files by running two commands: base_files = hg locate -r base tip_empty_files = hg locate -r tip set:size(0) newly_added_empty_files = tip_empty_files - base_files In Windows hg locate -r base returns the following: folder1/subfolder1/fileA.txt folder2/subfolder2/fileB.txt folder1/subfolder3/fileC.txt where as hg locate -r tip set:size(0) returns: folder1\subfolder3\fileC.txt Note that the first command uses a forward slash as path separator, the second uses backslash as path separator. When calculating the set difference fileC.txt doesn't match and rbt posts it as a newly added file. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3894 in reviewboard: When using mercurial empty files are included in all posted reviews
Comment #1 on issue 3894 by ali.kam...@visiercorp.com: When using mercurial empty files are included in all posted reviews https://code.google.com/p/reviewboard/issues/detail?id=3894 Patch submitted: https://reviews.reviewboard.org/r/7443/diff/1#index_header -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3894 in reviewboard: When using mercurial empty files are included in all posted reviews
Comment #2 on issue 3894 by trowb...@gmail.com: When using mercurial empty files are included in all posted reviews https://code.google.com/p/reviewboard/issues/detail?id=3894 Issue 3556 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3897 in reviewboard: Perforce descriptions submitted via rbt post with GUESS_FIELDS enabled are incorrectly parsed
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3897 by buck.a...@gmail.com: Perforce descriptions submitted via rbt post with GUESS_FIELDS enabled are incorrectly parsed https://code.google.com/p/reviewboard/issues/detail?id=3897 What version are you running? ReviewBoard 2.0.13 RBTools 0.7.4 p4 command-line client version P4/LINUX26X86_64/2012.1/473528 (2012/05/31) Perforce server version P4D/LINUX26X86_64/2014.1/963489 (2014/11/18) What's the URL of the page containing the problem? https://reviewboard.example.com/api/review-requests/xx/draft/ What steps will reproduce the problem? 1. Compose a new Perforce change, including a description. Ensure that the description has a few custom fields (e.g. Testing Done:). 2. Post the change to ReviewBoard with `-g auto` or `-g yes`: $ rbt post -g auto CLN 3. Navigate to the review draft page. Note that the change description includes the Testing Done field that should have been parsed into the Testing Done box. The Testing Done box is empty when it should contain the contents of the Testing Done field. What is the expected output? What do you see instead? Expected output: change description (including first-line summary) in the Description text entry. Testing Done field in the Testing Done text entry. Example of expected output for the description field: = Change description summary Change description verbose description = Actual output: change description (with first-line summary removed) in the description box, along with the Testing Done field after it, as well as other fields present that are usually parsed out. The Testing Done box is empty. Example of actual output for the description box: = Change description verbose description Testing Done: [testing done field contents] Reviewed by: [reviewed by field contents] Review URL: [review URL field contents] = For completeness, here is the entirety of the Perforce description of the faux change used for the above two examples: = Change description summary Change description verbose description Testing Done: [testing done field contents] Reviewed by: [reviewed by field contents] Review URL: [review URL field contents] = What operating system are you using? What browser? Linux. Firefox. Please provide any additional information below. The default behavior is a regression from RBTools 0.5.x, which handled Perforce changes correctly. I would somewhat expect `-g yes` to no-op on Perforce repos (since I believe the change description is unconditionally fetched directly from the Perforce server by the ReviewBoard server), and `-g auto` should definitely no-op in this case. I also don't really expect the change description to update when `-g no` is passed, but knowing how the Perforce support works, I'm not really surprised it does either (and don't consider this a bug). -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3898 in reviewboard: Enable Markdown checkbox isn't reset when RBTools uploads a new plaintext change description
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3898 by buck.a...@gmail.com: Enable Markdown checkbox isn't reset when RBTools uploads a new plaintext change description https://code.google.com/p/reviewboard/issues/detail?id=3898 What version are you running? ReviewBoard 2.0.13 RBTools 0.7.4 (also reproduces with RBTools 0.5.2) What's the URL of the page containing the problem? https://reviewboard.example.com/api/review-requests/xx/draft/ What steps will reproduce the problem? 1. In your ReviewBoard account settings, uncheck Always use Markdown for text fields and save the settings. 2. Post (but do not publish) a new review using command-line RBTools, including a description. 3. Check the Enable Markdown box on the review description. Press OK. 4. Publish the review. 5. Post a new revision of the review using command-line RBTools, including an updated description. 6. View the review description. Note that even though the description was updated by RBTools, the Enable Markdown checkbox is still checked. What is the expected output? What do you see instead? The Enable Markdown checkbox should have been reset to unchecked to match the user's profile settings and type of the uploaded text. What operating system are you using? What browser? Linux. Firefox. Please provide any additional information below. Always use Markdown for text fields seems to determine the initial state of the Enable Markdown checkbox on text fields but doesn't do anything beyond that. In this case, I was attempting to disable it to avoid ReviewBoard's behavior of escaping Markdown found in uploaded change descriptions. It might be better to instead: Always use Markdown for text fields: This option should behave as it already does (i.e. set the initial state of the Enable Markdown checkbox on text fields). Add an additional Convert non-Markdown review descriptions to Markdown (enable Markdown escaping) sub-option below Always use Markdown for text fields. Any time a change description is uploaded by RBTools to the server, do the following: 1) If the change description is Markdown (i.e. `--markdown` was passed to `rbt post`), check the Enable Markdown checkbox and update the description with the verbatim text received. 2) If the change description is plain text and the Convert non-Markdown review descriptions to Markdown option is enabled, perform Markdown escaping on the change description, check the Enable Markdown checkbox and update the description with the escaped text. 3) If the change description is plain text and the Convert non-Markdown review descriptions to Markdown option is not enabled, uncheck the Enable Markdown checkbox and update the description with the verbatim text received. This allows authoring Markdown descriptions without having to explicitly specify `--markdown` to `rbt post`, and also allows users to disable Markdown conversion/escaping entirely. It also ensures that the Enable Markdown option on the Description field always matches the actual type of the text uploaded by RBTools (or at least what type RBTools thinks it is). If you don't want to add a new option to toggle conversion, then I'd still like to see the state of the Enable Markdown checkbox clobbered by the text type of newly uploaded descriptions. It makes no sense to preserve the existing type when the text is being replaced entirely by `rbt post`. Since RBTools already tells the server the type, it shouldn't be using the user's settings to infer what they want instead of setting the checkbox to the correct value. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3895 in reviewboard: UnicodeDecodeError when posting reviews
Comment #1 on issue 3895 by ali.kam...@visiercorp.com: UnicodeDecodeError when posting reviews https://code.google.com/p/reviewboard/issues/detail?id=3895 Patch submitted: https://reviews.reviewboard.org/r/7442/diff/1/#index_header -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3899 in reviewboard: New Feature: User can edit the comment
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 3899 by liping.huang2...@gmail.com: New Feature: User can edit the comment https://code.google.com/p/reviewboard/issues/detail?id=3899 *** For customer support, please post to reviewbo...@googlegroups.com *** If you have a patch, please submit it to http://reviews.reviewboard.org/ *** *** Do not post confidential information in this enhancement request! What version are you running? 2.0.13 Currently user can add comment to the review request, but after user post the comment, the comment cannot edit anymore, please add the edit feature for the comments. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
