Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

Ok, so I've been stuck here for a while now. I totally dropped Apache, even 
though I eventually want to go back to it, but I attempted removing SSL for now 
from configuration and running with Nginx instead. I get to login screen at 
both http://my-domain/rb/ and http://my-ip/rb/, but I am only able to login 
from http://my-ip/rb/. Logging in from http://my-domain/rb/ just reloads the 
login view. 

I tried adding the --domain-name="my-domain" flag on site install.
Any previous experience on this issue?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

I was able to fix the icon img by adding srcset to the rule for img tags in 
mod_proxy_html:
ProxyHTMLLinks  img  src srcset

original:

result:


Although the second url in srcset is not rewritten.

However, the onclick event in list item elements of the page_sidebar is 
quite a bit different.

All0

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

Thank you, I just stumbled upon this while researching django's equivalent 
to tomcat's context path. I guess this will solve all my issues. I haven't 
worked with django applications before.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

Our requirement is that the application isn't served at the root path, so 
I've been trying to get it to work at e.g.: /rb/ using Apache as a reverse 
proxy. If there's another, better way to solve this I'm open to suggestions.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Files:
- virtual-host.txt
  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Files:
- view-source-dashboard.html
  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New ticket #4631 by kbjerke
For Beanbag, Inc. > Review Board

Status: New
Tags: Priority:Medium, Type:Defect

File attachments:

 * view-source-dashboard.html
   

 * virtual-host.txt
   



--
Dashboard isn't properly redirecting behind a proxy
==

# What version are you running?
3.0.2, but the issue was present in 2.5.16

# What's the URL of the page containing the problem?
/dashboard/

# What steps will reproduce the problem?
1. Run Review Board behind a proxy at a path e.g.: /rb/
2. Login and go to Dashboard
3. Click any submenu item under Outgoing/Incoming (All, Open, Open, To me) 


# What is the expected output? What do you see instead?
Expected: Redirect to /rb/dashboard/?view={to-me, outgoing}
Actual result: Redirect to /dashboard/?view={to-me, outgoing}

# What operating system are you using? What browser?
CentOS 7 (Inside Docker container)
Chrome, Firefox is not even displaying the  in the 
rendered HTML

# Please provide any additional information below.
So I am running all of this in Docker, I have 3 containers (reviewboard, 
memcached and apache httpd) and a remote PostgreSQL db. After doing some 
research, I believe my proxy settings are correct, but I may be mistaken. 

I'm including 2 files: 1. view-source of /rb/dashboard/ and 2. VirtualHost 
entry.

--

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

Don't you think it's strange that this works for Firefox, Edge and even 
Chrome logging in using IP


Files:
- nginx.conf
  

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

Username:Password:Forgot your password?

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

Figured out this only applies to newer versions of Google Chrome, whereas 
Firefox and Edge both works fine. I think you better look into this.
ReviewBoard on a non-root path behind a reverse proxy.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

The hostname there is correct. The upstream rule refers to a remote server, 
or rather the docker container that's running Review Board, and I only have 
Nginx as reverse proxy, no Apache. A short update, I tried to go back to just 
using Apache again, with my default SSL settings etc.
This is the VirtualHost:

  ServerName our.domain.com
  ProxyRequests Off
  ProxyPreserveHost On

  ProxyPass /rb/ http://rb:8000/rb/
  ProxyPassReverse /rb/ http://rb:8000/rb/
  RequestHeader set X-Forwarded-Proto "https"
#  RequestHeader set X-Forwarded-Port "443"

  
require all granted
  

And now this works. I'm totally confused, because I'm sure I've had this 
setup prior to testing on Nginx.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board Ticket #4631: Dashboard isn't properly redirecting behind a proxy

[kasper . bjerke91]

--
To reply, visit https://hellosplat.com/s/beanbag/tickets/4631/
--

New update by kbjerke
For Beanbag, Inc. > Review Board > Ticket #4631


Reply:

that line RequestHeader set X-Forwarded-Port "443" is commented out with #, 
that's why it's bold.. Should have just removed that line.

-- 
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at https://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.