Re: Issue 3067 in reviewboard: RB can't resolve diff when parent diff is given

2013-08-25 Thread reviewboard


Comment #2 on issue 3067 by glind...@dynamiccontrols.com: RB can't resolve  
diff when parent diff is given

http://code.google.com/p/reviewboard/issues/detail?id=3067

I made a mistake when creating a new review request. I used the wrong main  
repository :-(


When I use the correct repository, RB creates the review request and it  
goes wrong when I want to look at the diff. The diff for f1 is OK, the diff  
for f2 gives an error: Error: The file 'f2' (rec32bb492cac) could not be  
found in the repository.


See images attached.



Attachments:
rbf2diff_1.png  29.8 KB
rbf2diff_2.png  97.8 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Re: Issue 3067 in reviewboard: RB can't resolve diff when parent diff is given

2013-08-22 Thread reviewboard


Comment #1 on issue 3067 by trowb...@gmail.com: RB can't resolve diff when  
parent diff is given

http://code.google.com/p/reviewboard/issues/detail?id=3067

I'm not sure that revision 0 was properly pushed to the repository.

According to this:

$ hg diff -c 1
diff -r 5f714bed7dcc -r ec32bb492cac f1
--- a/f1Thu Aug 22 07:12:46 2013 +1200
+++ b/f1Thu Aug 22 07:14:14 2013 +1200
@@ -0,0 +1,1 @@
+xxx

revision 1 starts with f1 at 5f714bed7dcc and ends at revision  
ec32bb492cac. I'm not sure how to get hg to tell me what revision the files  
are at which changes, but it seems to me like 5f714bed7dcc was introduced  
at revision 0.




--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.


Issue 3067 in reviewboard: RB can't resolve diff when parent diff is given

2013-08-21 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3067 by glind...@dynamiccontrols.com: RB can't resolve diff when  
parent diff is given

http://code.google.com/p/reviewboard/issues/detail?id=3067

*** For customer support, please post to reviewbo...@googlegroups.com
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** Do not post confidential information in this bug report!

What version are you running?
RB 1.7.13

What's the URL of the page containing the problem?
n/a

What steps will reproduce the problem?
1. create new local repo with three changeset, see attachment
2. create new empty central repository, linked to RB
3. push up revision 0 to central repository (don't push up r1 and r2)
4. my intention is to use RB to review changes between rev 1 and rev 2:
5. create parent diff: hg diff -r0 -r1parent.diff
6. create diff to review: hg diff -r1 -r2target diff
7. create new review in RB, upload parent.diff  target.diff
8. When clicking Create Review Request RB responds with error:
The file 'f1' (r5f714bed7dcc) could not be found in the repository

What is the expected output? What do you see instead?
- I expect RB to create a new review, instead it returns a fault. RB starts  
looking for file 'f1' (r5f714bed7dcc) in the central repository, but it  
doesn't exist. This is logical because the listed revision is not in th  
central repository.


What operating system are you using? What browser?
- tried it from Windows XP and Debian Linux, both give the same result
- browser is Iceweasel

Please provide any additional information below.
- I created the parent and target diff manually to exclude any tool  
involvement



Attachments:
sandbox.zip  6.5 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/groups/opt_out.