Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 3285 by marcin.m...@gmail.com: Case sensitive comparison between
cwd and workspace root causes issues on Windows
http://code.google.com/p/reviewboard/issues/detail?id=3285
I'm running RBTools 0.5.7 with Perforce and Windows 7 Professional. If a
path to the workspace root contains capital drive letter (e.g. C:\p4\),
post-review and rbt won't let me post a review. Instead I get the following
error:
ERROR:root:The current directory does not contain a checkout from a
supported source code repository.
I've identified that the problem is that a comparison between the current
path (from where the rbt is called) and Perforce workspace root is case
sensitive. As os.getcwd() returns lower-case drive letter, the following
comparison will fail
perforce.py, PerforceClient():
if not norm_cwd.startswith(norm_client_root):
return None
Perhaps this should be made case insensitive for Windows.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.
