Re: Issue 3384 in reviewboard: Content-Disposition is inline instead of attachment in response to Download Diff
Updates: Status: Fixed Comment #3 on issue 3384 by trowb...@gmail.com: Content-Disposition is inline instead of attachment in response to Download Diff http://code.google.com/p/reviewboard/issues/detail?id=3384 Fixed in release-2.0.x (855d395). Thanks! -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3384 in reviewboard: Content-Disposition is inline instead of attachment in response to Download Diff
Comment #1 on issue 3384 by javabr...@gmail.com: Content-Disposition is inline instead of attachment in response to Download Diff http://code.google.com/p/reviewboard/issues/detail?id=3384 Priority of this is low for now, as I found that for some reason, Chrome as of 35.0.1916.114 seems to ignore Content-Disposition: attachment anyway and still renders inline. Looks like a Chrome bug. If that bug were fixed, then this change would become useful. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Issue 3384 in reviewboard: Content-Disposition is inline instead of attachment in response to Download Diff
Comment #2 on issue 3384 by javabr...@gmail.com: Content-Disposition is inline instead of attachment in response to Download Diff http://code.google.com/p/reviewboard/issues/detail?id=3384 Actually I've falsely accused Chrome there; something was being cached. So this can be fixed. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Issue 3384 in reviewboard: Content-Disposition is inline instead of attachment in response to Download Diff
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 3384 by javabr...@gmail.com: Content-Disposition is inline instead of attachment in response to Download Diff http://code.google.com/p/reviewboard/issues/detail?id=3384 What version are you running? 1.7.21 What's the URL of the page containing the problem? e.g. /r/12345/diff/raw/ What steps will reproduce the problem? 1. Use Chrome, click Download Diff. 2. Note that the response headers contain: Content-Disposition: inline; filename=some.patch 3. Chrome displays the diff inline, as instructed. The file should be downloaded instead. I think Content-Disposition: attachment;filename=some.patch should achieve this. What is the expected output? What do you see instead? Patch contents are displayed in the browser window. For Download Diff, it should ... download. What operating system are you using? What browser? Chrome. Firefox is not affected. Please provide any additional information below. See also discussion at https://groups.google.com/forum/#!topic/reviewboard/yhW3ycXwqVA -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
