Issue 401 in reviewboard: Comments should be inserted into diff below lines being discussed, instead of in dialog box
Updates: Status: Fixed Comment #6 on issue 401 by chipx86: Comments should be inserted into diff below lines being discussed, instead of in dialog box http://code.google.com/p/reviewboard/issues/detail?id=401 Implemented the new, more condensed, better-aligned comment dialog in r1644. I think it's a huge improvement. We can make incremental improvements over this down the road, but for now, this is what we're going with. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 401 in reviewboard: Comments should be inserted into diff below lines being discussed, instead of in dialog box
Issue 401: Comments should be inserted into diff below lines being discussed, instead of in dialog box http://code.google.com/p/reviewboard/issues/detail?id=401 Comment #5 by chipx86: The key difference with the popup window is that we get intelligently place it initially but give users the freedom to move it if they're reviewing a large block of code. I assumed in this design that all inline comments would just show up automatically, rather than having comment flags. That's been the design people have recommended to me in the past when talking about an inline comment field like this. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 401 in reviewboard: Comments should be inserted into diff below lines being discussed, instead of in dialog box
Issue 401: Comments should be inserted into diff below lines being discussed, instead of in dialog box http://code.google.com/p/reviewboard/issues/detail?id=401 Comment #3 by chipx86: Making the UIs configurable makes it a pain to maintain, document and support. After careful consideration, I've decided not to go the inline route, as there's a number of problems associated with it: 1) If you're reviewing a large number of lines, you have no way of seeing both the text entry and the diff lines at the same time. 2) There's no good way of indicating which lines the comment is associated with. The comment flags do a better job of this, and will do an even better job once they show line ranges (soon). 3) People don't always want to just see the comments appear. We'd need a good way of letting users show/hide all these, and that's even more unclear. Where do you go for this? Top of the page? Have a floating window somewhere? It just seems to me that it'll get in the way at times. 4) It'll appear even more like you're supposed to reply to comments by attaching a new comment to a line. This is a problem we have today, where people try to use the diff viewer to reply to reviews, which produces unexpected results. We don't want to encourage this further. What I am doing is revising the comment dialog to be smaller, appear below the comment range at a better default position, and to make it a lot more clear how to reply to existing comments and how to create new comments. I'm hijacking this bug for the new design and will be closing when the change goes in. Issue attribute updates: Status: Started Owner: chipx86 Labels: Milestone-Release1.0 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
