Re: Review Board Ticket #4450: ReviewRequest.last_review_activity_timestamp should be exposed in the API
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4450/ -- New update by samsun387 For Beanbag, Inc. > Review Board > Ticket #4450 Reply: Needs more thought before we can say it's easy and hand it to contributors. Tags: - EasyFix -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4450: ReviewRequest.last_review_activity_timestamp should be exposed in the API
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4450/ -- New update by samsun387 For Beanbag, Inc. > Review Board > Ticket #4450 Reply: Hi, Just following up on this. Since it's marked as an easy fix, is there a targetted release for it at the moment? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4450: ReviewRequest.last_review_activity_timestamp should be exposed in the API
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4450/ -- New update by samsun387 For Beanbag, Inc. > Review Board > Ticket #4450 Reply: We don't really have a mechanism for queries like that today. We'd have to consider how that would work, but I don't think I can make any promises there. I mean, we could perhaps add a `?last-updated-or-review-activity-from=`, but that's sort of a slippery slope. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4450: ReviewRequest.last_review_activity_timestamp should be exposed in the API
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4450/ -- New update by samsun387 For Beanbag, Inc. > Review Board > Ticket #4450 Reply: Thanks for the quick response. Yes I also tried to use the last_review_timestamp(the column name in db in reviewrequest table) but found out it's not available through API. It would be great if you can expose that. With last_review_timestamp being exposed through API, is there a way to call the API so that it returns the review requests with either last_updated_from or last_review_timestamp within 24 hours, whichever is later? Otherwise I will make two api calls to get two lists of review request and combine them. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #4450: ReviewRequest.last_review_activity_timestamp should be exposed in the API
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4450/ -- New update by samsun387 For Beanbag, Inc. > Review Board > Ticket #4450 Reply: This is intentional. It's not the creation of the issue that updates `last_updated` (which `?last-updated-from=` queries). It's the publishing of the review. We update the timestamp when something fundamental happens on the review request, like a new draft of the review request is published or a new review/reply is published. This timestamp impacts the order in which review requests are shown in the dashboard (assuming you're sorting by Last Updated, which is the default). A review request jumping to the top of the dashboard is an indicator that there's something new there perhaps worth looking at, and changing issue statuses doesn't fall into that category (as it's primarily useful for the owner of the review request, not other reviewers). Toggling the issue status of a comment does impact another field on the model, `last_review_activity_timestamp`. This value, unfortunately, is not exposed in the API, and is worth adding (along with a `?last-review-activity-from=`). I'd take a patch to add that, and it'd probably be only about 3 or 4 lines of code in `reviewboard/webapi/resources/review_request.py` plus a couple of unit tests. Status: - New + Confirmed Tags: - Type:Defect + Component:API + Component:Reviews + EasyFix + Type:Enhancement Summary: - Fixed issue / Drop issue doesn't update the last_updated_from in Review Request + ReviewRequest.last_review_activity_timestamp should be exposed in the API -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
