Issue 1853 in reviewboard: Diff fails to apply cleanly if a line is removed that begins with "--" (2 dashes)

2010-10-18 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1853 by eddawley: Diff fails to apply cleanly if a line is removed that begins with "--" (2 dashes) http://code.google.com/p/reviewboard/issues/detail?id=1853 *NOTE: Do not post confidential information in this bug report.*

Issue 1854 in reviewboard: Download raw diff cached - need to manually refresh to update

2010-10-18 Thread reviewboard
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 1854 by jtatum: Download raw diff cached - need to manually refresh to update http://code.google.com/p/reviewboard/issues/detail?id=1854 What version are you running? 1.0.7 What's the URL of the page containing the proble

Re: Issue 929 in reviewboard: reviewboard should not alter the diff file

2010-10-18 Thread reviewboard
Comment #3 on issue 929 by ashe...@asheesh.org: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 I'm thinking about submitting a patch to ReviewBoard that fixes this. It seems like reviewboard could simply save the uploaded diff somewhere,

Re: Issue 929 in reviewboard: reviewboard should not alter the diff file

2010-10-18 Thread reviewboard
Comment #4 on issue 929 by chipx86: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 It does do this. It just breaks it up per-file (which is needed). The problem is that the parser doesn't know about some of the extra metadata. So reall

Re: Issue 921 in reviewboard: Add post-commit review submission to post-review for perforce

2010-10-18 Thread reviewboard
Updates: Summary: Add post-commit review submission to post-review for perforce Labels: -Type-Defect Type-Enhancement Comment #2 on issue 921 by trowbrds: Add post-commit review submission to post-review for perforce http://code.google.com/p/reviewboard/issues/detail?id=921 (N

Re: Issue 929 in reviewboard: reviewboard should not alter the diff file

2010-10-18 Thread reviewboard
Comment #5 on issue 929 by d...@n-cube.org: reviewboard should not alter the diff file http://code.google.com/p/reviewboard/issues/detail?id=929 I wonder if this wouldn't still be a good idea. I was trying to review http://reviews.reviewboard.org/r/1737/ the other day because I thought it