Re: Issue 2256 in reviewboard: post-review should use -c option when calling svn diff with single rev

2012-01-25 Thread reviewboard
Comment #2 on issue 2256 by seamus.l...@mformation.com: post-review should use -c option when calling svn diff with single rev http://code.google.com/p/reviewboard/issues/detail?id=2256 Not quite, you need to support both cases, where single revision is listed and where a range is listed, s

Re: Issue 2104 in reviewboard: provide a way to map file extensions to syntax highlighting

2012-01-25 Thread reviewboard
Comment #1 on issue 2104 by jsil...@koukaam.se: provide a way to map file extensions to syntax highlighting http://code.google.com/p/reviewboard/issues/detail?id=2104 I hacked rng support with this nasty patch on reviewboard/diffviewer/diffutils.py : 10a11 from pygments.lexers impor

Re: Issue 2465 in reviewboard: For non owned review - fix error message in Review Board post-review tool

2012-01-25 Thread reviewboard
Comment #1 on issue 2465 by sudhir.s...@gmail.com: For non owned review - fix error message in Review Board post-review tool http://code.google.com/p/reviewboard/issues/detail?id=2465 Better diagnostic for non owned review update is as below: if not server.info.supports_changesets or not

Re: Issue 2047 in reviewboard: UnicodeDecodeError: 'utf8' codec can't decode byte

2012-01-25 Thread reviewboard
Comment #3 on issue 2047 by amber.y...@gmail.com: UnicodeDecodeError: 'utf8' codec can't decode byte http://code.google.com/p/reviewboard/issues/detail?id=2047 Not sure if it's the exact same code path or not, but... Traceback (most recent call last): File "/usr/lib/pymodules/python2.6/dja

Re: Issue 2462 in reviewboard: Must enable extension to configure

2012-01-25 Thread reviewboard
Updates: Status: New Comment #2 on issue 2462 by trowb...@gmail.com: Must enable extension to configure http://code.google.com/p/reviewboard/issues/detail?id=2462 Oops, not quite. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group