Issue 1345 in reviewboard: post-review does not process a *pending* Perforce changeset in v0.2 beta3
Comment #2 on issue 1345 by lonico: post-review does not process a *pending* Perforce changeset in v0.2 beta3 http://code.google.com/p/reviewboard/issues/detail?id=1345 Since I am at it, 2 additional issues: 1) wrong index offset when testing for Perforce version +# if v[1] < 2002 or (v[1] == "2002" and v[2] < 2): +if v[0] < 2002 or (v[0] == "2002" and v[1] < 2): +# if cl_is_pending and (v[1] < 2002 or (v[1] == "2002" and v[2] < 2)): +if cl_is_pending and (v[0] < 2002 or (v[0] == "2002" and v[1] < 2)): 2) Specific to our installation maybe. The test in: if '*pending*' in description[0]: is fragile. In our installation, our wrapper prints an extra line, so the test fails. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1345 in reviewboard: post-review does not process a *pending* Perforce changeset in v0.2 beta3
Comment #1 on issue 1345 by lonico: post-review does not process a
*pending* Perforce changeset in v0.2 beta3
http://code.google.com/p/reviewboard/issues/detail?id=1345
I should have gone a bit further.
The last else is misplaced in the diffs below. It should be at the same
level as the
for.
Thank you
Laurent
-# Get the file list
-for line_num, line in enumerate(description):
-if 'Affected files ...' in line:
-break
else:
-# Got to the end of all the description lines and didn't find
-# what we were looking for.
-die("Couldn't find any affected files for this change.")
+# Get the file list
+for line_num, line in enumerate(description):
+if 'Affected files ...' in line:
+break
+else:
+# Got to the end of all the description lines and
didn't find
+# what we were looking for.
+die("Couldn't find any affected files for this
change.")
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
Issue 1345 in reviewboard: post-review does not process a *pending* Perforce changeset in v0.2 beta3
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1345 by lonico: post-review does not process a *pending* Perforce
changeset in v0.2 beta3
http://code.google.com/p/reviewboard/issues/detail?id=1345
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
RBTools v0.2 beta3 dev
What's the URL of the page containing the problem?
post-review command line tool
What steps will reproduce the problem?
1.have a pending changeset in Perforce, with some Affected files
2.submit a review using post-review
3.
What is the expected output? What do you see instead?
The review should be submitted.
Here is fails with:
>>> Generating diff for changenum 969273
>>> p4 describe -s 969273
Couldn't find any affected files for this change.
The same scenarios works with v0.2 beta2
What operating system are you using? What browser?
Linux
Please provide any additional information below.
I believe the problem comes from the addition of:
+description = []
under if '*pending*'
for Support older p4d, pending changelists on 9/21.
debug("Generating diff for changenum %s" % changenum)
-description = execute(["p4", "describe", "-s", changenum],
- split_lines=True)
+description = []
-if '*pending*' in description[0]:
+if changenum == "default":
cl_is_pending = True
+else:
+description = execute(["p4", "describe", "-s", changenum],
+ split_lines=True)
+
+if '*pending*' in description[0]:
+cl_is_pending = True
+description = []
+
+v = self.p4d_version
+
+if cl_is_pending and (v[1] < 2002 or (v[1] == "2002" and v[2] <
2)):
+# Pre-2002.2 doesn't give file list in pending changelists, so
we
+# have to get it a different way
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
