Comment #2 on issue 1376 by niko...@prokoschenko.de: post-review:
--repository-url pointing to a file doesn't work
http://code.google.com/p/reviewboard/issues/detail?id=1376
It makes perfect sense to me. A little explanation might be in order :)
Use case: I've got a developer who'd like to have his committed changes to
a file
file.txt reviewed, let's say he started at revision 100 and finished at
revision
150. There have been five commits, so his commits are probably at 100, 110,
120,
130, 140 and 150 -- but this doesn't really matter, it matters that there
were no
other changes to that file in the meantime, he's been the only developer.
Now I've been asked how to create a review for that. Normally, svn diff -r
100:150 file.txt would generate a proper diff, however post-review doesn't
support
filenames for revision ranges. So I looked into documentation and notices --
repository-url parameter. Since in SVN every URL inside a repository may be
checked
out independently, I tried to use http://svn.server/svn/path/to/file.txt as
repository URL.
post-review -d -n --revision-range=100:150 --repository-
url=http://svn.server/svn/path/to/file.txt; ran without problems and has
produced
proper diff for that single file for revisions 100 to 150. It's only when
post-
review tried to submit that diff to Review Board that problems began.
post-review
replaced the Info: field in the diff with
http://svn.server/svn/path/to/file.txt/file.txt; (previously
just file.txt)
assuming that filename in the diff should be attached to the base path
given as --
repository-url. This is not really correct -- if the URL points to a file,
that
filename should be removed from the path between diffing and uploading to
Review
Board. In that case, filename gets attached properly and RB accepts the
diff.
That said, I fully understand that I might be bending RB's strain features
quite a
bit and would prefer doing this all properly. For that, I'd need a way to
review
changes to single files over several commits -- again, I know developer
discipline
is probably the Right Way (tm) to go, but my fellow developers don't even
grasp the
necessity for proper commit messages, not to mention proper atomic bundling
of
changes.
I hope this explanation made it a bit clearer to you.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~--~~~~--~~--~--~---
