Re: Issue 1658 in reviewboard: dont notify me about something i just did

2010-05-22 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 477

Comment #2 on issue 1658 by trowbrds: dont notify me about something i just  
did

http://code.google.com/p/reviewboard/issues/detail?id=1658

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1658 in reviewboard: dont notify me about something i just did

2010-05-21 Thread reviewboard


Comment #1 on issue 1658 by zakness: dont notify me about something i just  
did

http://code.google.com/p/reviewboard/issues/detail?id=1658

looked through the issue list some more, this should probably be merged  
into #477 :)


--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Issue 1658 in reviewboard: dont notify me about something i just did

2010-05-20 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 1658 by zakness: dont notify me about something i just did
http://code.google.com/p/reviewboard/issues/detail?id=1658

RB should be smart enough to not email someone about a change they just  
made.


Here's the scenario:

Our team has set up several default reviewers based on file path regexes (a
very handy feature). We have done this by adding specific people (not
groups). We're using a post-commit hook. We have email notifications turned  
on.


Problem:

I often commit into areas where I'm also a default reviewer:
* When I commit something I get an email saying I've requested a new review.
* When I comment on something I get an email saying I commented.
* When I publish a review I get an email.
* etc.

I can think of two solutions:

1. When RB is about to send a notification based on a user action, remove
that user from the list of recipients (make it a preference if you like)
2. When RB decides who to add as default reviewer, never add the submitter
even if they appear in the default reviewer list (this would definitely
have to be a preference)

I would say #1 is the better, more general solution. What do you guys think?

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.