Issue 1686 in reviewboard: New feature request: code commentary

2010-06-15 Thread reviewboard

Status: New
Owner: 
Labels: Type-Enhancement Priority-Medium

New issue 1686 by AaronJSherman: New feature request: code commentary
http://code.google.com/p/reviewboard/issues/detail?id=1686

*NOTE: If you have a patch, please submit it to
http://reviews.reviewboard.org/


What version are you running? 1.0.7


What's the URL of the page this enhancement relates to, if any? N/A


Describe the enhancement and the motivation for it.

We'd love to see a way to add commentary on code before publishing a review  
in order to explain changes inline in a similar fashion to reviewing  
inline. Some slightly different UI elements might make sense for this,  
though:


* A different visual cue to highlight the comment for reviewers as they  
read the diffs
* Ability to reply to such a note, thus attaching the review comment to  
the line of code AND to the note so that both contexts are preserved on the  
reviews page.
* Perhaps a set of links on the main review page under the description to  
the notes.


Here's a use case:

I modify GNU fsutils to make rm not delete symlinks when provided a  
--no-symlinks option. I post a review, but before publishing, I want to  
explain inline that the use of stat and not lstat in a given section of  
code was a conscious choice, and yielded an important benefit. I make this  
comment on that particular line of code and then reviewers can respond more  
cogently.





What operating system are you using? What browser?


Please provide any additional information below.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 1686 in reviewboard: New feature request: code commentary

2010-06-15 Thread reviewboard

Updates:
Status: Duplicate
Mergedinto: 831

Comment #1 on issue 1686 by trowbrds: New feature request: code commentary
http://code.google.com/p/reviewboard/issues/detail?id=1686

(No comment was entered for this change.)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.