Re: Issue 1917 in reviewboard: post-review doesn't play nice with msysgit on Windows
Updates: Status: Fixed Comment #4 on issue 1917 by trowb...@gmail.com: post-review doesn't play nice with msysgit on Windows http://code.google.com/p/reviewboard/issues/detail?id=1917 Fixed in master as d0138a7. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1917 in reviewboard: post-review doesn't play nice with msysgit on Windows
Comment #3 on issue 1917 by joshua.m...@gmail.com: post-review doesn't play nice with msysgit on Windows http://code.google.com/p/reviewboard/issues/detail?id=1917 OK, http://reviews.reviewboard.org/r/2226/ -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1917 in reviewboard: post-review doesn't play nice with msysgit on Windows
Updates: Status: PendingReview Comment #2 on issue 1917 by trowb...@gmail.com: post-review doesn't play nice with msysgit on Windows http://code.google.com/p/reviewboard/issues/detail?id=1917 Please put this on http://reviews.reviewboard.org/ -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1917 in reviewboard: post-review doesn't play nice with msysgit on Windows
Comment #1 on issue 1917 by joshua.m...@gmail.com: post-review doesn't play nice with msysgit on Windows http://code.google.com/p/reviewboard/issues/detail?id=1917 Ping, any progress on this? -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 1917 in reviewboard: post-review doesn't play nice with msysgit on Windows
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1917 by joshua.m.kwan: post-review doesn't play nice with msysgit
on Windows
http://code.google.com/p/reviewboard/issues/detail?id=1917
What version are you running?
1.5 Beta 1
When trying to post a review from a git repository on Windows using
msysgit, post-review will not pick up git because msysgit installs
a 'git.cmd' into the user's PATH. But post-review uses subprocess.Popen to
launch commands, which on Windows delegates to CreateProcess, which does
not automatically append .cmd extensions, only .exe (see MSDN for an
explanation of this behavior.) However, CreateProcess will resolve things
in the PATH, though, so subprocess.Popen('git.cmd', ...) does work.
The fix is to try running 'git.cmd' explicitly, only on Windows. a patch is
attached.
Attachments:
post-review.diff 8.1 KB
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
