Issue 2503 in reviewboard: Check at beginning of login() function in post-review 0.4 is wrong
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 2503 by roy.jean...@gmail.com: Check at beginning of login() function in post-review 0.4 is wrong http://code.google.com/p/reviewboard/issues/detail?id=2503 What version are you running? RBTools 0.4 What's the URL of the page containing the problem? N/A What steps will reproduce the problem? 1. Call post-review with --username and --password. What is the expected output? What do you see instead? post-review fails with Authentication information needs to be provided on the command line when using --diff-filename=-. This exit path is incorrectly taken because the check at the beginning of the login() function has an operator precedence bug. It should be if (options.diff_filename == '-' and not (self.has_valid_cookie() or (options.username and options.password))): -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2503 in reviewboard: Check at beginning of login() function in post-review 0.4 is wrong
Updates: Status: Confirmed Owner: chip...@gmail.com Labels: -Priority-Medium Priority-Critical Milestone-RBTools-Release1.0 Component-RBTools Comment #1 on issue 2503 by chip...@gmail.com: Check at beginning of login() function in post-review 0.4 is wrong http://code.google.com/p/reviewboard/issues/detail?id=2503 We'll fix this and get a release out probably tonight. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2503 in reviewboard: Check at beginning of login() function in post-review 0.4 is wrong
Updates: Status: Fixed Comment #2 on issue 2503 by chip...@gmail.com: Check at beginning of login() function in post-review 0.4 is wrong http://code.google.com/p/reviewboard/issues/detail?id=2503 Fixed in master (1fa3c44) Waiting on another fix and then we'll do a release. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
