Re: Issue 2654 in reviewboard: Set, jump between bookmarks in DiffViewer
Updates: Status: Duplicate Mergedinto: 774 Comment #3 on issue 2654 by trowb...@gmail.com: Set, jump between bookmarks in DiffViewer http://code.google.com/p/reviewboard/issues/detail?id=2654 Very similar to 774. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2654 in reviewboard: Set, jump between bookmarks in DiffViewer
Comment #2 on issue 2654 by trowb...@gmail.com: Set, jump between bookmarks in DiffViewer http://code.google.com/p/reviewboard/issues/detail?id=2654 Issue 3082 has been merged into this issue. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at http://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/groups/opt_out.
Re: Issue 2654 in reviewboard: Set, jump between bookmarks in DiffViewer
Updates: Labels: Component-DiffViewer Comment #1 on issue 2654 by trowb...@gmail.com: Set, jump between bookmarks in DiffViewer http://code.google.com/p/reviewboard/issues/detail?id=2654 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Issue 2654 in reviewboard: Set, jump between bookmarks in DiffViewer
Status: New Owner: Labels: Type-Enhancement Priority-Medium New issue 2654 by ryan.bea...@gmail.com: Set, jump between bookmarks in DiffViewer http://code.google.com/p/reviewboard/issues/detail?id=2654 What version are you running? 1.6.1 What's the URL of the page this enhancement relates to, if any? ??? https://reviewboard.example.com/r/12345/diff/#index_header Describe the enhancement and the motivation for it. Developer posts a sizable review with a fair number of functions spread across multiple files. During review, I want to sanity check calls into new function whose return value, memory allocations, etc. I don't know. So, I need to jump to the called function, see what it does, what its side effects are, etc., and then return to the call to see if things check out. (For example, did the called function return a pointer to something allocated from the heap, and does the current function need to free it in case of failure?) With the current diff viewer, I have to manually search for the definition of the new function, then manually go back to its call site. It'd be nice if I could 1. record my current location in the diff viewer, 2. seek somewhere else in the diff, and then 3. press a key/keys or click something to immediately jump back to the saved location. What operating system are you using? What browser? Google Chrome 18–19 on Linux and Windows 7. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
