Re: Issue 3518 in reviewboard: Can't upload review due to UnicodeDecodeError

2014-08-05 Thread reviewboard

Updates:
Status: Fixed

Comment #3 on issue 3518 by trowb...@gmail.com: Can't upload review due to  
UnicodeDecodeError

http://code.google.com/p/reviewboard/issues/detail?id=3518

Fixed in release-2.0.x (6c7881f). Thanks!

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3518 in reviewboard: Can't upload review due to UnicodeDecodeError

2014-08-04 Thread reviewboard

Updates:
Status: PendingReview
Owner: trowb...@gmail.com
Labels: Component-SCMTools Project-ReviewBoard

Comment #2 on issue 3518 by trowb...@gmail.com: Can't upload review due to  
UnicodeDecodeError

http://code.google.com/p/reviewboard/issues/detail?id=3518

(No comment was entered for this change.)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3518 in reviewboard: Can't upload review due to UnicodeDecodeError

2014-08-04 Thread reviewboard


Comment #1 on issue 3518 by alex...@gmail.com: Can't upload review due to  
UnicodeDecodeError

http://code.google.com/p/reviewboard/issues/detail?id=3518

I confirm this issue. It is reproduced on Windows OSes too.
The bug is regression against the previous major release version 1.7.x
The bug occurs when a file in SVN contains any non-ASCII symbol and diff  
uploads against such file. At the same time, diff with non-ASCII symbols  
can be uploaded.


mysql settings:
mysql> SHOW VARIABLES WHERE variable_name IN  
('character_set_database', 'collation_database');

++-+
| Variable_name  | Value   |
++-+
| character_set_database | utf8|
| collation_database | utf8_unicode_ci |
++-+
2 rows in set (0.00 sec)

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Issue 3518 in reviewboard: Can't upload review due to UnicodeDecodeError

2014-08-04 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3518 by e.apollo...@gmail.com: Can't upload review due to  
UnicodeDecodeError

http://code.google.com/p/reviewboard/issues/detail?id=3518


What version are you running?
2.0.5
Same issue on 2.0.4

What's the URL of the page containing the problem?
http://vssd-rb.digdes.com/r/new/

What steps will reproduce the problem?
1.Create review request using 'New Review Request for Pending Change' form.
2.Review request isn't created. Placeholder runs forever.

Same issue while uploading request using rbt post.

What is the expected output? What do you see instead?


What operating system are you using? What browser?
Ubuntu 14.04.1 LTS
Same issue on 13.10 and 13.04

Please provide any additional information below.

Traceback (most recent call last):

   
File "/usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/core/handlers/base.py",  
line 112, in get_response

response = wrapped_callback(request, *callback_args, **callback_kwargs)

   
File "/usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/views/decorators/cache.py",  
line 52, in _wrapped_view_func

response = view_func(request, *args, **kwargs)

   
File "/usr/local/lib/python2.7/dist-packages/Django-1.6.5-py2.7.egg/django/views/decorators/vary.py",  
line 19, in inner_func

response = func(*args, **kwargs)

   
File "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.8-py2.7.egg/djblets/webapi/resources.py",  
line 494, in __call__

request, method, view, api_format=api_format, *args, **kwargs)

   
File "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.8-py2.7.egg/djblets/webapi/resources.py",  
line 565, in call_method_view

return view(request, *args, **kwargs)

   
File "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.8-py2.7.egg/djblets/webapi/resources.py",  
line 747, in post

return self.create(*args, **kwargs)

   
File "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.8-py2.7.egg/djblets/webapi/decorators.py",  
line 117, in _call

return view_func(*args, **kwargs)

   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.5-py2.7.egg/reviewboard/webapi/decorators.py",  
line 110, in _check

return view_func(*args, **kwargs)

   
File "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.8-py2.7.egg/djblets/webapi/decorators.py",  
line 117, in _call

return view_func(*args, **kwargs)

   
File "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.8-py2.7.egg/djblets/webapi/decorators.py",  
line 138, in _checklogin

return view_func(*args, **kwargs)

   
File "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.8-py2.7.egg/djblets/webapi/decorators.py",  
line 117, in _call

return view_func(*args, **kwargs)

   
File "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.8-py2.7.egg/djblets/webapi/decorators.py",  
line 117, in _call

return view_func(*args, **kwargs)

   
File "/usr/local/lib/python2.7/dist-packages/Djblets-0.8.8-py2.7.egg/djblets/webapi/decorators.py",  
line 287, in _validate

return view_func(*args, **new_kwargs)

   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.5-py2.7.egg/reviewboard/webapi/resources/validate_diff.py",  
line 135, in create

save=False)

   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.5-py2.7.egg/reviewboard/diffviewer/managers.py",  
line 156, in create_from_upload

save=save)

   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.5-py2.7.egg/reviewboard/diffviewer/managers.py",  
line 182, in create_from_data

check_existence=(not parent_diff_file_contents)))

   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.5-py2.7.egg/reviewboard/diffviewer/managers.py",  
line 300, in _process_files

request=request))):

   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.5-py2.7.egg/reviewboard/scmtools/models.py",  
line 271, in get_file_exists

base_commit_id, request)

   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.5-py2.7.egg/reviewboard/scmtools/models.py",  
line 466, in _get_file_exists_uncached

exists = self.get_scmtool().file_exists(path, revision)

   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.5-py2.7.egg/reviewboard/scmtools/core.py",  
line 156, in file_exists

self.get_file(path, revision)

   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.5-py2.7.egg/reviewboard/scmtools/svn/__init__.py",  
line 117, in get_file

return self.client.get_file(path, revision)

   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.5-py2.7.egg/reviewboard/scmtools/svn/pysvn.py",  
line 106, in get_file

return self._do_on_path(self._get_file_data, path, revision)

   
File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-2.0.5-py2.7.egg/reviewboard/scmtools/svn/pysvn.py",  
line 75, in _do_on_path

stre = six.text_type(e)

UnicodeDecodeError: 'ascii' codec can't decode byte 0xd0 in posi