Issue 673 in reviewboard: Diff for text file can be lost following binary diff
Issue 673: Diff for text file can be lost following binary diff http://code.google.com/p/reviewboard/issues/detail?id=673 Comment #2 by trowbrds: Closing out because the needed information has not been supplied. If this is still a problem and you can provide the requested information, please add a comment and I'll reopen the bug. Issue attribute updates: Status: Incomplete -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 673 in reviewboard: Diff for text file can be lost following binary diff
Issue 673: Diff for text file can be lost following binary diff http://code.google.com/p/reviewboard/issues/detail?id=673 Comment #1 by chipx86: Binary data should never appear in a diff. This sounds like a server configuration issue. Is this at VMware or elsewhere? Can you provide a sample diff (using dummy files so there's no confidential content) that we can look at? Issue attribute updates: Status: NeedInfo -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 673 in reviewboard: Diff for text file can be lost following binary diff
Issue 673: Diff for text file can be lost following binary diff http://code.google.com/p/reviewboard/issues/detail?id=673 New issue report by clarkd4: *NOTE: Do not post confidential information in this bug report.* What's the URL of the page containing the problem? What steps will reproduce the problem? 1. Prepare a P4 change that adds a binary file followed by a new text file. Open both as text type. 2. Upload the diff. Bytes in the binary file confuse the diff parser so it includes the text file's contents in the binary file's diff section; the text file is also not shown in the list of files changed. 3. Change the filetype of the binary file to ubinary and re-post the diff. The result is unchanged. What is the expected output? What do you see instead? What operating system are you using? What browser? Chrome on 2003x64; shows up in all browsers. Please provide any additional information below. Issue attributes: Status: New Owner: Labels: Type-Defect Priority-Medium -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
