Issue 811 in reviewboard: Discarding an update diff posts data it shouldn't
Updates: Status: New Comment #4 on issue 811 by trowbrds: Discarding an update diff posts data it shouldn't http://code.google.com/p/reviewboard/issues/detail?id=811 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 811 in reviewboard: Discarding an update diff posts data it shouldn't
Comment #3 on issue 811 by jefflamb: Discarding an update diff posts data it shouldn't http://code.google.com/p/reviewboard/issues/detail?id=811 Figured it out. Specifying --target-people=person1,person2 and -r 123 where review #123 already has person1 and person2 in the reviewer's people list creates this blank update. Whether or not you want to fix this, I leave up to you. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 811 in reviewboard: Discarding an update diff posts data it shouldn't
Updates: Status: NeedInfo Comment #1 on issue 811 by chipx86: Discarding an update diff posts data it shouldn't http://code.google.com/p/reviewboard/issues/detail?id=811 I'm confused about the repro case. This extra review with blank content is in addition to the first review posted? I can't seem to get this to repro. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 811 in reviewboard: Discarding an update diff posts data it shouldn't
Comment #2 on issue 811 by jefflamb: Discarding an update diff posts data it shouldn't http://code.google.com/p/reviewboard/issues/detail?id=811 Ok, this is exactly how I reproduce it. Check something out, make a change. Run post-review like so: post-review.py . --target-people=person1 -o It opens the page in a browser. I fill in description, testing, summary. Hit publish. Change one line in another file in the . directory. Send off an update diff: post-review.py . --target-people=person1 -o -r 123 I have This review request is a draft. in a big green box at top with publish/discard changes buttons. At the bottom of my review, I have a Review request changed box, even though I didn't publish the new diff. The content of this box is blank. This also kicks off an update email to the reviewers. If I publish the changes, I correctly get another box after the empty Review request changed box that says: Review request changed Diff added Diff r2 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 811 in reviewboard: Discarding an update diff posts data it shouldn't
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 811 by jefflamb: Discarding an update diff posts data it shouldn't http://code.google.com/p/reviewboard/issues/detail?id=811 What steps will reproduce the problem? 1. Post a review. Publish. 2. Post a diff. Discard the diff. What is the expected output? What do you see instead? A Review request changed box with blank content is posted to the end of the review. As a side-effect, all reviewers get emailed on-discard as well. Using RB r1668. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
