Re: Issue 1575 in reviewboard: Show image files inline as part of diff view
Comment #7 on issue 1575 by carl.van...@gmail.com: Show image files inline as part of diff view http://code.google.com/p/reviewboard/issues/detail?id=1575 I don't see why you can't get the uploaded patch-file to include the binary diff. # hg diff test.png --text > my-review.patch # hg revert test.png # file test.png test.png: PNG image, 310 x 320, 8-bit/color RGBA, non-interlaced # patch -p1 < my-review.patch patching file test.png # file test.png test.png: PNG image, 320 x 281, 8-bit/color RGB, non-interlaced Seems to me that reviewboard will have all the info it needs. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1575 in reviewboard: Show image files inline as part of diff view
Updates: Labels: Component-DiffViewer Comment #6 on issue 1575 by trowbrds: Show image files inline as part of diff view http://code.google.com/p/reviewboard/issues/detail?id=1575 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1575 in reviewboard: Show image files inline as part of diff view
Updates: Status: New Comment #5 on issue 1575 by trowbrds: Show image files inline as part of diff view http://code.google.com/p/reviewboard/issues/detail?id=1575 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1575 in reviewboard: Show image files inline as part of diff view
Comment #4 on issue 1575 by philip.zeyliger: Show image files inline as part of diff view http://code.google.com/p/reviewboard/issues/detail?id=1575 Seems fair to relegate this sort of feature to post-review. For images used in web development, just seeing old and new (both of which may be accessible using git-cat-file, if using git) is often good enough, and that's probably the right thing to upload. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1575 in reviewboard: Show image files inline as part of diff view
Comment #3 on issue 1575 by chipx86: Show image files inline as part of diff view http://code.google.com/p/reviewboard/issues/detail?id=1575 We can only get the original, not the modifications. There's no way to see what changed, which makes it totally useless. There's also no way of making it work with other types of repositories. What we'd have to do is provide support in post-review for grabbing these modified binary files, figuring out the correct mimetypes, and uploading them. That might happen in a future release, but is not as easy as it may sound. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1575 in reviewboard: Show image files inline as part of diff view
Comment #2 on issue 1575 by philip.zeyliger: Show image files inline as part of diff view http://code.google.com/p/reviewboard/issues/detail?id=1575 The typical diff from git gives you something like: diff --git a/docs/sdk/htmltable.png b/docs/sdk/htmltable.png new file mode 100644 index 000..60617a2 Binary files /dev/null and b/docs/sdk/htmltable.png differ Seems like there's enough there that reviewboard could ask git for the blob: $git-cat-file blob 60617a2 > /tmp/z; file /tmp/z /tmp/z: PNG image data, 813 x 142, 8-bit/color RGB, non-interlaced I've noticed that reviewboard already does cat-file (our reviewboard server polls git every 5 minutes, and sometimes refuses to accept patches against versions that don't yet exist), so seems like it could do the same here? Am I missing something? Thanks! -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1575 in reviewboard: Show image files inline as part of diff view
Updates: Status: NeedInfo Comment #1 on issue 1575 by chipx86: Show image files inline as part of diff view http://code.google.com/p/reviewboard/issues/detail?id=1575 We wouldn't really be able to make this work with Git the way you'd hope, as Review Board wouldn't necessarily have access to the modifications. Today, you can upload screenshots (really, any image) much like you can with diffs and people can review that by clicking and dragging on the screenshot to comment on that region. Would that suffice? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
