Re: Issue 1953 in reviewboard: Addressing comments on "View Diff" page is not usable
Updates: Status: Duplicate Mergedinto: 1070 Comment #5 on issue 1953 by trowb...@gmail.com: Addressing comments on "View Diff" page is not usable http://code.google.com/p/reviewboard/issues/detail?id=1953 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1953 in reviewboard: Addressing comments on "View Diff" page is not usable
Comment #4 on issue 1953 by jeffl...@gmail.com: Addressing comments on "View Diff" page is not usable http://code.google.com/p/reviewboard/issues/detail?id=1953 This issue is definitely what I'm experiencing as well, but it's not very succinct. I'll try to explain in a different way. Look at the screenshot. After the first review by Brandon, Chris figured he could reply to it by typing a response in "your comment". However, that creates a new review. In order to have context on the review by brandon, he added a comment to Brandon's reply. Now, even though there's a threaded reply and a standalone new review by chris, the left pane doesn't distinguish this. I recommend three changes: - Add the ability to see threaded comment discussions to the "Other Reviews" pane. - "Your comment" should indicate it'll be a new review ... "Your review" maybe? - Clicking "reply" to a thread should change "Your review" to "Your response to Brandon" and add a comment to the threaded conversation, not to a new review. Attachments: example.png 7.9 KB -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1953 in reviewboard: Addressing comments on "View Diff" page is not usable
Comment #3 on issue 1953 by jeffl...@gmail.com: Addressing comments on "View Diff" page is not usable http://code.google.com/p/reviewboard/issues/detail?id=1953 This issue is definitely what I'm experiencing as well, but it's not very succinct. I'll try to explain in a different way. Look at the screenshot. After the first review by Brandon, Chris figured he could reply to it by typing a response in "your comment". However, that creates a new review. In order to have context on the review by brandon, he added a comment to Brandon's reply. Now, even though there's a threaded reply and a standalone new review by chris, the left pane doesn't distinguish this. I recommend three changes: - Add the ability to see threaded comment discussions to the "Other Reviews" pane. - "Your comment" should indicate it'll be a new review ... "Your review" maybe? - Clicking "reply" to a thread should change "Your review" to "Your response to Brandon Smith" and add a comment to the threaded conversation, not to a new review. Attachments: example.png 7.9 KB -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1953 in reviewboard: Addressing comments on "View Diff" page is not usable
Comment #2 on issue 1953 by jeffl...@gmail.com: Addressing comments on "View Diff" page is not usable http://code.google.com/p/reviewboard/issues/detail?id=1953 This issue is definitely what I'm experiencing as well, but it's not very succinct. I'll try to explain in a different way. Look at the screenshot. After the first review by Brandon, Chris figured he could reply to it by typing a response in "your comment". However, that creates a new review. In order to have context on the review by brandon, he added a comment to Brandon's reply. Now, even though there's a threaded reply and a standalone new review by chris, the left pane doesn't distinguish this. I recommend three changes: - Add the ability to see threaded comment discussions to the "Other Reviews" pane. - "Your comment" should indicate it'll be a new review ... "Your review" maybe? - Clicking "reply" to a thread should change "Your review" to "Your response to Brandon Smith" and add a comment to the threaded conversation, not to a new review. Attachments: example.png 7.7 KB -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 1953 in reviewboard: Addressing comments on "View Diff" page is not usable
Comment #1 on issue 1953 by fedotov.aleksei: Addressing comments on "View Diff" page is not usable http://code.google.com/p/reviewboard/issues/detail?id=1953 green box is window titled "Your comment" which appears on the right of "other reviews" (blue window) when user clicks a particular line of code. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
