Re: Issue 2555 in reviewboard: On a https Mercurial URL, a diff on a file that currently exists throws an error

2012-07-04 Thread reviewboard

Updates:
Status: Fixed

Comment #10 on issue 2555 by trowb...@gmail.com: On a https Mercurial URL,  
a diff on a file that currently exists throws an error

http://code.google.com/p/reviewboard/issues/detail?id=2555

Fixed in commit 514cbe4. This will go out with the next 1.6.x release.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2555 in reviewboard: On a https Mercurial URL, a diff on a file that currently exists throws an error

2012-06-27 Thread reviewboard


Comment #9 on issue 2555 by jon.bark...@gmail.com: On a https Mercurial  
URL, a diff on a file that currently exists throws an error

http://code.google.com/p/reviewboard/issues/detail?id=2555

You may also need to remove the hg.pyc file to get it to read the changed  
file.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2555 in reviewboard: On a https Mercurial URL, a diff on a file that currently exists throws an error

2012-05-09 Thread reviewboard


Comment #6 on issue 2555 by tph...@gmail.com: On a https Mercurial URL, a  
diff on a file that currently exists throws an error

http://code.google.com/p/reviewboard/issues/detail?id=2555

This line commented out
url = url.replace('https', 'http')
is working so far for us

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2555 in reviewboard: On a https Mercurial URL, a diff on a file that currently exists throws an error

2012-05-09 Thread reviewboard


Comment #7 on issue 2555 by mailsw...@gmail.com: On a https Mercurial URL,  
a diff on a file that currently exists throws an error

http://code.google.com/p/reviewboard/issues/detail?id=2555

In which file? Which line number?

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2555 in reviewboard: On a https Mercurial URL, a diff on a file that currently exists throws an error

2012-04-08 Thread reviewboard


Comment #5 on issue 2555 by trowb...@gmail.com: On a https Mercurial URL, a  
diff on a file that currently exists throws an error

http://code.google.com/p/reviewboard/issues/detail?id=2555

Issue 2567 has been merged into this issue.

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2555 in reviewboard: On a https Mercurial URL, a diff on a file that currently exists throws an error

2012-03-28 Thread reviewboard


Comment #1 on issue 2555 by mailsw...@gmail.com: On a https Mercurial URL,  
a diff on a file that currently exists throws an error

http://code.google.com/p/reviewboard/issues/detail?id=2555

In hg.py, the offending function is:

class HgWebClient(SCMClient):
FULL_FILE_URL = '%(url)s/%(rawpath)s/%(revision)s/%(quoted_path)s'

def __init__(self, path, username, password):
super(HgWebClient, self).__init__(path, username=username,
  password=password)

logging.debug('Initialized HgWebClient with url=%r, username=%r',
  self.path, self.username)

def cat_file(self, path, rev=tip):
if rev == HEAD or rev == UNKNOWN:
rev = tip
elif rev == PRE_CREATION:
rev = 

for rawpath in [raw-file, raw]:
try:
url = self.FULL_FILE_URL % {
'url': self.path.rstrip('/'),
'rawpath': rawpath,
'revision': rev,
'quoted_path': urllib_quote(path.lstrip('/')),
}

url = url.replace('https', 'http')
return self.get_file_http(url, path, rev)
except Exception:
# It failed. Error was logged and we may try again.
pass

raise FileNotFoundError(path, rev)

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2555 in reviewboard: On a https Mercurial URL, a diff on a file that currently exists throws an error

2012-03-28 Thread reviewboard


Comment #2 on issue 2555 by mailsw...@gmail.com: On a https Mercurial URL,  
a diff on a file that currently exists throws an error

http://code.google.com/p/reviewboard/issues/detail?id=2555

Logs:
2012-03-28 16:15:13,708 - DEBUG - Initialized HgWebClient with  
url=u'https://in.nimblestorage.com/cgi-bin/hgwebdir.cgi/dev/gui/',  
username=u'swami'
2012-03-28 16:15:13,709 - DEBUG - Initialized HgWebClient with  
url=u'https://in.nimblestorage.com/cgi-bin/hgwebdir.cgi/dev/gui/',  
username=u'swami'
2012-03-28 16:15:13,712 - DEBUG - Generating diff viewer page for filediff  
id 9
2012-03-28 16:15:13,713 - DEBUG - Begin: Generating diff file info for  
diffset id 9
2012-03-28 16:15:13,716 - DEBUG - Initialized HgWebClient with  
url=u'https://in.nimblestorage.com/cgi-bin/hgwebdir.cgi/dev/gui/',  
username=u'swami'
2012-03-28 16:15:13,716 - DEBUG - End: Generating diff file info for  
diffset id 9
2012-03-28 16:15:13,716 - DEBUG - Generating diff file info for diffset id  
9 took 0.2453 seconds
2012-03-28 16:15:13,717 - DEBUG - Begin: Generating diff file info for  
diffset id 9, filediff 14
2012-03-28 16:15:13,717 - DEBUG - Initialized HgWebClient with  
url=u'https://in.nimblestorage.com/cgi-bin/hgwebdir.cgi/dev/gui/',  
username=u'swami'
2012-03-28 16:15:13,718 - INFO - Cache miss for key  
reviews.nimblestorage.com:diff-sidebyside-hl-14.
2012-03-28 16:15:13,718 - DEBUG - Initialized HgWebClient with  
url=u'https://in.nimblestorage.com/cgi-bin/hgwebdir.cgi/dev/gui/',  
username=u'swami'
2012-03-28 16:15:13,719 - INFO - Cache miss for key  
reviews.nimblestorage.com:https%3A//in.nimblestorage.com/cgi-bin/hgwebdir.cgi/dev/gui/:README:UNKNOWN.
2012-03-28 16:15:13,719 - DEBUG - Begin: Fetching file 'README' rUNKNOWN  
from gui
2012-03-28 16:15:13,719 - INFO - Fetching file from  
http://in.nimblestorage.com/cgi-bin/hgwebdir.cgi/dev/gui/raw-file/tip/README
2012-03-28 16:15:13,722 - ERROR - Unexpected error fetching file from  
http://in.nimblestorage.com/cgi-bin/hgwebdir.cgi/dev/gui/raw-file/tip/README:  
urlopen error [Errno 111] Connection refused
2012-03-28 16:15:13,722 - INFO - Fetching file from  
http://in.nimblestorage.com/cgi-bin/hgwebdir.cgi/dev/gui/raw/tip/README
2012-03-28 16:15:13,725 - ERROR - Unexpected error fetching file from  
http://in.nimblestorage.com/cgi-bin/hgwebdir.cgi/dev/gui/raw/tip/README:  
urlopen error [Errno 111] Connection refused



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2555 in reviewboard: On a https Mercurial URL, a diff on a file that currently exists throws an error

2012-03-28 Thread reviewboard


Comment #3 on issue 2555 by mailsw...@gmail.com: On a https Mercurial URL,  
a diff on a file that currently exists throws an error

http://code.google.com/p/reviewboard/issues/detail?id=2555

When fetching the file, the https was replaced with http, resulting in the  
error.


--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.



Re: Issue 2555 in reviewboard: On a https Mercurial URL, a diff on a file that currently exists throws an error

2012-03-28 Thread reviewboard


Comment #4 on issue 2555 by mailsw...@gmail.com: On a https Mercurial URL,  
a diff on a file that currently exists throws an error

http://code.google.com/p/reviewboard/issues/detail?id=2555

Logs:
2012-03-28 16:41:44,497 - DEBUG - Initialized HgWebClient with  
url=u'https://in.example.com/cgi-bin/hgwebdir.cgi/dev/gui',  
username=u'swami'
2012-03-28 16:41:44,498 - DEBUG - Initialized HgWebClient with  
url=u'https://in.example.com/cgi-bin/hgwebdir.cgi/dev/gui',  
username=u'swami'
2012-03-28 16:41:44,500 - DEBUG - Generating diff viewer page for filediff  
id 9
2012-03-28 16:41:44,502 - DEBUG - Begin: Generating diff file info for  
diffset id 9
2012-03-28 16:41:44,504 - DEBUG - Initialized HgWebClient with  
url=u'https://in.example.com/cgi-bin/hgwebdir.cgi/dev/gui',  
username=u'swami'
2012-03-28 16:41:44,505 - DEBUG - End: Generating diff file info for  
diffset id 9
2012-03-28 16:41:44,505 - DEBUG - Generating diff file info for diffset id  
9 took 0.3049 seconds
2012-03-28 16:41:44,506 - DEBUG - Begin: Generating diff file info for  
diffset id 9, filediff 14
2012-03-28 16:41:44,506 - DEBUG - Initialized HgWebClient with  
url=u'https://in.example.com/cgi-bin/hgwebdir.cgi/dev/gui',  
username=u'swami'
2012-03-28 16:41:44,507 - INFO - Cache miss for key  
reviews.example.com:diff-sidebyside-hl-14.
2012-03-28 16:41:44,507 - DEBUG - Initialized HgWebClient with  
url=u'https://in.example.com/cgi-bin/hgwebdir.cgi/dev/gui',  
username=u'swami'
2012-03-28 16:41:44,508 - INFO - Cache miss for key  
reviews.nimblestorage.com:https%3A//in.example.com/cgi-bin/hgwebdir.cgi/dev/gui:README:UNKNOWN.
2012-03-28 16:41:44,508 - DEBUG - Begin: Fetching file 'README' rUNKNOWN  
from gui
2012-03-28 16:41:44,508 - INFO - Fetching file from  
http://in.example.com/cgi-bin/hgwebdir.cgi/dev/gui/raw-file/tip/README
2012-03-28 16:41:44,512 - ERROR - Unexpected error fetching file from  
http://in.example.com/cgi-bin/hgwebdir.cgi/dev/gui/raw-file/tip/README:  
urlopen error [Errno 111] Connection refused
2012-03-28 16:41:44,512 - INFO - Fetching file from  
http://in.example.com/cgi-bin/hgwebdir.cgi/dev/gui/raw/tip/README
2012-03-28 16:41:44,515 - ERROR - Unexpected error fetching file from  
http://in.example.com/cgi-bin/hgwebdir.cgi/dev/gui/raw/tip/README: urlopen  
error [Errno 111] Connection refused



--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To post to this group, send email to reviewboard-issues@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.