Re: Issue 2710 in reviewboard: Can see and edit other users' comments before they're published
Updates: Status: Fixed Comment #5 on issue 2710 by trowb...@gmail.com: Can see and edit other users' comments before they're published http://code.google.com/p/reviewboard/issues/detail?id=2710 Fixed in release-1.6.x (861bc59). -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2710 in reviewboard: Can see and edit other users' comments before they're published
Comment #4 on issue 2710 by timw.at@gmail.com: Can see and edit other users' comments before they're published http://code.google.com/p/reviewboard/issues/detail?id=2710 I'm not completely sure of the root cause, but here is a patch that seems to work for one case in the Reviews view (I haven't investigated related code in other views, but I've heard from my users that the diff view may experience similar problems). The check is based on a similar test earlier in the same file. --- a/reviewboard/reviews/views.py +++ b/reviewboard/reviews/views.py @@ -562,7 +562,7 @@ def review_detail(request, file_attachment._comments.append(comment) -if parent_review.is_reply(): +if parent_review.is_reply() and (parent_review.public or (request.user.is_authenticated() and parent_review.user_id == request.user.pk)): # This is a reply to a comment. Add it to the list of replies. assert obj.review_id not in reviews_entry_map assert parent_review.base_reply_to_id in reviews_entry_map -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2710 in reviewboard: Can see and edit other users' comments before they're published
Updates: Status: New Comment #3 on issue 2710 by trowb...@gmail.com: Can see and edit other users' comments before they're published http://code.google.com/p/reviewboard/issues/detail?id=2710 (No comment was entered for this change.) -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2710 in reviewboard: Can see and edit other users' comments before they're published
Updates: Status: NeedInfo Comment #1 on issue 2710 by trowb...@gmail.com: Can see and edit other users' comments before they're published http://code.google.com/p/reviewboard/issues/detail?id=2710 Is Person C an admin? -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 2710 in reviewboard: Can see and edit other users' comments before they're published
Comment #2 on issue 2710 by richa...@gmail.com: Can see and edit other users' comments before they're published http://code.google.com/p/reviewboard/issues/detail?id=2710 Person C is NOT an admin. Another person (an admin) could see the unpublished comments as well. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
